Commit Graph

1996 Commits

Author SHA1 Message Date
Ben Thomson ce8c96b66f
Automatically set SMTP port depending on mail encryption type.
This only occurs if the SMTP port field is using a standard port (25, 465, 587). Custom ports are not overwritten.

Fixes https://github.com/octobercms/october/issues/4755
2020-08-31 11:21:50 +08:00
Luke Towers 812c0552e8 Avoid logging SystemExceptions twice
SystemExceptions are already logged when the System ServiceProvider listens to the Message Logged event, this code used to be for ApplicationExceptions to bypass the fact that they were explicitly ignored by October's core exception handler.

ApplicationExceptions were added 27 Jan 2015 in 6a68036260
ApplicationExceptions were explicitly ignored in the core exception handler on 16 Feb 2015 in 237d97d87a (diff-b6bf0348130fdd1311473a97536310cdR20) and were explicitly logged in the System exception handler on the same day in 7b52e07b65 (diff-547f5794a63e9f138c33b20de8649b7eR20-R31)

Not sure why that was originally the case, but we've made the decision that ApplicationExceptions shouldn't be logged by default as they should occur semi-regularly in a healthy application (mostly as an expression of complex logical validation that triggers them based on bad user input): https://github.com/octobercms/october/pull/4569#issuecomment-550172508

Fixes octobercms/october#5253.
2020-08-28 13:57:12 -06:00
Luke Towers 6b214edf1f Add getAllPlugins() method to PluginManager 2020-08-27 15:47:42 -06:00
Luke Towers 19ebc8854e Remove unnecessary $sourceDisk & $sourcePath variables.
The $resizer instance provides access to the necessary data.
2020-08-25 11:06:38 -06:00
Luke Towers 0eac129003 Improve support for invalid inputs provided to the resize filter. 2020-08-24 15:24:40 -06:00
Luke Towers 2126cd3a0b Added $sourceDisk and $sourcePath as parameters to the image resizing events for better logging 2020-08-24 11:00:54 -06:00
Web-VPF f708754f07
Update Russian translation (#5247) 2020-08-23 02:51:48 -06:00
Luke Towers c1c728e413
Merge pull request #5231 from octobercms/wip/image-resizing
Implement core support for `| resize(width, height, options)` filter
2020-08-21 18:01:47 -06:00
Luke Towers 38718e0b5d Fixed bug where FileModel images wouldn't properly store their config after being retrieved from the cache 2020-08-21 17:53:28 -06:00
Luke Towers a25567c750 Use the same resizing process for FileModels that's used for everything else. 2020-08-21 16:22:14 -06:00
Luke Towers 825075a19b Fix support for Windows 2020-08-21 16:07:48 -06:00
Luke Towers 1e6573cc62 Cleaned up inline docs for ImageResizer, fixed tests 2020-08-21 14:07:23 -06:00
Luke Towers 444069da00 Finished implement imageWidth & imageHeight filters 2020-08-21 13:39:45 -06:00
Luke Towers 3864e5b1c6 Allow plugin view & configuration files to be registered on protected routes
Fixes #5245
2020-08-19 09:57:57 -06:00
Luke Towers 3f58951855 wip on imageWidth / imageHeight filter 2020-08-19 09:49:13 -06:00
Luke Towers 05731b1069 Fix bug 2020-08-18 13:41:53 -06:00
Ben Thomson 0020809634
Additional work on tests, should pass now 2020-08-17 16:41:49 +08:00
Ben Thomson 1fd9529786
Add 'auto' height and width options 2020-08-17 12:07:52 +08:00
Ben Thomson c25e41d51a
Remove unneeded use case 2020-08-17 10:32:52 +08:00
Luke Towers f29562023d Disable HTML5 form validation on backend Settings pages
Fixes #5239.
2020-08-15 20:59:53 -06:00
Luke Towers f346312266 Minor improvements 2020-08-15 00:55:17 -06:00
Luke Towers 7fde924ec1 Finish implementing october:util purge uploads command.
Only works for uploads stored on the local disk right now, support for remote disks may be added in the future at some point.

Replaces #4518 & #4029. Credit to @LukeTowers, @BennoThommo, & @austinderrick.
2020-08-15 00:33:08 -06:00
Luke Towers 288918a7d7 Finished initial implementation of resizer for all supported input image sources, added the storage/app/resized directory to the mirror command 2020-08-14 15:39:30 -06:00
Luke Towers 2351f2104d Implemented resizing logic for File models, fixed bugs 2020-08-13 20:58:48 -06:00
Luke Towers 04de6ef0e2 Play nicer with tests 2020-08-13 03:15:53 -06:00
Luke Towers f54b167f00 Merge branch 'develop' into wip/image-resizing 2020-08-13 03:11:20 -06:00
Luke Towers 17664dce6c Reorganized the ImageResizer class 2020-08-13 03:10:30 -06:00
Luke Towers 9cb8a0861b Finished implementing support for retrieving thumb URLs from FileModels, initial support for detecting completed resize operations 2020-08-13 03:02:06 -06:00
moisessepulveda cdb8acd214
Improvements to Spanish translations (#5237) 2020-08-13 12:03:35 +08:00
Ben Thomson 8bc440defa
Revert "Change File model to use fillable as opposed to guardable attributes"
This reverts commit abfe156d8d.
2020-08-10 09:17:32 +08:00
Ben Thomson abfe156d8d
Change File model to use fillable as opposed to guardable attributes 2020-08-10 09:07:24 +08:00
Luke Towers b4dd25534e Merge branch 'develop' into wip/image-resizing 2020-08-09 04:26:48 -06:00
Luke Towers a992fb44bc Support the resized URL as a route param instead of GET variable, initial WIP on supporting File models 2020-08-09 03:07:07 -06:00
Luke Towers 6926908dad required code from last commit 2020-08-08 20:18:11 -06:00
Luke Towers 263ae871b7 More WIP on image resizer
Refactored resizer URLs to support custom disks, switched to using a signed version of the resized image's URL as the identifier for the configuration
2020-08-08 20:17:35 -06:00
Luke Towers 7b9408e394 More WIP, moved logic in the appropriate locations 2020-08-07 23:27:32 -06:00
Luke Towers 0a9c751e1b Merge branch 'develop' into wip/laravel-6 2020-08-03 01:49:06 -06:00
Ben Thomson df2b8b5817
Recompile Storm UI JS asset 2020-08-03 11:07:55 +08:00
Ben Thomson 7f7bc04288
Merge remote-tracking branch 'origin/develop' into wip/laravel-6 2020-07-26 15:02:08 +08:00
Ben Thomson d49266ad90
Make popup textarea HTML5-compliant in Inspector editor.
Previously, this was a self-closing tag with a value attribute. Neither are supported for the textarea tag in HTML5. It appears that browsers now are actually checking this and/or won't work with it.

Fixes #5222.
2020-07-25 22:52:23 +08:00
Ben Thomson 0dee0e54b1
Alias Illuminate\Support\Debug\HtmlDumper to Symfony's HtmlDumper 2020-07-20 10:40:50 +08:00
Luke Towers 18714ae9f0 Add L6 as a dep to the modules to prevent people with older Laravel versions from accidentally pulling in the L6 update 2020-07-19 01:42:58 -06:00
Luke Towers 1aab58d1e4 Merge branch 'develop' into wip/laravel-6 2020-07-19 01:35:37 -06:00
Luke Towers a56e0cdf61 Use Arabic numerals instead of Indic ones for Arabic date translations.
Fixes #5213
2020-07-19 01:15:07 -06:00
Klaas Poortinga 517c588ef7
Fix filter type "group" when 500+ options are available (#5141)
When 500 options or more are presented in a group filter, PHP `max_input_vars` limits may prevent the filter from working. This fix passes selected options through as a JSON string to get around the limits.
2020-07-17 17:12:41 +08:00
Luke Towers d17b6eaf32 Merge branch 'develop' into wip/laravel-6 2020-07-17 00:47:32 -06:00
Ben Thomson 70eac9b0e2
Recompile assets 2020-07-16 18:00:19 +08:00
Ruben van Erk 3be6e26e84
Clear input after creating tag (#5053)
When using the taglist field type, the input isn't cleared after a tag has been created. This problem is described here: https://github.com/select2/select2/issues/4698
This change fixes that issue.
2020-07-16 17:26:49 +08:00
Ben Thomson 8fd1ddf7aa
Provide an accessor for the form widget of the Settings controller (#5212)
Co-authored-by: Luke Towers <github@luketowers.ca>
2020-07-15 14:04:01 +08:00
Ben Thomson bb3d018590
Add fallback alias for Illuminate\Support\Facades\Input
This will redirect any instances of the now-removed Input facade from Laravel to the Rain library's Input facade.
2020-07-10 15:56:11 +08:00
Ben Thomson 4950edc196
Add sensitive field input (#5201)
A field widget that allows for entering of sensitive information that can be revealed at the user's request - ie. API keys, secrets.

When a sensitive field that has been previously populated is loaded again, a placeholder is used instead of the real value, until the user opts to reveal the value. The real value is loaded via AJAX.

Credit to @tomaszstrojny for the original implementation.

Replaces #5062. Fixes #5061, #1850, perhaps #1061.

Co-authored-by: Tomasz Strojny <tomasz@init.biz>
Co-authored-by: Luke Towers <github@luketowers.ca>
2020-07-08 16:26:38 +08:00
Ben Thomson 9412a2bb20
Merge remote-tracking branch 'origin/develop' into wip/laravel-6 2020-07-01 10:42:33 +08:00
Meysam 9082a231a6
Document Select2's dynamic option creation (#5052) 2020-07-01 10:11:16 +08:00
Ben Thomson 47ca69e1f4
Merge remote-tracking branch 'origin/develop' into wip/laravel-6 2020-06-23 11:01:21 +08:00
Luke Towers 1b8fae0ef0 Fix visual glitch on inspector autocomplete fields.
Fixes #5085
2020-06-18 11:55:14 -06:00
Luke Towers b384954a29 Improve Froala sanitization of pasted content. 2020-06-18 11:03:48 -06:00
Luke Towers ad69711634 Merge branch 'develop' into wip/laravel-6 2020-06-11 10:38:29 -06:00
Ben Thomson 8dba43ba0b
Allow plugin autoloaders to load on restricted pages and actions (#5120)
Allow plugin autoloaders to load, even on restricted pages. This allows (enabled) plugins to load their autoloaders on any pages, allowing includes in migration files to run.

Fixes #5110.
2020-06-09 21:46:17 -06:00
Luke Towers 33795fe6aa Delete unnecessary file 2020-06-04 09:19:24 -06:00
Luke Towers 5c3ba9a28a Fix naming conflict
Reported by @alxy https://github.com/octobercms/october/pull/5088#issuecomment-636448210
2020-05-31 11:23:31 -06:00
Luke Towers 252c9b7f58 Merge branch 'develop' into wip/laravel-6 2020-05-27 12:44:54 -06:00
Ben Thomson a43833d511
Trigger dependency check for remote values for inspector dropdown properties (#5071) 2020-05-27 09:36:21 +08:00
Nick Khaetsky ce7335f6cb
Add warning with missing dependencies on Updates page (#5077)
Fixes #4843.
2020-05-26 10:05:40 -06:00
Alwin Drenth 8196b8169e
Improved Dutch translations (#5091) 2020-05-26 09:59:11 -06:00
Dieter Holvoet 40d8bb453e
Get file and folder metadata for media items using a single network call if possible (#5046)
Co-Authored-By: Ben Thomson <ben@abweb.com.au>. Fixes #5045.
2020-05-26 03:20:41 -06:00
Luke Towers 655c8011b9
Fix client side validation (#5088)
* Add data-request-validate to core save buttons

* Check if client side validation is desired before running it

Fixes #5076.
2020-05-25 12:53:48 -06:00
Luke Towers 908d2f91c4 Merge branch 'develop' into wip/laravel-6 2020-05-21 09:47:38 -06:00
Nick Khaetsky 7af73a0ade
Add "Install themes" button on updates page (#5075)
Very often in our community people asking question:"How do i install theme from marketplace?" 
And to answer that question we should say "Just press Install plugins button!"
That's not very intuitive for beginners. This PR adds one button that leads right to themes installation page.
2020-05-19 11:16:49 -06:00
Ben Thomson c3a5780d37
Update providers and alias to use October Validator service 2020-05-19 12:47:49 +08:00
Ben Thomson 5c8f567323
Merge remote-tracking branch 'origin/develop' into wip/laravel-6 2020-05-18 08:35:03 +08:00
Mantas Šimkūnas a5ccfb2f99
Documented indeterminate checkboxes (#5068) 2020-05-12 11:30:03 -06:00
Marc Jauvin 15e4e53901
fix typos in halcyon (#5066) 2020-05-05 11:12:45 -06:00
Luke Towers e78d5fe2bf Merge branch 'develop' into wip/laravel-6
# Conflicts:
#	modules/system/classes/UpdateManager.php
#	modules/system/classes/VersionManager.php
2020-04-29 16:58:58 -06:00
Web-VPF a2b835864e
Updated Russian translation (#5048) 2020-04-21 14:50:50 -06:00
Calum 1c621ae4c9
Support git submodules in october:util git pull (#5047) 2020-04-19 19:56:19 -06:00
Aurélien Roy 6097566c52
Allow blob files naming in AJAX request (#5042) 2020-04-18 20:43:47 -06:00
Đorđe Jocić d029d6ea24
Added Serbian translation (#5040) 2020-04-14 21:58:47 -06:00
Ben Thomson 965732bd45
Allow sidePanel to be used independent of sideNav
Also, updated compiled assets
2020-04-15 00:16:29 +08:00
Kallef Alexandre b4c65e9feb
Added plugin:rollback command (#4389) 2020-04-11 09:46:22 -06:00
Mike Robinson d69ade86d1
Validate backend forms client-side (#4804)
Fixes #4799.
2020-04-09 14:24:51 -06:00
Ben Thomson 460aca5b01
Reset outline to default - roll back #4895 (#5035)
Replaces #4965. Rolls back #4895. Fixes #4964. Partially fixes #4819.

The previous attempts to add a stylised "focus" ring, while with the best intentions, did not take into account how "outline" normally works for people using visual aids. Most high contrast software will effect the outline if its available (ie. make it bolder or more prevalant), thus the "outline" property is paramount to maintaining accessibility.

The previous changes also present issues with elements using box-shadows already, and again, on high contrast, box-shadows are no longer rendered.

This change will bring back the outline property for focus, but with an addition to allow a blue highlight for Firefox, would should keep it in "parity" with WebKit.

Refs:
- https://a11yproject.com/posts/never-remove-css-outlines/
-  http://www.outlinenone.com
- https://stackoverflow.com/questions/52589391/css-box-shadow-vs-outline
2020-04-09 11:50:00 -06:00
Luke Towers 6a6331ba15 Merge branch 'develop' into wip/laravel-6 2020-04-08 12:40:02 -06:00
Ben Thomson 9155e7de7e
Properly scope the search query in filter widgets.
The search input in filters used a local data request to filter options. While this worked fine for most cases, it failed inside modal relations as the relation keys were not being pushed through due to the request not being linked to the relation modal.

This refactors the request to run through the relation modal, emulating the functionality of "data-track-input" to debounce text entry.

Fixes https://github.com/octobercms/october/issues/4775
2020-04-06 15:45:22 +08:00
Blaž Oražem 758d8e01e3
Slovenian language update (#5028) 2020-04-05 22:46:24 +08:00
Luke Towers 9574e2dba9 Merge branch 'develop' into wip/laravel-6 2020-04-04 23:16:56 -06:00
Larry Barker 56e2805f15
Add option to ignore timestamps for date range filters (#4966) 2020-04-04 22:12:32 -06:00
Luke Towers c7c94347f2 Compile assets 2020-04-04 22:02:18 -06:00
Rike-cz b445b65150
Add support for linkable form tabs (#4754) 2020-04-04 21:56:48 -06:00
Luke Towers 4b22d06c60 Merge branch 'develop' into wip/laravel-6 2020-04-04 14:11:05 -06:00
Szabó Gergő b8a6571c1c
Improved Hungarian translation (#5027) 2020-04-04 14:05:01 -06:00
Luke Towers 44cc5d371b Merge branch 'develop' into wip/laravel-6 2020-04-04 02:32:16 -06:00
Luke Towers 8b9c001b9a Allow disabled plugin's translations to load for display translations on system pages 2020-04-02 22:15:30 -06:00
LeMaX10 ea42de9181
Use plugin & theme path helpers in the update manager (#4770) 2020-04-02 10:52:23 -06:00
Luke Towers ccb2c372bb Only force absolute URLs for media items if cms.linkPolicy = force
This fixes #4082 & rainlab/pages-plugin#405. Reverts a previous breaking change from Build 444 (introduced in #3536) by limiting the scope to which it applies.
2020-04-02 10:18:23 -06:00
Marc Jauvin b1d41caf03
Improve PluginManager code (#5023) 2020-04-02 09:30:15 -06:00
Marc Jauvin 600fbd7cfa
Improve code readability for exists method (#5022) 2020-04-02 08:33:58 -06:00
Luke Towers 61b4ef6a47 Minor cleanups to the PluginManager.
Cleans up docblocks and makes most helper methods more permissive of incorrectly cased plugin identifiers. Replaces #4838 & #4837. Credit to @mjuavin for the case insensitivity fixes.
2020-04-01 21:30:54 -06:00
Luke Towers e4571c3dd4
Add usingSource method to active datasource (#5017)
This allows the `theme:sync` command to properly sync to specified targets.

Fixes #4887. Replaces #4935. Credit to @bennothommo for the initial implementation.
2020-04-01 18:12:50 +08:00
Luke Towers 79f0a9413b Merge branch 'develop' into wip/laravel-6
# Conflicts:
#	composer.json
2020-03-31 04:36:47 -06:00
fansaien 9995dddc75
Load mail layouts from view files if not found in the database (#4904)
Brings mail layouts more in line with the rest of the mail template pieces by loading from the relevant view files when the layout doesn't exist in the database.
2020-03-31 02:27:46 -06:00