TPS
/
ORIENT
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary $sourceDisk & $sourcePath variables. 

The $resizer instance provides access to the necessary data.
This commit is contained in:
Luke Towers 2020-08-25 11:06:38 -06:00
parent 0eac129003
commit 19ebc8854e
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
modules/system/classes/ImageResizer.php
View File

@ -261,13 +261,9 @@ class ImageResizer
* Halting event that enables replacement of the resizing process. There should only ever be
* one listener handling this event per project at most, as other listeners would be ignored.
*
* > **NOTE:** The `$sourceDisk` and `$sourcePath` variables are only provided for informational
* purposes, i.e. logging errors. They should never be interacted with directly, only interact
* with the `$localTempPath` variable.
*
* Example usage:
*
* Event::listen('system.resizer.processResize', function ((\System\Classes\ImageResizer) $resizer, (string) $localTempPath, (\Illuminate\Filesystem\FilesystemAdapter) $sourceDisk, (string) $sourcePath) {
* Event::listen('system.resizer.processResize', function ((\System\Classes\ImageResizer) $resizer, (string) $localTempPath) {
* // Get the resizing configuration
* $config = $resizer->getConfig();
*
@ -282,7 +278,7 @@ class ImageResizer
* });
*
*/
$processed = Event::fire('system.resizer.processResize', [$this, $tempPath, $disk, $path], true);
$processed = Event::fire('system.resizer.processResize', [$this, $tempPath], true);
if (!$processed) {
// Process the resize with the default image resizer
DefaultResizer::open($tempPath)
@ -295,13 +291,9 @@ class ImageResizer
* Enables post processing of resized images after they've been resized before the
* resizing process is finalized (ex. adding watermarks, further optimizing, etc)
*
* > **NOTE:** The `$sourceDisk` and `$sourcePath` variables are only provided for informational
* purposes, i.e. logging errors. They should never be interacted with directly, only interact
* with the `$localTempPath` variable.
*
* Example usage:
*
* Event::listen('system.resizer.afterResize', function ((\System\Classes\ImageResizer) $resizer, (string) $localTempPath, (\Illuminate\Filesystem\FilesystemAdapter) $disk, (string) $path)) {
* Event::listen('system.resizer.afterResize', function ((\System\Classes\ImageResizer) $resizer, (string) $localTempPath) {
* // Get the resized image data
* $resizedImageContents = file_get_contents($localTempPath);
*
@ -313,7 +305,7 @@ class ImageResizer
* });
*
*/
Event::fire('system.resizer.afterResize', [$this, $tempPath, $disk, $path]);
Event::fire('system.resizer.afterResize', [$this, $tempPath]);
// Store the resized image
$disk->put($path, file_get_contents($tempPath));