merdan
/
sarga
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoided Multiple Method Call

This commit is contained in:
devansh bawari 2020-10-06 10:35:26 +05:30
parent 77a37bab08
commit 9f297a6c20
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/Webkul/API/Http/Controllers/Shop/CartController.php
View File

@ -155,7 +155,9 @@ class CartController extends Controller
return response($validator->errors(), Response::HTTP_BAD_REQUEST); return response($validator->errors(), Response::HTTP_BAD_REQUEST);
} }
foreach ($request->get('qty') as $qty) { $requestedQuantity = $request->get('qty');
foreach ($requestedQuantity as $qty) {
if ($qty <= 0) { if ($qty <= 0) {
return response()->json([ return response()->json([
'message' => trans('shop::app.checkout.cart.quantity.illegal'), 'message' => trans('shop::app.checkout.cart.quantity.illegal'),
@ -163,12 +165,12 @@ class CartController extends Controller
} }
} }
foreach ($request->get('qty') as $itemId => $qty) { foreach ($requestedQuantity as $itemId => $qty) {
$item = $this->cartItemRepository->findOneByField('id', $itemId); $item = $this->cartItemRepository->findOneByField('id', $itemId);
Event::dispatch('checkout.cart.item.update.before', $itemId); Event::dispatch('checkout.cart.item.update.before', $itemId);
Cart::updateItems(['qty' => $request->get('qty')]); Cart::updateItems(['qty' => $requestedQuantity]);
Event::dispatch('checkout.cart.item.update.after', $item); Event::dispatch('checkout.cart.item.update.after', $item);
} }