From 9f297a6c20500a501315a734e5427fe3cdce81fe Mon Sep 17 00:00:00 2001 From: devansh bawari Date: Tue, 6 Oct 2020 10:35:26 +0530 Subject: [PATCH] Avoided Multiple Method Call --- .../Webkul/API/Http/Controllers/Shop/CartController.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/Webkul/API/Http/Controllers/Shop/CartController.php b/packages/Webkul/API/Http/Controllers/Shop/CartController.php index 1d8ba4096..56420c33e 100644 --- a/packages/Webkul/API/Http/Controllers/Shop/CartController.php +++ b/packages/Webkul/API/Http/Controllers/Shop/CartController.php @@ -155,7 +155,9 @@ class CartController extends Controller return response($validator->errors(), Response::HTTP_BAD_REQUEST); } - foreach ($request->get('qty') as $qty) { + $requestedQuantity = $request->get('qty'); + + foreach ($requestedQuantity as $qty) { if ($qty <= 0) { return response()->json([ 'message' => trans('shop::app.checkout.cart.quantity.illegal'), @@ -163,12 +165,12 @@ class CartController extends Controller } } - foreach ($request->get('qty') as $itemId => $qty) { + foreach ($requestedQuantity as $itemId => $qty) { $item = $this->cartItemRepository->findOneByField('id', $itemId); Event::dispatch('checkout.cart.item.update.before', $itemId); - Cart::updateItems(['qty' => $request->get('qty')]); + Cart::updateItems(['qty' => $requestedQuantity]); Event::dispatch('checkout.cart.item.update.after', $item); }