Commit Graph

581 Commits

Author SHA1 Message Date
Luke Towers f3f655cc25
Merge pull request #4234 from octobercms/fix/repeater-cleanup
Simplify Repeater Logic. Fixes #4230. Related: https://github.com/rainlab/translate-plugin/pull/466
2019-04-17 17:15:48 -06:00
Rachasak Ragkamnerd 70cd444f8a Added support for 'cache' attribute to addJs() to disable CF RocketLoader (#4092)
Credit to @itpcc 

Due to CloudFlare Rocket Loader, CF will automatically try to optimize page loading speed by changing script type attribute. This breaks the script execution order and makes the user unable to upload the file(s) in the backend using "FileUpload" widget.

However, [CloudFlare allows adding "data-cfasync"](https://support.cloudflare.com/hc/en-us/articles/200169436-How-can-I-have-Rocket-Loader-ignore-specific-JavaScripts-) to prevent this. And it was used in the [commit #3841](https://github.com/octobercms/october/pull/3841/files).
2019-04-16 20:27:13 -06:00
SeriousKen 38070b0111 Fix ability to clear RecodFinder when useRelation = false (#4256)
Fixes #4255. Credit to @SeriousKen
2019-04-15 16:49:29 -06:00
Szabó Gergő 7189cc7fcb Improved Hungarian translation (#4250)
Backend: Added new brand settings option label and no image message.
System: Added changelog and custom error messages.
Richeditor: Many correction (https://github.com/froala/wysiwyg-editor/blob/master/js/languages/hu.js).
2019-04-11 13:39:43 +03:00
Ben Thomson ee2b53fe71 Add hidden "loaded" flag for repeaters
This allows the repeater to retrieve the load value
from the model only on initialisation. Any further
requests to the repeater (ie. AJAX requests) should
use the POST data.
2019-04-11 17:57:27 +08:00
Ben Thomson ac98f70a25 Revert reordering handler changes 2019-04-11 10:37:39 +08:00
Ben Thomson a00e546f5f Clean up processItems() method 2019-04-10 13:20:51 +08:00
Ben Thomson 9b5bd83f10 Reset indexes when processing POST data 2019-04-09 15:35:07 +08:00
Ben Thomson 744d578df7 Only run sortable handler if specified 2019-04-09 10:52:14 +08:00
Ben Thomson f49b5ab4b8 Add callback for handling sorted repeater items 2019-04-08 23:40:41 +08:00
Ben Thomson 98832fbc57 Initial work on handlers for re-ordering repeater items 2019-04-08 15:57:04 +08:00
Ben Thomson 332ed62931 Increment index count after new item is created
Effectively starts the repeater item indexes from 0
2019-04-08 14:37:36 +08:00
rejuvenatedigital aeeb791899 Fixes cursor position being lost when adding an image from the mediafinder to a richeditor (#4233)
Credit to @rejuvenatedigital
2019-04-05 09:27:48 -06:00
Luke Towers bfe03803e6 Fix the repeater on every context, not just static page fields 2019-04-05 09:00:26 -06:00
Luke Towers b4b4b1b566 Remove extra __index_ and __group_ fields from the Repeater and use only the data itself to handle initializing widgets and processing data.
Refs: #4230
2019-04-04 01:23:32 -06:00
Ben Thomson aee4205b44 Fix datatable alias to be a single string (#4231)
Credit to @bennothommo
2019-04-03 15:48:15 -06:00
Sebastiaan Kloos dadb3e2c01 Add support for preview mode for the Markdown FormWidget (#4166)
Credit to @SebastiaanKloos
2019-04-01 12:56:14 -06:00
Luke Towers 4fbe3fdd8f removed extra line of whitespace 2019-04-01 12:41:08 -06:00
Luke Towers ecccafa319 Fix issue where grouped repeaters stopped working in a recent build. Refs: 13a7cc915d (commitcomment-32986586) 2019-04-01 12:37:32 -06:00
Alexander Guth abb0b16b0f Append the color picker modal to parent element (#4199)
This fixes #4117 
Currently, the color picker modal (palette) is appended to the body (default) which makes it unusable in Octobers modals, e.g. for related model forms. This fixes this issue by appending the spectrum div to the parent element.

Credit to @alxy
2019-03-31 21:41:04 -06:00
Samuel Georges cca64db205 Fix expired message 2019-03-29 17:44:57 +11:00
Samuel Georges 5190c8177b Avoid terminating the app using exit() or die()
Refs #3783
Refs #3746
2019-03-29 07:10:07 +11:00
Samuel Georges 463008450b Bump froala_editor to v2.9.3 2019-03-29 03:49:46 +11:00
Samuel Georges 6593651331 Add file check for image upload form widgets - Fixes #3653 2019-03-29 02:23:20 +11:00
Luke Towers 3954704dda Fix issue with multiple repeaters with the same fieldname embedded in the same controller
There was a conflict between two repeaters that had the same fieldName (data) bound to the same controller. Example:

Controller: Events
Manages a ReportTemplate model with a custom popup Form widget that uses a grouped repeater with the field name data to define the available "fields" within a ReportTemplate
Also manages Report models through a relation controller that uses a Form widget with a regular repeater with the field name data that defines the values of the fields defined by the associated ReportTemplate.

Since both repeaters had the field name of "data", but one of them was grouped and the other wasn't, this would cause an issue in Repeater::processExistingItems() where the grouped repeater would attempt to process the ungrouped repeater's data which would then fail. This issue could easily cause many other vastly more confusing and difficult to detect issues in cases where multiple repeaters with the same field name AND the same mode (grouped vs regular) existed on the same page under different contexts. The simple solution is just to ensure that the indexInputName and groupInputName are both taking the repeater's alias into account when being generated to ensure that everything stays unique like it should.
2019-03-18 12:39:12 -06:00
Ben Thomson 13a7cc915d Use Form getSaveData method when saving form widgets within repeaters (#4160)
Credit to @bennothommo
2019-03-15 22:39:34 -06:00
Luke Towers d5e7419312 Support enableDefaults on repeaters using grouped mode 2019-03-12 01:19:37 -06:00
Panagiotis Koursaris bb0a23f54c fixes enable Defaults on repeater (#4129)
Credit to @panakour
2019-02-11 09:54:55 -06:00
Ben Thomson 10d97d515f Use singular byte for '1 byte' filesize (#4130)
Credit to @bennothommo
2019-02-11 09:48:15 -06:00
fansaien 680c729f90 Set the datetime value with time 00:00:00 when using the date mode (#4111)
Credit to @fansaien
2019-02-06 10:23:50 -06:00
Ben Thomson 4f3997c6de Make the filesize display in file upload widget more consistent (#4110)
Credit to @bennothommo. Fixes #4085.
2019-02-04 12:54:07 -06:00
Ben Thomson 970d5622c0 Allow datatables to work within a repeater (#4102)
Fixes #4063. Credit to @bennothommo.
2019-02-04 12:50:40 -06:00
Antonie Hogewoning 16ca521cd0 Fix setting default values for repeater in update context (#4098)
Credit to @CptMeatball
2019-01-31 13:50:21 -06:00
Luke Towers 920eb15af5 Added support for using the record finder without a model relationship
Added useRelation and modelClass config options
2019-01-18 18:16:16 -06:00
Luke Towers 3ff77120c6 Improved disabled support for balloon-selector and fileupload fields 2019-01-16 13:32:31 -06:00
Luke Towers 2d6b9c76a9 Recompile assets 2019-01-15 13:35:12 -06:00
Luke Towers a9a0544ab0 recompiled stylesheets, retaining newlines for improved diff readability 2019-01-14 11:52:16 -06:00
fansaien d6b1b6e95d Fixed the Delete and Enter not being captured in keydown.oc.richeditor (#4015)
Credit to @fansaien.

The keydown event can not capture the Backspace(Delete) and Enter key event. 

Moved the binding keydown function into froalaEditor.initialized event to solve this issue. Please review this Froala Editor issue: https://github.com/froala/wysiwyg-editor/issues/1879

The editor.events doesn't support off function. So, can not call off function in the unregisterHandlers()
2019-01-03 14:07:29 -06:00
Luke Towers 400ce2391e Fix support for the placeholder property in RichEditor FormWidgets 2018-12-27 15:28:10 -06:00
Luke Towers ed226e0b09 Recompiled hotkey JS 2018-12-20 13:41:32 -06:00
Luke Towers 44ac62abeb Recompiled LESS using new CSS minification 2018-12-20 13:41:09 -06:00
munxar e6f4e13446 Added NestedForm FormWidget (#3977)
Credit to @munxar
2018-12-19 21:54:20 -06:00
fansaien db7610d5c4 Removed the deprecated hotkeyMac (#3995)
Reference: fd264a5fb4 (diff-79eab92a9098980b73745ce9b5ac1895)
2018-12-19 20:21:05 -06:00
Tim caf7cb406f MediaFinder: trigger change event (#3446)
Credit to @scorewinner.
2018-12-04 11:12:26 -06:00
Christos Christou 9f63ad2739 Fix Repeater max & min client side validation when using groups (#3953)
Credit to @c2webstudio.
2018-12-03 13:53:12 -06:00
Ayumi Hamasaki 8e9b3dba54 Improve visibility of code editor buttons in the backend (#3948)
Credit to @ayumihamsaki. Fixes #3947.
2018-11-30 16:59:08 -06:00
Romaldy Minaya cca3c704a3 Fixes #3119 (#3163)
Added readOnly support to RecordFinder, Switch widget and relation widget including dropdown Fixes #3119. Credit to @romaldyminaya
2018-11-23 00:33:01 -06:00
Siarhei Karavai ff8b967b75 Add support for placeholder in TagList widgets (#3453)
Credit to @GinoPane.
2018-11-15 13:32:59 -06:00
Kanstantsin 813721edf1 Change z-index of full-screen markdown editor (#3838)
Fixes #3837. Credit to @iotch. Tested with Octodock provided by @petehalverson.
2018-10-03 10:56:08 -06:00
Samuel Georges 5cc327c45c
Merge pull request #3690 from nathan-van-der-werf/feature/cleanup
Code cleanups
2018-08-30 13:12:42 +10:00