TPS
/
ORIENT
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix issue where grouped repeaters stopped working in a recent build. Refs: 13a7cc915d (commitcomment-32986586)

This commit is contained in:
Luke Towers 2019-04-01 12:37:32 -06:00
parent abb0b16b0f
commit ecccafa319
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
modules/backend/formwidgets/Repeater.php
View File

@ -189,7 +189,11 @@ class Repeater extends FormWidgetBase
if ($this->useGroups) {
foreach ($value as $index => &$data) {
$data['_group'] = $this->getGroupCodeFromIndex($index);
}
// Make sure the $data reference is removed from memory so that the next loop won't modify it
// which would cause the last item to receive the group code of the second-last item
unset($data);
}
if ($this->minItems && count($value) < $this->minItems) {
@ -204,7 +208,11 @@ class Repeater extends FormWidgetBase
*/
foreach ($value as $index => $data) {
if (isset($this->formWidgets[$index])) {
$value[$index] = $this->formWidgets[$index]->getSaveData();
if ($this->useGroups) {
$value[$index] = array_merge($this->formWidgets[$index]->getSaveData(), ['_group' => $data['_group']]);
} else {
$value[$index] = $this->formWidgets[$index]->getSaveData();
}
}
}