Commit Graph

4844 Commits

Author SHA1 Message Date
Ben Thomson b5a3c64bf1
Fix "widget not bound to controller" error for nested repeaters (#4434)
Since repeaters have no value by themselves, a repeater that contains only another repeater was throwing a "widget not bound to controller" exception when adding a new item - the repeater item processing was not creating a form widget for the inner repeater on load, or in an AJAX call. This fix specifically checks if a child repeater has called for a new item, and if so and the current repeater has no value for this particular item, it will add a "stub" form widget to correctly bind the widget.

Fixes #4344.
2019-08-07 22:44:31 +08:00
RickAcb 0383af6282 Update __isset function to comply with the same checks as __get (#4514)
Credit to @RickAcb.
2019-08-04 19:56:15 +08:00
Ben Thomson 8219f19e8d
Style side panel header with brand colors
Remove commented-out code
2019-08-04 15:35:18 +08:00
Luke Towers 4df3149efd Merge branch 'master' into develop 2019-07-30 09:36:23 -06:00
Luke Towers 37eb5b0c3c Reordered issue templates 2019-07-30 09:35:29 -06:00
Luke Towers c18fc84766 Reordered support templates 2019-07-30 09:32:53 -06:00
Ben Thomson 89165f55b5
Change icon for marketplace support template. 2019-07-30 09:18:18 +08:00
Ben Thomson 216a54fca4
Add marketplace support issue template.
Credit to @ayumihamsaki.
2019-07-30 09:08:57 +08:00
Ayumi Hamasaki 5e18655ae9 Fix Rich Editor focus to fill the full height of the container (#4485)
Credit to @ayumihamsaki.
2019-07-30 09:04:38 +08:00
Luke Towers 99777f5977 Fix issue with AJAX framework load order on the frontend.
Partially reverts f4e50ddd1a in response to https://github.com/octobercms/october/pull/4285#issuecomment-513566437. Functionality can be re-added at a later date under an optional parameter added to the {% framework %} tag. Replaces https://github.com/octobercms/october/pull/4469
2019-07-29 16:30:14 -06:00
Luke Towers d910ff8fbe Merge branch 'master' into develop 2019-07-29 16:11:11 -06:00
Luke Towers d8cd45163d Fixed the focus outline for no results on the CodeEditor search box. Credit to @ayumihamsaki. Replaces #4483. Fixes #4482. 2019-07-26 15:05:07 -06:00
Anurat Chapanond 02ba765a9e Added Thai translation (#4472)
Credit to @anurat.
2019-07-26 14:52:52 -06:00
Ben Thomson 610e0c383c
Set validation attributes after context check.
This prevent fields with multiple contexts from overwriting the label name of another context in the validation messages.

Fixes https://github.com/rainlab/user-plugin/issues/371.
2019-07-26 00:27:45 +08:00
Samuell df81ea182b Remove alert to prevent showing same popup twice (#4470)
Credit to @Samuell1
2019-07-24 12:33:18 -06:00
Luke Towers 1587c7f49c Warn developers to not be silly. Fixes #4466. 2019-07-23 11:17:56 -06:00
Ben Thomson a7bc442df5
Pass through enableDefaults config to nested forms
This should allow default values to be used in nested form fields within new repeater items.

Fixes #4380.
2019-07-23 11:20:18 +08:00
Samuell 36c69a063b Add support for tab icons in theme customization (#4464)
Fixes #4131. Credit to @Samuell1
2019-07-21 23:45:30 -06:00
Samuell c21c22e1ba Add option to disable UpdateManager after backend login (#4266)
Credit to @Samuell1. Fixes #3471.
2019-07-19 14:50:42 -06:00
Kallef Alexandre 84a1df63f2 Hide link to "Access Logs" when the user doesn't have access (#4462)
Credit to @prhost
2019-07-19 09:53:02 -06:00
Ben Thomson a59d3b83eb Code quality clean up (#4449)
Credit to @bennothommo
2019-07-18 08:50:37 -06:00
webmaxx cc7d595fff Added `maxFilesize` option to the `FileUpload` FormWidget (#4077)
Credit to @webmaxx
2019-07-18 08:48:31 -06:00
Ayumi Hamasaki ae5f1a4282 Clean up output of Twig dump() function (#4460)
Credit to @ayumihamsaki. Fixes #4446.
2019-07-17 22:54:24 -06:00
Alexander Guth 7557173df4 Fix text filter scope (#4445)
Credit to @alxy. Fixes https://github.com/octobercms/october/pull/4241#issuecomment-510140574
2019-07-17 15:12:32 -06:00
Ayumi Hamasaki 22847e7892 Improve backend accessibility (#4401)
Credit to @ayumihamsaki. Fixes #4400.

- Added WAI-ARIA to the layout templates files.
- Added Focus-ring polyfill to allow better keyboard navigation and screen reader support.
- Added WAI-ARIA to tabs and created keyboard arrow controls for tabs.
- Added event.key polyfill to allow removal of deprecated event.keyCode, event.charCode and event.which.
- Fixed all the whitespace, tabbing and indent issues with all the lang files.
- Keyboard navigation now allows the following key actions: Tab, Up Arrow, Down Arrow, Left Arrow, Right Arrow, Home and End buttons.
- Added keyboard navigation for tab panels.
2019-07-17 15:07:45 -06:00
Anita e9665ab551 Fix layout of colorpicker for no custom color selected (#4457)
Credit to @anitaeisenhaber
2019-07-17 14:54:02 -06:00
Aleksey Sannikov 0df2e4e776 Update lang.php (Russian) (#4455)
Credit to @jexme.
2019-07-16 13:44:11 +03:00
Alexander Voronin f4240d7e2c Fix: Disabled global AJAX events (#4282)
Credit to @VoroninWD.
2019-07-14 23:41:35 +03:00
Kallef Alexandre 94a71ff3da Improved Brazilian Portuguese translations (#4450)
Credit to @prhost
2019-07-13 16:42:43 -06:00
Luke Towers c04b7faecc
Translate Inspector option titles 2019-07-12 09:42:22 -06:00
Dan Harrin 1089d8e763 Missing Spanish Translations (#4448)
Credit to @DanHarrin.
2019-07-12 11:02:39 +03:00
Long Wen 2613141870 Update zh-cn/lang.php file (#4447)
Credit to @wenlong-date.
2019-07-11 17:21:24 +03:00
Luke Towers 7782e04ef8
Fix typo
Credit to @alxy for spotting it
2019-07-09 09:52:30 -06:00
Luke Towers e0e951dfcd
Disable searching and sorting on any_template
Fixes #4441. Make the new template and old template columns visible and sort by them instead if you need to sort by that column.
2019-07-09 08:38:30 -06:00
Luke Towers 029a299816
Remove support for invalid relation type column
Fixes #4443.
2019-07-09 08:25:08 -06:00
Luke Towers f9f337e664
Only attempt to translate string values
Fixes #4398. Credit to @w20k for finding the issue.
2019-07-09 08:12:44 -06:00
Luke Towers 6f583b3920
Disable theme config cache when debug mode enabled 2019-07-08 16:25:25 -06:00
Ayumi Hamasaki 23282bbaa6 Accessibility enhancement for code editor icons (#4395)
Credit to @ayumihamsaki. Fixes #4392
2019-07-08 10:51:25 +03:00
Ben Thomson be2a850787
Fix code quality errors in Lists widget 2019-07-07 14:49:56 +08:00
Ben Thomson c1dcc62559
Increment column count when tree is shown
Fix centering of no record message in lists when tree is enabled.
2019-07-07 13:05:18 +08:00
Long Wen 07a852ed8a Fix selection issue for similar-named CMS objects (#4433)
CMS objects with the same name as another object (eg. "test.htm" for a page and "test.htm" for a partial) were unable to be selected (selecting the partial selected the page).

Credit to @wenlong-date.
2019-07-05 16:47:30 +08:00
Luke Towers 217d52bc77
Add open collective link to support options 2019-07-02 23:55:35 -06:00
Tobias Kündig 604f0d060d Make plugin dependency checks case-insensitive (#4337)
Normalize the plugin identifier before lookup in the `hasPlugin` call, which should allow plugin dependencies to resolve if mis-cased in the Plugin `$require` property.

Credit to @tobias-kuendig.
2019-07-02 22:12:29 +08:00
Ben Thomson 5b80ad2501
Add additional test cases for PluginManager (#4427)
- Add dependency tests
- Add tests that check wrong casing in requirements
- Clean up current tests
- Provides test case for https://github.com/octobercms/october/pull/4337
2019-07-02 15:34:41 +08:00
Dan Harrin 7f29cbe13c Fix support for custom Select2 options via the AJAX framework (#4414)
Fixes #4413. Credit to @DanHarrin
2019-07-01 09:04:15 -06:00
Ben Thomson 3eac21219f
Clean up index functionality in Repeater widget (#4424)
- Remove $indexCount property, as it is no longer needed
- Determine highest key number in data, and increment when adding item
- Remove some old code and dependencies

Fixes #4402.
2019-06-29 13:42:45 +08:00
Luke Towers 315e2dcac5
Add links to sponsoring locations 2019-06-28 15:16:50 -06:00
Kallef Alexandre 31b6a1f471 Improved Brazilian Portuguese translation (#4415)
Credit to @prhost
2019-06-27 10:34:26 -06:00
Ayumi Hamasaki 884042952f Block off SW running in backend and reduce lookups (#4385)
Credit to @ayumihamsaki. Related #4384
2019-06-25 17:15:11 +03:00
Ben Thomson 53a825222d
Add exceptions to PHPCS as per developer guide 2019-06-25 17:42:40 +08:00