Commit Graph

5606 Commits

Author SHA1 Message Date
Luke Towers dd5fd34ae7 Merge branch '1.0' into develop 2020-09-04 01:27:53 -06:00
Luke Towers 7cb148c167 minor cleanup and docblocks 2020-09-04 01:23:03 -06:00
Samuel Georges ceb2ff8a6e Clean up redundancies 2020-09-04 13:35:21 +10:00
Samuel Georges 4c650bb775 Security fixes for v1.0.469
Introduces sandbox policy to block extendable methods allowing arbitrary code execution
2020-09-04 13:02:01 +10:00
Ben Thomson 106daa2930
Fix unit tests for source manifest 2020-09-03 11:52:03 +08:00
Ben Thomson 5bceda9496
Add "changes" option for "october:version" command.
Will include a list of added/modified/removed files when detecting the October CMS build.
2020-09-03 11:48:35 +08:00
Ben Thomson 4141646105
Implement improved "set build" replacement (#5087)
This change implements an improved "set build" utility through the "october:version" Artisan command that, instead of checking the October CMS server for the latest build, checks the module files against a source manifest kept on GitHub.

This check allows us to accurately determine the build based on the module files in the October CMS installation, and can even detect versions if the module files are modified (except in the cases of extreme modification).

An additional utility has been implemented, "october:manifest", which will build the manifest JSON file in order to provide the maintainers with a way of generating this manifest file as required.

Replaces #4615.
2020-09-02 14:48:08 +08:00
Web-VPF 50bdfa0c39
Improve Russian translations (#5258) 2020-09-02 11:58:00 +08:00
Luke Towers bf241baee7 Fix handling some target values for linkable tabs.
Replaces #5257
2020-09-01 13:27:03 -06:00
Ben Thomson 32c63e0e3c
Reorder cases to keep default at bottom as per established style 2020-08-31 16:00:21 +08:00
Ben Thomson dce3931f20
Clean up uncustomised partials if they are no longer provided.
An exception was being thrown in some instances if a partial had been added to the DB that was provided by a plugin that no longer exists, or had been disabled. This will remove any partials provided by non-existent plugins, only if they haven't been subsequently customised by the developer.

Fixes https://github.com/octobercms/october/issues/5065
2020-08-31 14:18:53 +08:00
Ben Thomson ce8c96b66f
Automatically set SMTP port depending on mail encryption type.
This only occurs if the SMTP port field is using a standard port (25, 465, 587). Custom ports are not overwritten.

Fixes https://github.com/octobercms/october/issues/4755
2020-08-31 11:21:50 +08:00
Luke Towers acd0616aaa Fix typo, credit to @alxy for identifying 2020-08-30 02:08:06 -06:00
Luke Towers 812c0552e8 Avoid logging SystemExceptions twice
SystemExceptions are already logged when the System ServiceProvider listens to the Message Logged event, this code used to be for ApplicationExceptions to bypass the fact that they were explicitly ignored by October's core exception handler.

ApplicationExceptions were added 27 Jan 2015 in 6a68036260
ApplicationExceptions were explicitly ignored in the core exception handler on 16 Feb 2015 in 237d97d87a (diff-b6bf0348130fdd1311473a97536310cdR20) and were explicitly logged in the System exception handler on the same day in 7b52e07b65 (diff-547f5794a63e9f138c33b20de8649b7eR20-R31)

Not sure why that was originally the case, but we've made the decision that ApplicationExceptions shouldn't be logged by default as they should occur semi-regularly in a healthy application (mostly as an expression of complex logical validation that triggers them based on bad user input): https://github.com/octobercms/october/pull/4569#issuecomment-550172508

Fixes octobercms/october#5253.
2020-08-28 13:57:12 -06:00
Luke Towers 6b214edf1f Add getAllPlugins() method to PluginManager 2020-08-27 15:47:42 -06:00
Luke Towers 19ebc8854e Remove unnecessary $sourceDisk & $sourcePath variables.
The $resizer instance provides access to the necessary data.
2020-08-25 11:06:38 -06:00
Luke Towers 0eac129003 Improve support for invalid inputs provided to the resize filter. 2020-08-24 15:24:40 -06:00
Luke Towers 2126cd3a0b Added $sourceDisk and $sourcePath as parameters to the image resizing events for better logging 2020-08-24 11:00:54 -06:00
Ben Thomson c75231c60e
Fix repeated condition in thumbnail options 2020-08-24 21:34:28 +08:00
Ben Thomson 684d18ffc4
Clean up 2020-08-24 15:23:49 +08:00
Ben Thomson d104d47911
Clear relation fields when unlinking a relation 2020-08-24 15:18:33 +08:00
Ben Thomson b51428f585
Unassign previous hasOne relation when creating or linking a new record.
Prevents multiple relations existing for a hasOne relation when used in a Relation widget.
2020-08-24 15:17:38 +08:00
Ben Thomson e384a37457
Apply same fix from 5a843bc to the create action as well 2020-08-24 15:16:01 +08:00
Luke Towers d3e346013d minor inline doc correction 2020-08-23 23:58:31 -06:00
Luke Towers 5a843bc909 Fix support for updating belongsTo relationships with the RelationController.
Fixes #5198, #5243; replaces #5217. Related: 6e25c5a8d0#
2020-08-23 23:57:05 -06:00
Web-VPF f708754f07
Update Russian translation (#5247) 2020-08-23 02:51:48 -06:00
Luke Towers edae0c2476 Allow aliased non-compound use statements in the code section.
Follow up to: c1bb695f4b (diff-2040a96d3a0b43fe38675a7ee54fd8d6)
2020-08-23 01:23:06 -06:00
Luke Towers c23daf13f3 Add storage/app/resized to base structure 2020-08-23 01:11:07 -06:00
Luke Towers 4ba5126d5f Allow the resized directory through .htaccess 2020-08-21 20:46:12 -06:00
Luke Towers c1c728e413
Merge pull request #5231 from octobercms/wip/image-resizing
Implement core support for `| resize(width, height, options)` filter
2020-08-21 18:01:47 -06:00
Luke Towers 779a87999c Added support for new "image" column type that uses the ImageResizer class 2020-08-21 17:54:31 -06:00
Luke Towers 38718e0b5d Fixed bug where FileModel images wouldn't properly store their config after being retrieved from the cache 2020-08-21 17:53:28 -06:00
Luke Towers a25567c750 Use the same resizing process for FileModels that's used for everything else. 2020-08-21 16:22:14 -06:00
Luke Towers 825075a19b Fix support for Windows 2020-08-21 16:07:48 -06:00
Luke Towers 1e6573cc62 Cleaned up inline docs for ImageResizer, fixed tests 2020-08-21 14:07:23 -06:00
Luke Towers 444069da00 Finished implement imageWidth & imageHeight filters 2020-08-21 13:39:45 -06:00
Luke Towers 3864e5b1c6 Allow plugin view & configuration files to be registered on protected routes
Fixes #5245
2020-08-19 09:57:57 -06:00
Luke Towers 3f58951855 wip on imageWidth / imageHeight filter 2020-08-19 09:49:13 -06:00
Ben Thomson b795ba6a28
Add URL sources tests 2020-08-19 11:02:00 +08:00
Ben Thomson 1f5350b0b2
Test falsey width/height values 2020-08-19 10:11:42 +08:00
Luke Towers 05731b1069 Fix bug 2020-08-18 13:41:53 -06:00
Ben Thomson 5b5a15b4c6
Ensure theme cache is rest to the "test" theme for ImageResizer 2020-08-17 16:54:16 +08:00
Ben Thomson aeae1bd0f5
Remove trailing commas in commands
PHP 7.2 doesn't like them, apparently.
2020-08-17 16:45:41 +08:00
Ben Thomson 0020809634
Additional work on tests, should pass now 2020-08-17 16:41:49 +08:00
Ben Thomson 1fd9529786
Add 'auto' height and width options 2020-08-17 12:07:52 +08:00
Ben Thomson 096f5fdce5
Initial unit tests - WIP 2020-08-17 12:06:10 +08:00
Ben Thomson c25e41d51a
Remove unneeded use case 2020-08-17 10:32:52 +08:00
Luke Towers f29562023d Disable HTML5 form validation on backend Settings pages
Fixes #5239.
2020-08-15 20:59:53 -06:00
Luke Towers f346312266 Minor improvements 2020-08-15 00:55:17 -06:00
Luke Towers 7fde924ec1 Finish implementing october:util purge uploads command.
Only works for uploads stored on the local disk right now, support for remote disks may be added in the future at some point.

Replaces #4518 & #4029. Credit to @LukeTowers, @BennoThommo, & @austinderrick.
2020-08-15 00:33:08 -06:00