Commit Graph

608 Commits

Author SHA1 Message Date
Ben Thomson b5a3c64bf1
Fix "widget not bound to controller" error for nested repeaters (#4434)
Since repeaters have no value by themselves, a repeater that contains only another repeater was throwing a "widget not bound to controller" exception when adding a new item - the repeater item processing was not creating a form widget for the inner repeater on load, or in an AJAX call. This fix specifically checks if a child repeater has called for a new item, and if so and the current repeater has no value for this particular item, it will add a "stub" form widget to correctly bind the widget.

Fixes #4344.
2019-08-07 22:44:31 +08:00
Ayumi Hamasaki 5e18655ae9 Fix Rich Editor focus to fill the full height of the container (#4485)
Credit to @ayumihamsaki.
2019-07-30 09:04:38 +08:00
Luke Towers d8cd45163d Fixed the focus outline for no results on the CodeEditor search box. Credit to @ayumihamsaki. Replaces #4483. Fixes #4482. 2019-07-26 15:05:07 -06:00
Ben Thomson a7bc442df5
Pass through enableDefaults config to nested forms
This should allow default values to be used in nested form fields within new repeater items.

Fixes #4380.
2019-07-23 11:20:18 +08:00
Ben Thomson a59d3b83eb Code quality clean up (#4449)
Credit to @bennothommo
2019-07-18 08:50:37 -06:00
webmaxx cc7d595fff Added `maxFilesize` option to the `FileUpload` FormWidget (#4077)
Credit to @webmaxx
2019-07-18 08:48:31 -06:00
Anita e9665ab551 Fix layout of colorpicker for no custom color selected (#4457)
Credit to @anitaeisenhaber
2019-07-17 14:54:02 -06:00
Ayumi Hamasaki 23282bbaa6 Accessibility enhancement for code editor icons (#4395)
Credit to @ayumihamsaki. Fixes #4392
2019-07-08 10:51:25 +03:00
Ben Thomson 3eac21219f
Clean up index functionality in Repeater widget (#4424)
- Remove $indexCount property, as it is no longer needed
- Determine highest key number in data, and increment when adding item
- Remove some old code and dependencies

Fixes #4402.
2019-06-29 13:42:45 +08:00
Rike-cz acf4577255 Add preview mode for taglist widget (#4349)
Credit to @Rike-cz.
2019-06-19 08:22:36 +08:00
Marc Jauvin 30f4d4c5af Fix: Restore FroalaEditor extendability (#4356)
Credit to @mjauvin.
2019-06-03 14:15:47 +03:00
Samuel Georges 1ad43554d4 Compile rich editor with inline style and class
Fixes #3883
2019-06-01 14:43:07 +10:00
Luke Towers 7590dfd30f Respect ignoreTimezone in the datepicker 'date' mode. 2019-05-14 13:09:48 -06:00
Luke Towers bcd5156497
Merge pull request #4336 from octobercms/master
Fix group index mapping in Repeater widget (#4334)
2019-05-14 12:29:09 -06:00
datune a8d9dcf985 Fix group index mapping in Repeater widget (#4334)
Fixes a bug which causes grouped repeaters to lose data when repeater items are re-ordered and saved, due to the data indexes not being correctly mapped to the corresponding form widget.

Credit to @datune.
2019-05-14 23:34:12 +08:00
Marc Jauvin 8448d4b972 Fix media manager access (#4305) 2019-05-10 20:59:57 +03:00
Alexander Guth ee8287e598 Add "onUpload" AJAX handler to FileUpload widget (#4311)
Run an AJAX handler on uploading and processing a file as opposed to using a post() data check in the widget initialization, as the widget may initialize several times in certain circumstances - eg. inside a relation widget.

Credit to @alxy. Refs: https://github.com/octobercms/october/issues/4300
2019-05-07 11:44:25 +08:00
Samuel Georges 3e5449c855 Include CSRF token in uploads to richeditor
Fixes #4302
2019-04-30 16:27:55 +10:00
Samuel Georges 7a4052be60 Recompile assets
build-oc-plugins.js -> build-plugins.js
Refs #4075
2019-04-30 16:24:00 +10:00
Marc Jauvin edf6e135e2 Seperate proprietary and ocms js asset bundles (#4075)
* register a new bundle

* add the new bundle target asset

* remove the non-proprietary source file from the proprietary bundle definition

* create a new build target for the non-proprietary asset files

* remove the non-proprietary code from the compiled proprietary asset

* add compiled and minified build-ocms file

* add missing line at the end

* use better asset file names
2019-04-30 16:19:17 +10:00
Patrik Nemeček b345191b3f Add escaping of values to more backend fields (#4296)
Credit to @patriknemecek
2019-04-26 12:05:08 -06:00
Serge da8073c945 Fixed minor visual glitch in the Insert URL popup of Froala (#3993)
Credit to @Lavrushin.
2019-04-19 16:06:47 -06:00
Tom 04bf359d8c Fix for RichEditor root page links being returned with empty hrefs. (#3085)
Fixes issue found in https://github.com/octobercms/october/issues/3064#issuecomment-326008148, specifically 2nd bullet point. Credit to @joltmode.
2019-04-19 12:46:13 -06:00
Luke Towers ae26f4abe0 Peer review 6c54498e0a 2019-04-18 23:31:02 -06:00
Marc Jauvin ed79877054 Reuse formWidget model (#4273)
Credit to @mjauvin. Related: https://github.com/octobercms/october/pull/4193
2019-04-18 12:44:05 -06:00
Anže Časar 41a634bb2b Fix mediafinder error message (#4269)
Related: 6593651331
2019-04-17 18:54:43 -06:00
Luke Towers 4f0b237aad Use an embedded Form widget to process FileUpload properties
Fixes #2168, #3097. Related: https://github.com/rainlab/translate-plugin/pull/442
2019-04-17 18:48:32 -06:00
Luke Towers f3f655cc25
Merge pull request #4234 from octobercms/fix/repeater-cleanup
Simplify Repeater Logic. Fixes #4230. Related: https://github.com/rainlab/translate-plugin/pull/466
2019-04-17 17:15:48 -06:00
Rachasak Ragkamnerd 70cd444f8a Added support for 'cache' attribute to addJs() to disable CF RocketLoader (#4092)
Credit to @itpcc 

Due to CloudFlare Rocket Loader, CF will automatically try to optimize page loading speed by changing script type attribute. This breaks the script execution order and makes the user unable to upload the file(s) in the backend using "FileUpload" widget.

However, [CloudFlare allows adding "data-cfasync"](https://support.cloudflare.com/hc/en-us/articles/200169436-How-can-I-have-Rocket-Loader-ignore-specific-JavaScripts-) to prevent this. And it was used in the [commit #3841](https://github.com/octobercms/october/pull/3841/files).
2019-04-16 20:27:13 -06:00
SeriousKen 38070b0111 Fix ability to clear RecodFinder when useRelation = false (#4256)
Fixes #4255. Credit to @SeriousKen
2019-04-15 16:49:29 -06:00
Szabó Gergő 7189cc7fcb Improved Hungarian translation (#4250)
Backend: Added new brand settings option label and no image message.
System: Added changelog and custom error messages.
Richeditor: Many correction (https://github.com/froala/wysiwyg-editor/blob/master/js/languages/hu.js).
2019-04-11 13:39:43 +03:00
Ben Thomson ee2b53fe71 Add hidden "loaded" flag for repeaters
This allows the repeater to retrieve the load value
from the model only on initialisation. Any further
requests to the repeater (ie. AJAX requests) should
use the POST data.
2019-04-11 17:57:27 +08:00
Ben Thomson ac98f70a25 Revert reordering handler changes 2019-04-11 10:37:39 +08:00
Ben Thomson a00e546f5f Clean up processItems() method 2019-04-10 13:20:51 +08:00
Ben Thomson 9b5bd83f10 Reset indexes when processing POST data 2019-04-09 15:35:07 +08:00
Ben Thomson 744d578df7 Only run sortable handler if specified 2019-04-09 10:52:14 +08:00
Ben Thomson f49b5ab4b8 Add callback for handling sorted repeater items 2019-04-08 23:40:41 +08:00
Ben Thomson 98832fbc57 Initial work on handlers for re-ordering repeater items 2019-04-08 15:57:04 +08:00
Ben Thomson 332ed62931 Increment index count after new item is created
Effectively starts the repeater item indexes from 0
2019-04-08 14:37:36 +08:00
rejuvenatedigital aeeb791899 Fixes cursor position being lost when adding an image from the mediafinder to a richeditor (#4233)
Credit to @rejuvenatedigital
2019-04-05 09:27:48 -06:00
Luke Towers bfe03803e6 Fix the repeater on every context, not just static page fields 2019-04-05 09:00:26 -06:00
Luke Towers b4b4b1b566 Remove extra __index_ and __group_ fields from the Repeater and use only the data itself to handle initializing widgets and processing data.
Refs: #4230
2019-04-04 01:23:32 -06:00
Ben Thomson aee4205b44 Fix datatable alias to be a single string (#4231)
Credit to @bennothommo
2019-04-03 15:48:15 -06:00
Sebastiaan Kloos dadb3e2c01 Add support for preview mode for the Markdown FormWidget (#4166)
Credit to @SebastiaanKloos
2019-04-01 12:56:14 -06:00
Luke Towers 4fbe3fdd8f removed extra line of whitespace 2019-04-01 12:41:08 -06:00
Luke Towers ecccafa319 Fix issue where grouped repeaters stopped working in a recent build. Refs: 13a7cc915d (commitcomment-32986586) 2019-04-01 12:37:32 -06:00
Alexander Guth abb0b16b0f Append the color picker modal to parent element (#4199)
This fixes #4117 
Currently, the color picker modal (palette) is appended to the body (default) which makes it unusable in Octobers modals, e.g. for related model forms. This fixes this issue by appending the spectrum div to the parent element.

Credit to @alxy
2019-03-31 21:41:04 -06:00
Samuel Georges cca64db205 Fix expired message 2019-03-29 17:44:57 +11:00
Samuel Georges 5190c8177b Avoid terminating the app using exit() or die()
Refs #3783
Refs #3746
2019-03-29 07:10:07 +11:00
Samuel Georges 463008450b Bump froala_editor to v2.9.3 2019-03-29 03:49:46 +11:00