Commit Graph

5274 Commits

Author SHA1 Message Date
Luke Towers 0cdda52eb8 Fix bug where a field with `@context` in the name would completely break forms if it also depended on other fields.
The bug occurred because if specific fields aren't detected in onRefresh(), the entire Form widget HTML will be returned as the result instead of specific fields. This created a problem because the october.form.js JS is not setup to gracefully handle having the entire root form DOM node completely replaced in the middle of a request being completed. Specifically, this would cause problems when trying to detect empty tabs, and then the problems would cascade from there as there would be an instance of october.form.js attached to the page with broken references to no-longer existing DOM nodes.

This fix solves the immediate issue of `field@context` using the `dependsOn` feature breaking by ensuring that the actual final field name for a given field is used instead of the name used in the configuration of the field. Future work should probably be done to better support an entire form being re-rendered if no fields are detected in onRefresh however.
2020-06-17 03:05:40 -06:00
Tomasz Strojny 68d0667bd4
Updated Polish translation (#5129) 2020-06-17 16:10:37 +08:00
Romain 'Maz' BILLOIR 81a11f70c4
Fix Froala strip empty tags issue (#5126)
Co-authored-by: Ben Thomson <git@alfreido.com>
2020-06-16 14:59:40 +08:00
Luke Towers 24f87ae10e Also remove custom sorts from relationcontroller lists / pivot manage modes.
Fixes https://github.com/octobercms/october/issues/4335#issuecomment-643706004, refs: 5f8a5454ee
2020-06-14 14:29:21 -06:00
Ben Thomson b7d9bd1ca6
Remove Subsplit from repo 2020-06-12 11:52:28 +08:00
Ben Thomson c3800c4196
Switch to checkout-v1, v2 is doing something wrong with auth 2020-06-11 13:24:46 +08:00
Ben Thomson 5d66b74378
Fix auth for subsplit on checkout-v2 2020-06-11 13:21:47 +08:00
Ben Thomson 78a6a6e126
Finalise subsplit action 2020-06-11 13:15:43 +08:00
Ben Thomson 32b0ad3bba
Test full subsplit 2020-06-11 13:02:03 +08:00
Ben Thomson 2948ee93e4
Live test of Subsplit (System Module only) 2020-06-11 12:59:42 +08:00
Ben Thomson d7cdefbba6
Fix subsplit repo URL 2020-06-11 12:56:24 +08:00
Ben Thomson 61af4f8d9e
Debugging split 2020-06-11 12:42:46 +08:00
Ben Thomson 556637baa0
Third test of Subsplit (just the Demo theme) 2020-06-11 12:37:28 +08:00
Ben Thomson 736ac5e67d
Second test of Subsplit (just the Demo theme) 2020-06-11 12:35:55 +08:00
Ben Thomson 7e81d01117
Live test of Subsplit (just the Demo theme) 2020-06-11 12:24:12 +08:00
Ben Thomson 46e20223c7
Fix Subsplit options 2020-06-11 12:21:16 +08:00
Ben Thomson d4d80f4577
Fix command for subsplit test 2020-06-11 12:19:00 +08:00
Ben Thomson 0793ebd677
Dry-run test of subsplit through GitHub Actions 2020-06-11 12:15:13 +08:00
Ben Thomson 8dba43ba0b
Allow plugin autoloaders to load on restricted pages and actions (#5120)
Allow plugin autoloaders to load, even on restricted pages. This allows (enabled) plugins to load their autoloaders on any pages, allowing includes in migration files to run.

Fixes #5110.
2020-06-09 21:46:17 -06:00
Luke Towers 48a7cc2a89 Make it even more clear how to report a security issue. Closes #5117. 2020-06-08 10:30:00 -06:00
Luke Towers c03fd66aeb Support new onUpload() AJAX handler for uploads instead of postback takeovers.
Fixes #5104. Refs: 4f7e2995c7
2020-06-05 16:01:22 -06:00
Luke Towers d64c3850ff fix tests, not required since decompileAssets() supports even invalid assets now 2020-06-05 15:59:20 -06:00
Luke Towers 02af8bb254 Improve error handling when uploading a file that exceeds the server's post_max_size 2020-06-05 15:56:15 -06:00
Luke Towers 314b15dd13 Support decompiling mediamanager assets 2020-06-05 15:52:59 -06:00
Luke Towers 434f2cd433 Improve error handling for UploadableWidgets 2020-06-05 15:52:27 -06:00
Luke Towers 547d9bffeb Support nested asset files and files under a symlinked directory when decompiling backend assets 2020-06-05 15:51:12 -06:00
Luke Towers 33795fe6aa Delete unnecessary file 2020-06-04 09:19:24 -06:00
Alexander Guth 9e64e63805
Add filters widget to the pivot view (#5099)
Fixes #5089
2020-06-02 00:53:57 -06:00
Samuell b63a39b106
Add missing import (#5101) 2020-06-01 10:42:15 -06:00
Luke Towers 5c3ba9a28a Fix naming conflict
Reported by @alxy https://github.com/octobercms/october/pull/5088#issuecomment-636448210
2020-05-31 11:23:31 -06:00
Luke Towers 5c7ba9fbe9 Update combined jquery file to 3.4.0, added fix for #5097 2020-05-31 02:32:58 -06:00
Ben Thomson a43833d511
Trigger dependency check for remote values for inspector dropdown properties (#5071) 2020-05-27 09:36:21 +08:00
Marco Grüter b417a4938f
Render the css classes on the filter widget (#5067) 2020-05-26 15:25:06 -06:00
Nick Khaetsky ce7335f6cb
Add warning with missing dependencies on Updates page (#5077)
Fixes #4843.
2020-05-26 10:05:40 -06:00
Alwin Drenth 8196b8169e
Improved Dutch translations (#5091) 2020-05-26 09:59:11 -06:00
Dieter Holvoet 40d8bb453e
Get file and folder metadata for media items using a single network call if possible (#5046)
Co-Authored-By: Ben Thomson <ben@abweb.com.au>. Fixes #5045.
2020-05-26 03:20:41 -06:00
Luke Towers 71d579b947 Update language string 2020-05-25 18:11:05 -06:00
Luke Towers 9ecfb4867b Add new backend.allow_unsafe_markdown permission 2020-05-25 18:02:20 -06:00
Luke Towers 655c8011b9
Fix client side validation (#5088)
* Add data-request-validate to core save buttons

* Check if client side validation is desired before running it

Fixes #5076.
2020-05-25 12:53:48 -06:00
Luke Towers 0c46209725 Fix crash when a cached path doesn't actually exist in the specified datasource
Fixes an issue when using databaseTemplates where if the pathCache had been generated, and then any template was removed from the database manually the pathCache being out of date would cause an exception to be thrown elsewhere.
2020-05-22 21:01:45 -06:00
Luke Towers 64f3327e67 Merge branch 'master' into develop 2020-05-21 09:47:21 -06:00
Luke Towers eba8e6c1b8
Revert "Fix double dash typo on data-ajax-delay (#5082)" (#5083)
This reverts commit 386eb9bc5b.
2020-05-21 09:46:06 -06:00
Romain 'Maz' BILLOIR 386eb9bc5b
Fix double dash typo on data-ajax-delay (#5082) 2020-05-21 21:49:48 +08:00
Nick Khaetsky 7af73a0ade
Add "Install themes" button on updates page (#5075)
Very often in our community people asking question:"How do i install theme from marketplace?" 
And to answer that question we should say "Just press Install plugins button!"
That's not very intuitive for beginners. This PR adds one button that leads right to themes installation page.
2020-05-19 11:16:49 -06:00
Ben Thomson cf12edb861
Use IE11-compatible code for worker deregistration. (#5079)
Fixes #5078.
2020-05-19 18:59:03 +08:00
Mantas Šimkūnas a5ccfb2f99
Documented indeterminate checkboxes (#5068) 2020-05-12 11:30:03 -06:00
Marc Jauvin 15e4e53901
fix typos in halcyon (#5066) 2020-05-05 11:12:45 -06:00
Flynsarmy b896924dec
Only prepare the filter widget if there are scopes to prepare (#5064)
Fixes #5063. Collaborative effort between @LukeTowers & @Flynsarmy
2020-05-05 00:07:08 -06:00
Ben Thomson e84bdeefcd
Revert changes to exempt labels for archive check
For whatever reason - perhaps because we use spaces in our label names - the multiple exempt labels would not work when archiving issues and PRs.
2020-05-03 10:12:13 +08:00
Ben Thomson 532f595711
Add quotes around exempt labels 2020-05-02 15:04:30 +08:00