Commit Graph

2591 Commits

Author SHA1 Message Date
Tom 04bf359d8c Fix for RichEditor root page links being returned with empty hrefs. (#3085)
Fixes issue found in https://github.com/octobercms/october/issues/3064#issuecomment-326008148, specifically 2nd bullet point. Credit to @joltmode.
2019-04-19 12:46:13 -06:00
Luke Towers 57d54eb882 Improve code clarity 2019-04-19 12:39:36 -06:00
Luke Towers ae26f4abe0 Peer review 6c54498e0a 2019-04-18 23:31:02 -06:00
Ayumi Hamasaki 6c54498e0a Added Preload and Version Numbers (#4272)
Fixes #4271. Credit to @ayumihamsaki.
2019-04-18 23:09:26 -06:00
Ayumi Hamasaki da2b0f6c5b Update jQuery from V3.3.1 to V3.4.0 (#4259)
Credit to @ayumihamsaki.
2019-04-18 23:04:12 -06:00
Marc Jauvin ed79877054 Reuse formWidget model (#4273)
Credit to @mjauvin. Related: https://github.com/octobercms/october/pull/4193
2019-04-18 12:44:05 -06:00
Anže Časar 41a634bb2b Fix mediafinder error message (#4269)
Related: 6593651331
2019-04-17 18:54:43 -06:00
Luke Towers 4f0b237aad Use an embedded Form widget to process FileUpload properties
Fixes #2168, #3097. Related: https://github.com/rainlab/translate-plugin/pull/442
2019-04-17 18:48:32 -06:00
Luke Towers f3f655cc25
Merge pull request #4234 from octobercms/fix/repeater-cleanup
Simplify Repeater Logic. Fixes #4230. Related: https://github.com/rainlab/translate-plugin/pull/466
2019-04-17 17:15:48 -06:00
Rachasak Ragkamnerd 70cd444f8a Added support for 'cache' attribute to addJs() to disable CF RocketLoader (#4092)
Credit to @itpcc 

Due to CloudFlare Rocket Loader, CF will automatically try to optimize page loading speed by changing script type attribute. This breaks the script execution order and makes the user unable to upload the file(s) in the backend using "FileUpload" widget.

However, [CloudFlare allows adding "data-cfasync"](https://support.cloudflare.com/hc/en-us/articles/200169436-How-can-I-have-Rocket-Loader-ignore-specific-JavaScripts-) to prevent this. And it was used in the [commit #3841](https://github.com/octobercms/october/pull/3841/files).
2019-04-16 20:27:13 -06:00
SeriousKen 38070b0111 Fix ability to clear RecodFinder when useRelation = false (#4256)
Fixes #4255. Credit to @SeriousKen
2019-04-15 16:49:29 -06:00
Szabó Gergő 7189cc7fcb Improved Hungarian translation (#4250)
Backend: Added new brand settings option label and no image message.
System: Added changelog and custom error messages.
Richeditor: Many correction (https://github.com/froala/wysiwyg-editor/blob/master/js/languages/hu.js).
2019-04-11 13:39:43 +03:00
Ben Thomson ee2b53fe71 Add hidden "loaded" flag for repeaters
This allows the repeater to retrieve the load value
from the model only on initialisation. Any further
requests to the repeater (ie. AJAX requests) should
use the POST data.
2019-04-11 17:57:27 +08:00
Ben Thomson ac98f70a25 Revert reordering handler changes 2019-04-11 10:37:39 +08:00
Ben Thomson a00e546f5f Clean up processItems() method 2019-04-10 13:20:51 +08:00
Ben Thomson 9b5bd83f10 Reset indexes when processing POST data 2019-04-09 15:35:07 +08:00
Mohamed Ali Behiry cbd3a9e2b0 Improved Arabic Translation (#4198)
Credit to @mabehiry
2019-04-08 22:14:53 -06:00
Ben Thomson 744d578df7 Only run sortable handler if specified 2019-04-09 10:52:14 +08:00
Ben Thomson f49b5ab4b8 Add callback for handling sorted repeater items 2019-04-08 23:40:41 +08:00
Ben Thomson 98832fbc57 Initial work on handlers for re-ordering repeater items 2019-04-08 15:57:04 +08:00
Ben Thomson 332ed62931 Increment index count after new item is created
Effectively starts the repeater item indexes from 0
2019-04-08 14:37:36 +08:00
rejuvenatedigital aeeb791899 Fixes cursor position being lost when adding an image from the mediafinder to a richeditor (#4233)
Credit to @rejuvenatedigital
2019-04-05 09:27:48 -06:00
Alexander Guth 84839ba231 Do not hardcode handler name (#4235)
Credit to @alxy. This enables us to reuse the widget with a different alias name. Also, this is the octoberish way of referring to handlers. Tested on the Test plugin.
2019-04-05 09:23:50 -06:00
Marc Jauvin a2cb01b65d Add $options param to formRenderField (#4239)
Allow passing options to Form widget's renderField() method. Credit to @mjauvin
2019-04-05 09:06:52 -06:00
Luke Towers bfe03803e6 Fix the repeater on every context, not just static page fields 2019-04-05 09:00:26 -06:00
Luke Towers b4b4b1b566 Remove extra __index_ and __group_ fields from the Repeater and use only the data itself to handle initializing widgets and processing data.
Refs: #4230
2019-04-04 01:23:32 -06:00
Ben Thomson aee4205b44 Fix datatable alias to be a single string (#4231)
Credit to @bennothommo
2019-04-03 15:48:15 -06:00
Alexander Guth b3eb95bb62 Make default format options in ImportExportBehaviour configurable (#4200)
Credit to @alxy.

If the default format mode is selected, there is no chance to configure the format options for delimiter, enclosure, escape and encoding. This considers a new config file item `defaultFormatOptions` and falls back to `null` if it is not specified.

To keep things consistent, the old default values remain untouched.
2019-04-01 13:00:41 -06:00
Sebastiaan Kloos dadb3e2c01 Add support for preview mode for the Markdown FormWidget (#4166)
Credit to @SebastiaanKloos
2019-04-01 12:56:14 -06:00
Luke Towers 4fbe3fdd8f removed extra line of whitespace 2019-04-01 12:41:08 -06:00
Luke Towers ecccafa319 Fix issue where grouped repeaters stopped working in a recent build. Refs: 13a7cc915d (commitcomment-32986586) 2019-04-01 12:37:32 -06:00
Alexander Guth abb0b16b0f Append the color picker modal to parent element (#4199)
This fixes #4117 
Currently, the color picker modal (palette) is appended to the body (default) which makes it unusable in Octobers modals, e.g. for related model forms. This fixes this issue by appending the spectrum div to the parent element.

Credit to @alxy
2019-03-31 21:41:04 -06:00
Samuel Georges cca64db205 Fix expired message 2019-03-29 17:44:57 +11:00
Samuel Georges 5190c8177b Avoid terminating the app using exit() or die()
Refs #3783
Refs #3746
2019-03-29 07:10:07 +11:00
Samuel Georges c5bc804d73 Remove redundant header_remove() call
The response is returned directly to the route so this is not needed, it was likely added as an artefact of a previous implementation

Refs #3773
Refs #3746
2019-03-29 06:02:06 +11:00
Samuel Georges 288d9543af Firefox testing
- 4K display fixes
- use doc.ready over win.load
- min-size can be 0.1px and still fix the table spacing issue
2019-03-29 04:33:18 +11:00
Samuel Georges 463008450b Bump froala_editor to v2.9.3 2019-03-29 03:49:46 +11:00
Samuel Georges 6593651331 Add file check for image upload form widgets - Fixes #3653 2019-03-29 02:23:20 +11:00
Samuel Georges 2b1323b7b2 Change default widget column sizes
Refs #3965
2019-03-29 01:08:20 +11:00
Samuel Georges 334ad94ca4
Merge pull request #3965 from ayumihamsaki2/master
Update Dashboard Columns from 10 to 12
2019-03-29 01:04:16 +11:00
Ben Thomson 8c1106f027 Allow list configs to add class to head row cell (#4207)
Credit to @bennothommo. Documented by https://github.com/octobercms/docs/pull/367
2019-03-25 13:37:32 -06:00
Ben Thomson 3363b219f6 Delay backend controller middleware until after request is processed (#4190)
Credit to @bennothommo. Fixes #4183.
2019-03-21 01:19:28 -06:00
Tomy Smith 40bc6e0d67 Ignore disabled FormWidgets in getSaveData() (#4116)
Fixes #3983. Credit to @tmus.
2019-03-19 16:45:32 -06:00
Larry Barker 5c15687032 Support CMS module being present but disabled (#4202)
Credit to @LarBearrr
2019-03-19 16:31:14 -06:00
Luke Towers 3954704dda Fix issue with multiple repeaters with the same fieldname embedded in the same controller
There was a conflict between two repeaters that had the same fieldName (data) bound to the same controller. Example:

Controller: Events
Manages a ReportTemplate model with a custom popup Form widget that uses a grouped repeater with the field name data to define the available "fields" within a ReportTemplate
Also manages Report models through a relation controller that uses a Form widget with a regular repeater with the field name data that defines the values of the fields defined by the associated ReportTemplate.

Since both repeaters had the field name of "data", but one of them was grouped and the other wasn't, this would cause an issue in Repeater::processExistingItems() where the grouped repeater would attempt to process the ungrouped repeater's data which would then fail. This issue could easily cause many other vastly more confusing and difficult to detect issues in cases where multiple repeaters with the same field name AND the same mode (grouped vs regular) existed on the same page under different contexts. The simple solution is just to ensure that the indexInputName and groupInputName are both taking the repeater's alias into account when being generated to ensure that everything stays unique like it should.
2019-03-18 12:39:12 -06:00
Luke Towers f168c1a601 Fix support for main menu items having a numeric value for `counter` 2019-03-16 13:53:25 -06:00
Ben Thomson 13a7cc915d Use Form getSaveData method when saving form widgets within repeaters (#4160)
Credit to @bennothommo
2019-03-15 22:39:34 -06:00
Alexander Guth 13d710b161 Reuse the model instance from Form widget (#4193)
Credit to @alxy & @jimcottrell . Refs:
https://github.com/rainlab/translate-plugin/issues/209
https://github.com/rainlab/translate-plugin/issues/242
https://github.com/rainlab/translate-plugin/issues/330
https://github.com/rainlab/translate-plugin/issues/380
https://github.com/jan-vince/smallextensions/issues/11
https://github.com/OFFLINE-GmbH/oc-mall-plugin/issues/128
https://github.com/OFFLINE-GmbH/oc-gdpr-plugin/issues/21
https://github.com/OFFLINE-GmbH/oc-gdpr-plugin/pull/55
df9c8fd365
https://github.com/octobercms/october/pull/3984
2019-03-15 22:32:36 -06:00
Luke Towers d5e7419312 Support enableDefaults on repeaters using grouped mode 2019-03-12 01:19:37 -06:00
Sicklou 12ebefccd4 Update French Translation (#4179)
Credit to @Sicklou
2019-03-09 07:28:23 -06:00