From e15fe96499118466d76b44f5facc562f607887da Mon Sep 17 00:00:00 2001
From: jitendra <jitendra@webkul.com>
Date: Tue, 9 Aug 2022 11:33:11 +0530
Subject: [PATCH] Refactored haveSufficientQuantity function in product type
 class

---
 packages/Webkul/Product/src/Type/Configurable.php | 6 ++----
 packages/Webkul/Product/src/Type/Simple.php       | 6 +-----
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/packages/Webkul/Product/src/Type/Configurable.php b/packages/Webkul/Product/src/Type/Configurable.php
index e5fe6484d..70f0aa1dc 100644
--- a/packages/Webkul/Product/src/Type/Configurable.php
+++ b/packages/Webkul/Product/src/Type/Configurable.php
@@ -854,9 +854,7 @@ class Configurable extends AbstractType
      */
     public function haveSufficientQuantity(int $qty): bool
     {
-        $backorders = core()->getConfigData('catalog.inventory.stock_options.backorders');
-
-        $backorders = ! is_null($backorders) ? $backorders : false;
+        $isBackOrderEnable = (bool) core()->getConfigData('catalog.inventory.stock_options.backorders');
 
         foreach ($this->product->variants as $variant) {
             if ($variant->haveSufficientQuantity($qty)) {
@@ -864,7 +862,7 @@ class Configurable extends AbstractType
             }
         }
 
-        return $backorders;
+        return $isBackOrderEnable;
     }
 
     /**
diff --git a/packages/Webkul/Product/src/Type/Simple.php b/packages/Webkul/Product/src/Type/Simple.php
index e1722cf9b..91a5f0749 100644
--- a/packages/Webkul/Product/src/Type/Simple.php
+++ b/packages/Webkul/Product/src/Type/Simple.php
@@ -61,11 +61,7 @@ class Simple extends AbstractType
      */
     public function haveSufficientQuantity(int $qty): bool
     {
-        $backOrders = core()->getConfigData('catalog.inventory.stock_options.backorders');
-
-        $backOrders = ! is_null($backOrders) ? $backOrders : false;
-
-        return $qty <= $this->totalQuantity() ? true : $backOrders;
+        return $qty <= $this->totalQuantity() ?: (bool) core()->getConfigData('catalog.inventory.stock_options.backorders');
     }
 
     /**