merdan
/
sarga
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Issue #2671 fixed

This commit is contained in:
Jitendra Singh 2020-03-17 13:01:37 +05:30
parent bf5ad13dac
commit cdc1eb7bc1
4 changed files with 29 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/Webkul/BookingProduct/src/Type/Booking.php
View File

@ -209,7 +209,13 @@ class Booking extends Virtual
return false;
}
return $options1['booking'] == $options2['booking'];
if (isset($options1['booking']) && isset($options2['booking'])) {
return $options1['booking'] === $options2['booking'];
} elseif (! isset($options1['booking'])) {
return false;
} elseif (! isset($options2['booking'])) {
return false;
}
}
/**

10
packages/Webkul/Product/src/Type/Bundle.php
View File

@ -496,8 +496,14 @@ class Bundle extends AbstractType
return false;
}
return $options1['bundle_options'] == $options2['bundle_options']
&& $options1['bundle_option_qty'] == $this->getOptionQuantities($options2);
if (isset($options1['bundle_options']) && isset($options2['bundle_options'])) {
return $options1['bundle_options'] == $options2['bundle_options']
&& $options1['bundle_option_qty'] == $this->getOptionQuantities($options2);
} elseif (! isset($options1['bundle_options'])) {
return false;
} elseif (! isset($options2['bundle_options'])) {
return false;
}
}
/**

8
packages/Webkul/Product/src/Type/Configurable.php
View File

@ -460,7 +460,13 @@ class Configurable extends AbstractType
return false;
}
return $options1['selected_configurable_option'] === $options2['selected_configurable_option'];
if (isset($options1['selected_configurable_option']) && isset($options2['selected_configurable_option'])) {
return $options1['selected_configurable_option'] === $options2['selected_configurable_option'];
} elseif (! isset($options1['selected_configurable_option'])) {
return false;
} elseif (! isset($options2['selected_configurable_option'])) {
return false;
}
}
/**

8
packages/Webkul/Product/src/Type/Downloadable.php
View File

@ -188,7 +188,13 @@ class Downloadable extends AbstractType
return false;
}
return $options1['links'] == $options2['links'];
if (isset($options1['links']) && isset($options2['links'])) {
return $options1['links'] === $options2['links'];
} elseif (! isset($options1['links'])) {
return false;
} elseif (! isset($options2['links'])) {
return false;
}
}
/**