From f28f716d9f54166999e90fff947018be2f8251b1 Mon Sep 17 00:00:00 2001 From: prashant-webkul Date: Thu, 11 Oct 2018 19:55:59 +0530 Subject: [PATCH 1/5] Bug fixes across the system --- composer.json | 7 +- config/app.php | 2 +- packages/Webkul/Admin/src/Http/routes.php | 20 +- .../Admin/src/Resources/lang/en/app.php | 3 +- .../tax/taxrate/create/taxrate.blade.php | 21 +- .../views/tax/taxrule/create/create.blade.php | 9 +- .../Http/Controllers/WishlistController.php | 2 +- .../Shop/src/Resources/assets/js/app.js | 1 - .../assets/js/components/cart-dropdown.vue | 92 ------ .../assets/js/components/category-item.vue | 3 +- .../Shop/src/Resources/assets/sass/app.scss | 36 +-- .../views/layouts/header/index.blade.php | 29 +- .../views/products/reviews/index.blade.php | 10 +- packages/Webkul/Tax/.gitignore | 0 packages/Webkul/Tax/composer.json | 26 ++ .../Webkul/Tax/src/Models/TaxCategory.php | 27 ++ packages/Webkul/Tax/src/Models/TaxMap.php | 23 ++ packages/Webkul/Tax/src/Models/TaxRate.php | 25 ++ ..._30_064755_create_tax_categories_table.php | 0 ...18_08_30_065042_create_tax_rates_table.php | 4 +- ...08_30_065840_create_tax_mappings_table.php | 0 .../Tax/src/http/controllers/Controller.php | 13 + .../controllers}/TaxCategoryController.php | 14 +- .../src/http/controllers}/TaxController.php | 14 +- .../http/controllers}/TaxRateController.php | 20 +- .../Tax/src/providers/TaxServiceProvider.php | 51 ++++ .../repositories}/TaxCategoriesRepository.php | 4 +- .../src/repositories}/TaxMapRepository.php | 4 +- .../src/repositories}/TaxRatesRepository.php | 4 +- .../views/datagrid/table/default.blade.php | 7 + public/themes/default/assets/css/shop.css | 37 +-- public/themes/default/assets/js/shop.js | 269 ++---------------- 32 files changed, 275 insertions(+), 502 deletions(-) delete mode 100644 packages/Webkul/Shop/src/Resources/assets/js/components/cart-dropdown.vue create mode 100644 packages/Webkul/Tax/.gitignore create mode 100644 packages/Webkul/Tax/composer.json create mode 100644 packages/Webkul/Tax/src/Models/TaxCategory.php create mode 100644 packages/Webkul/Tax/src/Models/TaxMap.php create mode 100644 packages/Webkul/Tax/src/Models/TaxRate.php rename packages/Webkul/{Core/src/Database/Migrations => Tax/src/database/migrations}/2018_08_30_064755_create_tax_categories_table.php (100%) rename packages/Webkul/{Core/src/Database/Migrations => Tax/src/database/migrations}/2018_08_30_065042_create_tax_rates_table.php (89%) rename packages/Webkul/{Core/src/Database/Migrations => Tax/src/database/migrations}/2018_08_30_065840_create_tax_mappings_table.php (100%) create mode 100644 packages/Webkul/Tax/src/http/controllers/Controller.php rename packages/Webkul/{Core/src/Http/Controllers => Tax/src/http/controllers}/TaxCategoryController.php (91%) rename packages/Webkul/{Core/src/Http/Controllers => Tax/src/http/controllers}/TaxController.php (77%) rename packages/Webkul/{Core/src/Http/Controllers => Tax/src/http/controllers}/TaxRateController.php (87%) create mode 100644 packages/Webkul/Tax/src/providers/TaxServiceProvider.php rename packages/Webkul/{Core/src/Repositories => Tax/src/repositories}/TaxCategoriesRepository.php (94%) rename packages/Webkul/{Core/src/Repositories => Tax/src/repositories}/TaxMapRepository.php (91%) rename packages/Webkul/{Core/src/Repositories => Tax/src/repositories}/TaxRatesRepository.php (91%) diff --git a/composer.json b/composer.json index 3db3c622d..75737c25f 100644 --- a/composer.json +++ b/composer.json @@ -44,13 +44,15 @@ "webkul/laravel-theme": "self.version", "webkul/laravel-shipping": "self.version", "webkul/laravel-payment": "self.version", - "webkul/laravel-sales": "self.version" + "webkul/laravel-sales": "self.version", + "webkul/laravel-tax": "self.version" }, "autoload": { "classmap": [ "database/seeds", "database/factories" ], + "psr-4": { "App\\": "app/", "Webkul\\User\\": "packages/Webkul/User/src", @@ -67,7 +69,8 @@ "Webkul\\Theme\\": "packages/Webkul/Theme/src", "Webkul\\Shipping\\": "packages/Webkul/Shipping/src", "Webkul\\Payment\\": "packages/Webkul/Payment/src", - "Webkul\\Sales\\": "packages/Webkul/Sales/src" + "Webkul\\Sales\\": "packages/Webkul/Sales/src", + "Webkul\\Tax\\": "packages/Webkul/Tax/src" } }, "autoload-dev": { diff --git a/config/app.php b/config/app.php index 328d1a18f..641348c19 100644 --- a/config/app.php +++ b/config/app.php @@ -193,6 +193,7 @@ return [ Webkul\Shipping\Providers\ShippingServiceProvider::class, Webkul\Payment\Providers\PaymentServiceProvider::class, Webkul\Sales\Providers\SalesServiceProvider::class, + Webkul\Tax\Providers\TaxServiceProvider::class, ], /* @@ -247,5 +248,4 @@ return [ 'Cart' => Webkul\Checkout\Facades\Cart::class, 'Core' => Webkul\Core\Facades\Core::class ], - ]; diff --git a/packages/Webkul/Admin/src/Http/routes.php b/packages/Webkul/Admin/src/Http/routes.php index c7c62a1af..459c3e537 100644 --- a/packages/Webkul/Admin/src/Http/routes.php +++ b/packages/Webkul/Admin/src/Http/routes.php @@ -403,24 +403,24 @@ Route::group(['middleware' => ['web']], function () { //tax routes Route::prefix('tax')->group(function () { - Route::get('taxrule', 'Webkul\Core\Http\Controllers\TaxController@index')->defaults('_config', [ + Route::get('taxrule', 'Webkul\Tax\Http\Controllers\TaxController@index')->defaults('_config', [ 'view' => 'admin::tax.taxrule.index' ])->name('admin.taxrule.index'); // tax rule routes - Route::get('taxrule/create', 'Webkul\Core\Http\Controllers\TaxCategoryController@show')->defaults('_config', [ + Route::get('taxrule/create', 'Webkul\Tax\Http\Controllers\TaxCategoryController@show')->defaults('_config', [ 'view' => 'admin::tax.taxrule.create.create' ])->name('admin.taxrule.show'); - Route::post('taxrule/create', 'Webkul\Core\Http\Controllers\TaxCategoryController@create')->defaults('_config', [ + Route::post('taxrule/create', 'Webkul\Tax\Http\Controllers\TaxCategoryController@create')->defaults('_config', [ 'redirect' => 'admin.taxrule.index' ])->name('admin.taxrule.create'); - Route::get('/taxrule/edit/{id}', 'Webkul\Core\Http\Controllers\TaxCategoryController@edit')->defaults('_config', [ + Route::get('/taxrule/edit/{id}', 'Webkul\Tax\Http\Controllers\TaxCategoryController@edit')->defaults('_config', [ 'view' => 'admin::tax.taxrule.edit.edit' ])->name('admin.taxrule.edit'); - Route::put('/taxrule/edit/{id}', 'Webkul\Core\Http\Controllers\TaxCategoryController@update')->defaults('_config', [ + Route::put('/taxrule/edit/{id}', 'Webkul\Tax\Http\Controllers\TaxCategoryController@update')->defaults('_config', [ 'redirect' => 'admin.taxrule.index' ])->name('admin.taxrule.update'); @@ -428,23 +428,23 @@ Route::group(['middleware' => ['web']], function () { //tax rate - Route::get('taxrate', 'Webkul\Core\Http\Controllers\TaxRateController@index')->defaults('_config', [ + Route::get('taxrate', 'Webkul\Tax\Http\Controllers\TaxRateController@index')->defaults('_config', [ 'view' => 'admin::tax.taxrate.index' ])->name('admin.taxrate.index'); - Route::get('taxrate/create', 'Webkul\Core\Http\Controllers\TaxRateController@show')->defaults('_config', [ + Route::get('taxrate/create', 'Webkul\Tax\Http\Controllers\TaxRateController@show')->defaults('_config', [ 'view' => 'admin::tax.taxrate.create.taxrate' ])->name('admin.taxrate.show'); - Route::post('taxrate/create', 'Webkul\Core\Http\Controllers\TaxRateController@create')->defaults('_config', [ + Route::post('taxrate/create', 'Webkul\Tax\Http\Controllers\TaxRateController@create')->defaults('_config', [ 'redirect' => 'admin.taxrate.index' ])->name('admin.taxrate.create'); - Route::get('taxrate/edit/{id}', 'Webkul\Core\Http\Controllers\TaxRateController@edit')->defaults('_config', [ + Route::get('taxrate/edit/{id}', 'Webkul\Tax\Http\Controllers\TaxRateController@edit')->defaults('_config', [ 'view' => 'admin::tax.taxrate.edit.edit' ])->name('admin.taxrate.store'); - Route::put('taxrate/update/{id}', 'Webkul\Core\Http\Controllers\TaxRateController@update')->defaults('_config', [ + Route::put('taxrate/update/{id}', 'Webkul\Tax\Http\Controllers\TaxRateController@update')->defaults('_config', [ 'redirect' => 'admin.taxrate.index' ])->name('admin.taxrate.update'); }); diff --git a/packages/Webkul/Admin/src/Resources/lang/en/app.php b/packages/Webkul/Admin/src/Resources/lang/en/app.php index e440db4bb..93043405f 100644 --- a/packages/Webkul/Admin/src/Resources/lang/en/app.php +++ b/packages/Webkul/Admin/src/Resources/lang/en/app.php @@ -289,7 +289,8 @@ return [ 'title' => 'Edit Tax Rate', 'edit-button-title' => 'Edit Rate' ], - 'zip_code' => 'Zip Code' + 'zip_code' => 'Zip Code', + 'is_zip' => 'Enable Zip Range' ], ], diff --git a/packages/Webkul/Admin/src/Resources/views/tax/taxrate/create/taxrate.blade.php b/packages/Webkul/Admin/src/Resources/views/tax/taxrate/create/taxrate.blade.php index 5feb8615c..95e98a59c 100644 --- a/packages/Webkul/Admin/src/Resources/views/tax/taxrate/create/taxrate.blade.php +++ b/packages/Webkul/Admin/src/Resources/views/tax/taxrate/create/taxrate.blade.php @@ -23,9 +23,6 @@
@csrf() - -
-
@@ -53,7 +50,7 @@
- + Enable Zip Range @@ -61,7 +58,7 @@
- + @@ -69,17 +66,17 @@
- + - + @{{ errors.first('zip_from') }}
- + - + @{{ errors.first('zip_to') }}
@@ -92,8 +89,6 @@ @{{ errors.first('tax_rate') }}
-
-
@@ -110,6 +105,8 @@ function myFunction() { value = document.getElementById('is_zip').checked; + // console.log(value); + if(value) { document.getElementById("zip_from").style.display = ""; @@ -123,8 +120,6 @@ document.getElementById("zip_code").style.display = ""; } - - console.log("Value = ", value); } @endpush diff --git a/packages/Webkul/Admin/src/Resources/views/tax/taxrule/create/create.blade.php b/packages/Webkul/Admin/src/Resources/views/tax/taxrule/create/create.blade.php index 5b44da360..d82924833 100644 --- a/packages/Webkul/Admin/src/Resources/views/tax/taxrule/create/create.blade.php +++ b/packages/Webkul/Admin/src/Resources/views/tax/taxrule/create/create.blade.php @@ -21,10 +21,6 @@
@csrf() - - -
-
@@ -74,10 +70,9 @@ @endforeach - @{{ errors.first('taxrates') }} + @{{ errors.first('taxrates') }}
-
-
+
diff --git a/packages/Webkul/Customer/src/Http/Controllers/WishlistController.php b/packages/Webkul/Customer/src/Http/Controllers/WishlistController.php index 262ee3e9e..5b3e1a7af 100644 --- a/packages/Webkul/Customer/src/Http/Controllers/WishlistController.php +++ b/packages/Webkul/Customer/src/Http/Controllers/WishlistController.php @@ -17,9 +17,9 @@ use Auth; * @author Prashant Singh * @copyright 2018 Webkul Software Pvt Ltd (http://www.webkul.com) */ + class WishlistController extends Controller { - protected $_config; protected $customer; diff --git a/packages/Webkul/Shop/src/Resources/assets/js/app.js b/packages/Webkul/Shop/src/Resources/assets/js/app.js index d4abea11f..75b9dd169 100644 --- a/packages/Webkul/Shop/src/Resources/assets/js/app.js +++ b/packages/Webkul/Shop/src/Resources/assets/js/app.js @@ -10,7 +10,6 @@ Vue.component("category-nav", require("./components/category-nav.vue")); Vue.component("category-item", require("./components/category-item.vue")); Vue.component("image-slider", require("./components/image-slider.vue")); Vue.component("vue-slider", require("vue-slider-component")); -Vue.component("cart-dropdown", require("./components/cart-dropdown.vue")); $(document).ready(function () { diff --git a/packages/Webkul/Shop/src/Resources/assets/js/components/cart-dropdown.vue b/packages/Webkul/Shop/src/Resources/assets/js/components/cart-dropdown.vue deleted file mode 100644 index 722dbb6fd..000000000 --- a/packages/Webkul/Shop/src/Resources/assets/js/components/cart-dropdown.vue +++ /dev/null @@ -1,92 +0,0 @@ - - \ No newline at end of file diff --git a/packages/Webkul/Shop/src/Resources/assets/js/components/category-item.vue b/packages/Webkul/Shop/src/Resources/assets/js/components/category-item.vue index 52961aa19..5bfd4b903 100644 --- a/packages/Webkul/Shop/src/Resources/assets/js/components/category-item.vue +++ b/packages/Webkul/Shop/src/Resources/assets/js/components/category-item.vue @@ -1,6 +1,6 @@