From b4872b5c212db381e76f432728b2613fd6f32e55 Mon Sep 17 00:00:00 2001 From: Prashant Singh Date: Tue, 10 Sep 2019 14:42:59 +0530 Subject: [PATCH] Missed a ! symbol in conditions object's attribute validation --- packages/Webkul/Discount/src/Helpers/Cart/Discount.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/Webkul/Discount/src/Helpers/Cart/Discount.php b/packages/Webkul/Discount/src/Helpers/Cart/Discount.php index 52c1c5c96..1a56492ff 100644 --- a/packages/Webkul/Discount/src/Helpers/Cart/Discount.php +++ b/packages/Webkul/Discount/src/Helpers/Cart/Discount.php @@ -781,7 +781,7 @@ abstract class Discount foreach ($conditions as $condition) { $result = true; - if (! isset($condition->attribute) || ! isset($condition->condition) || ! isset($condition->value) || ! isset($condition->type) || $condition->value != []) { + if (! isset($condition->attribute) || ! isset($condition->condition) || ! isset($condition->value) || ! isset($condition->type) || ! $condition->value != []) { $result = false; continue; @@ -911,7 +911,7 @@ abstract class Discount } foreach ($conditions as $condition) { - if (!isset($condition->attribute) || ! isset($condition->condition) || !isset($condition->value)) { + if (! isset($condition->attribute) || ! isset($condition->condition) || ! isset($condition->value)) { continue; }