From 91a4fabcfb5b6814251499e7786cd1cb6ae73eae Mon Sep 17 00:00:00 2001 From: prashant-webkul Date: Tue, 16 Oct 2018 17:18:45 +0530 Subject: [PATCH] Grid Sort Fixes --- .../Admin/src/DataGrids/CustomerDataGrid.php | 20 +- packages/Webkul/Shop/src/Http/routes.php | 3 +- .../Shop/src/Resources/views/error.blade.php | 19 ++ packages/Webkul/Ui/src/DataGrid/DataGrid.php | 2 +- .../Ui/src/Providers/UiServiceProvider.php | 2 + .../Resources/assets/images/Icon-Sort-Up.svg | 23 ++ .../Resources/assets/images/sort-up-icon.png | Bin 0 -> 106 bytes .../Ui/src/Resources/assets/sass/app.scss | 258 +----------------- .../src/Resources/assets/sass/components.scss | 258 ++++++++++++++++++ .../Ui/src/Resources/assets/sass/icons.scss | 10 + .../Webkul/Ui/src/Resources/lang/en/app.php | 6 + .../default.blade.php => filters.blade.php} | 1 - .../Resources/views/datagrid/index.blade.php | 173 ++---------- .../datagrid/{ => notused}/column.blade.php | 0 .../views/datagrid/pagination.blade.php | 3 + .../Resources/views/datagrid/table.blade.php | 7 + .../views/datagrid/table/body.blade.php | 32 +++ .../views/datagrid/table/default.blade.php | 162 ----------- .../views/datagrid/table/head.blade.php | 105 +++++++ 19 files changed, 501 insertions(+), 583 deletions(-) create mode 100644 packages/Webkul/Shop/src/Resources/views/error.blade.php create mode 100644 packages/Webkul/Ui/src/Resources/assets/images/Icon-Sort-Up.svg create mode 100644 packages/Webkul/Ui/src/Resources/assets/images/sort-up-icon.png create mode 100644 packages/Webkul/Ui/src/Resources/assets/sass/components.scss create mode 100644 packages/Webkul/Ui/src/Resources/lang/en/app.php rename packages/Webkul/Ui/src/Resources/views/datagrid/{filters/default.blade.php => filters.blade.php} (99%) rename packages/Webkul/Ui/src/Resources/views/datagrid/{ => notused}/column.blade.php (100%) create mode 100644 packages/Webkul/Ui/src/Resources/views/datagrid/pagination.blade.php create mode 100644 packages/Webkul/Ui/src/Resources/views/datagrid/table.blade.php create mode 100644 packages/Webkul/Ui/src/Resources/views/datagrid/table/body.blade.php delete mode 100644 packages/Webkul/Ui/src/Resources/views/datagrid/table/default.blade.php create mode 100644 packages/Webkul/Ui/src/Resources/views/datagrid/table/head.blade.php diff --git a/packages/Webkul/Admin/src/DataGrids/CustomerDataGrid.php b/packages/Webkul/Admin/src/DataGrids/CustomerDataGrid.php index 592b0f5b4..6703c3544 100644 --- a/packages/Webkul/Admin/src/DataGrids/CustomerDataGrid.php +++ b/packages/Webkul/Admin/src/DataGrids/CustomerDataGrid.php @@ -37,7 +37,7 @@ class CustomerDataGrid 'route' => route('admin.datagrid.delete'), 'method' => 'DELETE', 'label' => 'Delete', - 'type' => 'button', + 'type' => 'button', //select || button only ], ], @@ -55,20 +55,10 @@ class CustomerDataGrid ], ], - 'join' => [ - // [ - // 'join' => 'leftjoin', - // 'table' => 'roles as r', - // 'primaryKey' => 'u.role_id', - // 'condition' => '=', - // 'secondaryKey' => 'r.id', - // ] - ], + 'join' => [], //use aliasing on secodary columns if join is performed - 'columns' => [ - [ 'name' => 'id', 'alias' => 'customerId', @@ -81,14 +71,14 @@ class CustomerDataGrid 'alias' => 'customerFirstName', 'type' => 'string', 'label' => 'Name', - 'sortable' => true, + 'sortable' => false, ], [ 'name' => 'email', 'alias' => 'customerEmail', 'type' => 'string', 'label' => 'Email', - 'sortable' => true, + 'sortable' => false, ], [ 'name' => 'phone', @@ -102,7 +92,7 @@ class CustomerDataGrid 'alias' => 'customerGroupId', 'type' => 'number', 'label' => 'Customer Group', - 'sortable' => true, + 'sortable' => false, ], ], diff --git a/packages/Webkul/Shop/src/Http/routes.php b/packages/Webkul/Shop/src/Http/routes.php index ffdd15983..5445c09db 100644 --- a/packages/Webkul/Shop/src/Http/routes.php +++ b/packages/Webkul/Shop/src/Http/routes.php @@ -1,6 +1,7 @@ ['web']], function () { + Route::get('/', 'Webkul\Shop\Http\Controllers\HomeController@index')->defaults('_config', [ 'view' => 'shop::home.index' ])->name('shop.home.index'); @@ -167,7 +168,6 @@ Route::group(['middleware' => ['web']], function () { Route::post('address/edit', 'Webkul\Customer\Http\Controllers\AddressController@edit')->defaults('_config', [ 'redirect' => 'customer.address.index' ])->name('customer.address.edit'); - /* Routes for Addresses ends here */ /* Wishlist route */ @@ -188,5 +188,4 @@ Route::group(['middleware' => ['web']], function () { }); }); //customer routes end here - }); diff --git a/packages/Webkul/Shop/src/Resources/views/error.blade.php b/packages/Webkul/Shop/src/Resources/views/error.blade.php new file mode 100644 index 000000000..d78938fdb --- /dev/null +++ b/packages/Webkul/Shop/src/Resources/views/error.blade.php @@ -0,0 +1,19 @@ +@extends('shop::layouts.master') +@section('content-wrapper') +
+
+
+
404
+
Page Not Found
+
+ GO TO HOME + {{-- pass the content dynamically --}} + Show the exception here or error message here. +
+ +
+
+
+
+@endsection \ No newline at end of file diff --git a/packages/Webkul/Ui/src/DataGrid/DataGrid.php b/packages/Webkul/Ui/src/DataGrid/DataGrid.php index bd212bdf2..c61c7c5aa 100644 --- a/packages/Webkul/Ui/src/DataGrid/DataGrid.php +++ b/packages/Webkul/Ui/src/DataGrid/DataGrid.php @@ -596,7 +596,7 @@ class DataGrid array_values($value)[0] ); } else { - throw new \Exception('Multiple Sort keys Found, Please Resolve the URL Manually.'); + throw new \Exception('Multiple Sort keys Found, Please Resolve the URL Manually'); } } elseif ($key=="search") { diff --git a/packages/Webkul/Ui/src/Providers/UiServiceProvider.php b/packages/Webkul/Ui/src/Providers/UiServiceProvider.php index 6229e49c5..5f6c0256a 100644 --- a/packages/Webkul/Ui/src/Providers/UiServiceProvider.php +++ b/packages/Webkul/Ui/src/Providers/UiServiceProvider.php @@ -20,6 +20,8 @@ class UiServiceProvider extends ServiceProvider __DIR__ . '/../../publishable/assets' => public_path('vendor/webkul/ui/assets'), ], 'public'); + $this->loadTranslationsFrom(__DIR__ . '/../Resources/lang', 'ui'); + $this->loadViewsFrom(__DIR__ . '/../Resources/views', 'ui'); Paginator::defaultView('ui::partials.pagination'); diff --git a/packages/Webkul/Ui/src/Resources/assets/images/Icon-Sort-Up.svg b/packages/Webkul/Ui/src/Resources/assets/images/Icon-Sort-Up.svg new file mode 100644 index 000000000..1c9462c2b --- /dev/null +++ b/packages/Webkul/Ui/src/Resources/assets/images/Icon-Sort-Up.svg @@ -0,0 +1,23 @@ + + + + Icon-Sort-Down + Created with Sketch. + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/packages/Webkul/Ui/src/Resources/assets/images/sort-up-icon.png b/packages/Webkul/Ui/src/Resources/assets/images/sort-up-icon.png new file mode 100644 index 0000000000000000000000000000000000000000..2578e18db0abc03e96405daef64f19e5d29f42ad GIT binary patch literal 106 zcmeAS@N?(olHy`uVBq!ia0vp^3LwnL3?x0byx0z;*aCb)T!AzYEKT2e9!N2j1o;Is y1bzPY_W_V6=;`7Z!f`!$flz{7gI@qU1H-3h%)A#rtP%%GGI+ZBxvX [ + 'actions' => 'Actions' + ] +]; \ No newline at end of file diff --git a/packages/Webkul/Ui/src/Resources/views/datagrid/filters/default.blade.php b/packages/Webkul/Ui/src/Resources/views/datagrid/filters.blade.php similarity index 99% rename from packages/Webkul/Ui/src/Resources/views/datagrid/filters/default.blade.php rename to packages/Webkul/Ui/src/Resources/views/datagrid/filters.blade.php index 868c5906e..f555a009c 100644 --- a/packages/Webkul/Ui/src/Resources/views/datagrid/filters/default.blade.php +++ b/packages/Webkul/Ui/src/Resources/views/datagrid/filters.blade.php @@ -1,5 +1,4 @@
- {{-- for loading the filters from another file --}}
diff --git a/packages/Webkul/Ui/src/Resources/views/datagrid/index.blade.php b/packages/Webkul/Ui/src/Resources/views/datagrid/index.blade.php index 3675dbc66..34cf664f3 100644 --- a/packages/Webkul/Ui/src/Resources/views/datagrid/index.blade.php +++ b/packages/Webkul/Ui/src/Resources/views/datagrid/index.blade.php @@ -1,73 +1,53 @@ -
- +
{{-- For loading the filters from includes directory file --}} - @include('ui::datagrid.filters.default') + @include('ui::datagrid.filters') {{-- for generating the table and its content --}} - @include('ui::datagrid.table.default') + @include('ui::datagrid.table') {{-- Section for datagrid javascript --}} @push('scripts')