From cf837ba2906008bce7d9482c9c1acd2110ec7690 Mon Sep 17 00:00:00 2001 From: "shubhammehrotra.symfony@webkul.com" Date: Thu, 19 Dec 2019 15:53:01 +0530 Subject: [PATCH 1/2] throw exception when session user is not available on product review page --- .../src/Http/Controllers/ReviewController.php | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/packages/Webkul/Shop/src/Http/Controllers/ReviewController.php b/packages/Webkul/Shop/src/Http/Controllers/ReviewController.php index b27b2a1b9..d3b77b9a0 100755 --- a/packages/Webkul/Shop/src/Http/Controllers/ReviewController.php +++ b/packages/Webkul/Shop/src/Http/Controllers/ReviewController.php @@ -44,8 +44,7 @@ class ReviewController extends Controller public function __construct( ProductRepository $productRepository, ProductReviewRepository $productReviewRepository - ) - { + ) { $this->productRepository = $productRepository; $this->productReviewRepository = $productReviewRepository; @@ -57,15 +56,19 @@ class ReviewController extends Controller * Show the form for creating a new resource. * * @param string $slug - * @return \Illuminate\View\View + * @return \Illuminate\View\View */ public function create($slug) { - $product = $this->productRepository->findBySlugOrFail($slug); + if (auth()->guard('customer')->check()) { + $product = $this->productRepository->findBySlugOrFail($slug); - $guest_review = core()->getConfigData('catalog.products.review.guest_review'); + $guest_review = core()->getConfigData('catalog.products.review.guest_review'); - return view($this->_config['view'], compact('product', 'guest_review')); + return view($this->_config['view'], compact('product', 'guest_review')); + } + + abort(404); } /** @@ -103,7 +106,7 @@ class ReviewController extends Controller * Display reviews of particular product. * * @param string $slug - * @return \Illuminate\View\View + * @return \Illuminate\View\View */ public function show($slug) { From 992d09e8d5ba03cdf7babda7e81961fb6b052281 Mon Sep 17 00:00:00 2001 From: "shubhammehrotra.symfony@webkul.com" Date: Thu, 19 Dec 2019 16:04:55 +0530 Subject: [PATCH 2/2] check guest customer configuration --- .../Webkul/Shop/src/Http/Controllers/ReviewController.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/Webkul/Shop/src/Http/Controllers/ReviewController.php b/packages/Webkul/Shop/src/Http/Controllers/ReviewController.php index d3b77b9a0..450271b1e 100755 --- a/packages/Webkul/Shop/src/Http/Controllers/ReviewController.php +++ b/packages/Webkul/Shop/src/Http/Controllers/ReviewController.php @@ -60,11 +60,9 @@ class ReviewController extends Controller */ public function create($slug) { - if (auth()->guard('customer')->check()) { + if (auth()->guard('customer')->check() || core()->getConfigData('catalog.products.review.guest_review')) { $product = $this->productRepository->findBySlugOrFail($slug); - $guest_review = core()->getConfigData('catalog.products.review.guest_review'); - return view($this->_config['view'], compact('product', 'guest_review')); }