merdan
/
sarga
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #6535 from devansh-webkul/issues/6463 

Fixed there should not be an exception if the admin is trying to add a new variant for the configurable product #6463
This commit is contained in:
Glenn Hermans 2022-07-09 11:40:34 +02:00 committed by GitHub
parent 0737b73d94 f22499c7b0
commit 8d666f784b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/Webkul/Product/src/Type/Configurable.php
View File

@ -172,9 +172,7 @@ class Configurable extends AbstractType
$permutation[$superAttribute->id] = $variantData[$superAttribute->code];
}
$variant = $this->createVariant($product, $permutation, $variantData);
$this->productImageRepository->upload($variant, $variantData['images'] ?? null);
$this->createVariant($product, $permutation, $variantData);
} else {
if (is_numeric($index = $previousVariantIds->search($variantId))) {
$previousVariantIds->forget($index);
@ -293,6 +291,8 @@ class Configurable extends AbstractType
$this->productInventoryRepository->saveInventories($data, $variant);
$this->productImageRepository->upload($data, $variant, 'images');
return $variant;
}