From 8b2b46fd5b785d299baf83a3f5df3b6875c49e5a Mon Sep 17 00:00:00 2001
From: junaidjaved248 <junaidjaved8461@gmail.com>
Date: Thu, 28 Oct 2021 17:00:53 +0500
Subject: [PATCH] SKU Validation Optimization Modified existing one

---
 .../Admin/src/Resources/views/catalog/products/create.blade.php | 2 +-
 packages/Webkul/Core/src/Contracts/Validations/Slug.php         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/Webkul/Admin/src/Resources/views/catalog/products/create.blade.php b/packages/Webkul/Admin/src/Resources/views/catalog/products/create.blade.php
index 4f67a876b..6112627e4 100755
--- a/packages/Webkul/Admin/src/Resources/views/catalog/products/create.blade.php
+++ b/packages/Webkul/Admin/src/Resources/views/catalog/products/create.blade.php
@@ -88,7 +88,7 @@
 
                         <div class="control-group" :class="[errors.has('sku') ? 'has-error' : '']">
                             <label for="sku" class="required">{{ __('admin::app.catalog.products.sku') }}</label>
-                            <input type="text" v-validate="'required'" class="control" id="sku" name="sku" value="{{ request()->input('sku') ?: old('sku') }}" data-vv-as="&quot;{{ __('admin::app.catalog.products.sku') }}&quot;"/>
+                            <input type="text" v-validate="{ required: true, regex: /^[A-Za-z0-9]+(?:-[A-Za-z0-9]+)*$/ }" class="control" id="sku" name="sku" value="{{ request()->input('sku') ?: old('sku') }}" data-vv-as="&quot;{{ __('admin::app.catalog.products.sku') }}&quot;"/>
                             <span class="control-error" v-if="errors.has('sku')">@{{ errors.first('sku') }}</span>
                         </div>
 
diff --git a/packages/Webkul/Core/src/Contracts/Validations/Slug.php b/packages/Webkul/Core/src/Contracts/Validations/Slug.php
index e0626b6ca..7ec068723 100755
--- a/packages/Webkul/Core/src/Contracts/Validations/Slug.php
+++ b/packages/Webkul/Core/src/Contracts/Validations/Slug.php
@@ -15,7 +15,7 @@ class Slug implements Rule
      */
     public function passes($attribute, $value)
     {
-        return true;
+        return preg_match('/^[A-Za-z0-9]+(?:-[A-Za-z0-9]+)*$/', $value);;
     }
 
     /**