merdan
/
sarga
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

getEligble items in action fixed as its was not working as boolean expression

This commit is contained in:
Prashant Singh 2019-09-13 12:22:50 +05:30
parent d02c903470
commit 685aedf528
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/Webkul/Discount/src/Actions/Action.php
View File

@ -26,7 +26,7 @@ abstract class Action
foreach ($items as $item) { foreach ($items as $item) {
foreach ($matchingIDs as $matchingID) { foreach ($matchingIDs as $matchingID) {
if ($matchingID == $item->child ? $item->child->product_id : $item->product_id) { if ($matchingID == ($item->child ? $item->child->product_id : $item->product_id)) {
$matchedItems->push($item); $matchedItems->push($item);
} }
} }

2
packages/Webkul/Discount/src/Actions/Cart/FixedAmount.php
View File

@ -23,7 +23,7 @@ class FixedAmount extends Action
foreach ($matchIDs as $matchID) { foreach ($matchIDs as $matchID) {
foreach ($eligibleItems as $item) { foreach ($eligibleItems as $item) {
if ($item->child ? $item->child->product_id : $item->product_id == $matchID) { if (($item->child ? $item->child->product_id : $item->product_id) == $matchID) {
return true; return true;
} }
} }

2
packages/Webkul/Discount/src/Actions/Cart/PercentOfProduct.php
View File

@ -30,7 +30,7 @@ class PercentOfProduct extends Action
foreach ($matchIDs as $matchID) { foreach ($matchIDs as $matchID) {
foreach ($eligibleItems as $item) { foreach ($eligibleItems as $item) {
if ($item->child ? $item->child->product_id : $item->product_id == $matchID) { if (($item->child ? $item->child->product_id : $item->product_id) == $matchID) {
return true; return true;
} }
} }