merdan
/
sarga
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed duplicate query issue for cart

This commit is contained in:
jitendra 2022-07-12 11:18:58 +05:30
parent 8927614686
commit 5deb1ddc76
2 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
packages/Webkul/Checkout/src/Cart.php
View File

@ -65,7 +65,9 @@ class Cart
{
$this->getCart();
$this->removeInactiveItems();
if ($this->cart) {
$this->removeInactiveItems();
}
}
/**
@ -154,9 +156,9 @@ class Cart
return ['warning' => __('shop::app.checkout.cart.item.error-add')];
}
$product = $this->productRepository->findOneByField('id', $productId);
$product = $this->productRepository->find($productId);
if ($product->status === 0) {
if (! $product->status) {
return ['info' => __('shop::app.checkout.cart.item.inactive-add')];
}
@ -363,9 +365,7 @@ class Cart
*/
private function removeInactiveItems()
{
if (! $cart = $this->getCart()) {
return;
}
$cart = $this->getCart();
foreach ($cart->items as $item) {
if ($this->isCartItemInactive($item)) {
@ -591,7 +591,9 @@ class Cart
return false;
}
if (count($cart->items) === 0) {
$cartItems = $cart->items()->get();
if (count($cartItems) === 0) {
$this->removeCart($cart);
return false;
@ -599,7 +601,7 @@ class Cart
$isInvalid = false;
foreach ($cart->items()->get() as $item) {
foreach ($cartItems as $item) {
$validationResult = $item->product->getTypeInstance()->validateCartItem($item);
if ($validationResult->isItemInactive()) {

4
packages/Webkul/Checkout/src/Providers/CheckoutServiceProvider.php
View File

@ -45,10 +45,6 @@ class CheckoutServiceProvider extends ServiceProvider
$loader->alias('cart', Cart::class);
$this->app->singleton('cart', function () {
return new Cart();
});
$this->app->singleton('cart', \Webkul\Checkout\Cart::class);
}
}