From 50ca8bba1f9df742043d5e45f86afa54b4f22482 Mon Sep 17 00:00:00 2001 From: devansh bawari Date: Mon, 1 Mar 2021 10:57:00 +0530 Subject: [PATCH] Security Issue Fix In Cart --- packages/Webkul/Checkout/src/Cart.php | 28 +++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/packages/Webkul/Checkout/src/Cart.php b/packages/Webkul/Checkout/src/Cart.php index 2d91f991e..feeb0d598 100755 --- a/packages/Webkul/Checkout/src/Cart.php +++ b/packages/Webkul/Checkout/src/Cart.php @@ -320,23 +320,27 @@ class Cart return false; } - $this->cartItemRepository->delete($itemId); + if ($cartItem = $cart->items()->find($itemId)) { + $cartItem->delete(); - if ($cart->items()->get()->count() == 0) { - $this->cartRepository->delete($cart->id); + if ($cart->items()->get()->count() == 0) { + $this->cartRepository->delete($cart->id); - if (session()->has('cart')) { - session()->forget('cart'); + if (session()->has('cart')) { + session()->forget('cart'); + } } + + Shipping::collectRates(); + + Event::dispatch('checkout.cart.delete.after', $itemId); + + $this->collectTotals(); + + return true; } - Shipping::collectRates(); - - Event::dispatch('checkout.cart.delete.after', $itemId); - - $this->collectTotals(); - - return true; + return false; } /**