From 3efe3a7f61bddd327ffc9ce927d74e3df75675db Mon Sep 17 00:00:00 2001
From: Herbert Maschke <thyseus@gmail.com>
Date: Mon, 25 Nov 2019 15:16:21 +0100
Subject: [PATCH 1/2] improve generation of slugs

---
 .gitignore                                        |  3 ++-
 .../Resources/assets/js/directives/slugify.vue    | 15 +++++++++------
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/.gitignore b/.gitignore
index 91f23accb..fa1eccb1e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,7 +5,6 @@
 /public/js
 /public/vendor
 /public/themes
-/storage/*.key
 /vendor
 /.idea
 /.vscode
@@ -21,3 +20,5 @@ yarn.lock
 package-lock.json
 yarn.lock
 .php_cs.cache
+storage/
+storage/*.key
diff --git a/packages/Webkul/Ui/src/Resources/assets/js/directives/slugify.vue b/packages/Webkul/Ui/src/Resources/assets/js/directives/slugify.vue
index 30cb16415..7e1bab0c5 100755
--- a/packages/Webkul/Ui/src/Resources/assets/js/directives/slugify.vue
+++ b/packages/Webkul/Ui/src/Resources/assets/js/directives/slugify.vue
@@ -1,12 +1,15 @@
 <script>
     export default {
         bind(el, binding, vnode) {
-            let handler = function(e) {
-                setTimeout(function() { 
-                    e.target.value = e.target.value.toString().toLowerCase()
-                        .replace(/[^\w- ]+/g,'')
-                        .trim()
-                        .replace(/ +/g,'-');
+            let handler = function (e) {
+                setTimeout(function () {
+                    e.target.value = e.target.value
+                        .toString()
+                        .toLowerCase()
+                        .replace(/[^\w- ]+/g, '')
+                        .replace(/ +/g, '-')
+                        .replace('![-\s]+!u', '-')
+                        .trim();
                 }, 100);
             }
 

From 9e6b983eb47b5fd2d0c6c36b67d5a1bfae990806 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Gro=C3=9Fe?= <david.grosse@haendlerbund.de>
Date: Mon, 2 Dec 2019 12:59:07 +0100
Subject: [PATCH 2/2] add some code documentation to directives/slugify.vue

---
 .../Ui/src/Resources/assets/js/directives/slugify.vue       | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/packages/Webkul/Ui/src/Resources/assets/js/directives/slugify.vue b/packages/Webkul/Ui/src/Resources/assets/js/directives/slugify.vue
index 7e1bab0c5..6399fadb6 100755
--- a/packages/Webkul/Ui/src/Resources/assets/js/directives/slugify.vue
+++ b/packages/Webkul/Ui/src/Resources/assets/js/directives/slugify.vue
@@ -7,11 +7,15 @@
                         .toString()
                         .toLowerCase()
                         .replace(/[^\w- ]+/g, '')
+
+                        // replace whitespaces with dashes
                         .replace(/ +/g, '-')
+
+                        // avoid having multiple dashes (---- translates into -)
                         .replace('![-\s]+!u', '-')
                         .trim();
                 }, 100);
-            }
+            };
 
             el.addEventListener('input', handler);
         }