From 178f89165e8331a8caeae323945412f2753da1bb Mon Sep 17 00:00:00 2001 From: Herbert Maschke Date: Fri, 31 Jan 2020 06:06:13 +0100 Subject: [PATCH] add required validations --- .../Customer/src/Http/Controllers/AddressController.php | 4 ++++ tests/functional/Customer/CustomerCest.php | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/packages/Webkul/Customer/src/Http/Controllers/AddressController.php b/packages/Webkul/Customer/src/Http/Controllers/AddressController.php index 0f3124e95..bbc4f09dc 100755 --- a/packages/Webkul/Customer/src/Http/Controllers/AddressController.php +++ b/packages/Webkul/Customer/src/Http/Controllers/AddressController.php @@ -79,6 +79,8 @@ class AddressController extends Controller $this->validate(request(), [ 'company_name' => 'string', + 'first_name' => 'string|required', + 'last_name' => 'string|required', 'address1' => 'string|required', 'country' => 'string|required', 'state' => 'string|required', @@ -142,6 +144,8 @@ class AddressController extends Controller $this->validate(request(), [ 'company_name' => 'string', + 'first_name' => 'string|required', + 'last_name' => 'string|required', 'address1' => 'string|required', 'country' => 'string|required', 'state' => 'string|required', diff --git a/tests/functional/Customer/CustomerCest.php b/tests/functional/Customer/CustomerCest.php index b3c0f9256..873761be9 100644 --- a/tests/functional/Customer/CustomerCest.php +++ b/tests/functional/Customer/CustomerCest.php @@ -50,6 +50,8 @@ class CustomerCest $this->fields = [ 'company_name' => $faker->company, + 'first_name' => $faker->firstName, + 'last_name' => $faker->lastName, 'vat_id' => 'INVALIDVAT', 'address1[]' => $faker->streetAddress, 'country' => $faker->countryCode, @@ -113,6 +115,8 @@ class CustomerCest { $I->seeRecord(CustomerAddress::class, [ 'company_name' => $this->fields['company_name'], + 'first_name' => $this->fields['first_name'], + 'last_name' => $this->fields['last_name'], 'vat_id' => $this->fields['vat_id'], 'address1' => $this->fields['address1[]'], 'country' => $this->fields['country'],