From 11efdc68b2283693628143b8d0e7a0f2d358851f Mon Sep 17 00:00:00 2001 From: jitendra Date: Tue, 9 Aug 2022 20:02:40 +0530 Subject: [PATCH] Fixed typo in comments and remove unnecessary cart load in CartRepository --- .../Webkul/Category/src/Repositories/CategoryRepository.php | 2 +- .../Checkout/src/Database/Factories/CartAddressFactory.php | 6 +++--- .../Webkul/Checkout/src/Repositories/CartRepository.php | 6 ++---- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/packages/Webkul/Category/src/Repositories/CategoryRepository.php b/packages/Webkul/Category/src/Repositories/CategoryRepository.php index d855d819d..92a2657cf 100755 --- a/packages/Webkul/Category/src/Repositories/CategoryRepository.php +++ b/packages/Webkul/Category/src/Repositories/CategoryRepository.php @@ -170,7 +170,7 @@ class CategoryRepository extends Repository } /** - * Retrive category from slug. + * Retrieve category from slug. * * @param string $slug * @return \Webkul\Category\Contracts\Category diff --git a/packages/Webkul/Checkout/src/Database/Factories/CartAddressFactory.php b/packages/Webkul/Checkout/src/Database/Factories/CartAddressFactory.php index aa2e68423..cb179e9b0 100644 --- a/packages/Webkul/Checkout/src/Database/Factories/CartAddressFactory.php +++ b/packages/Webkul/Checkout/src/Database/Factories/CartAddressFactory.php @@ -22,9 +22,9 @@ class CartAddressFactory extends Factory public function definition(): array { return [ - 'first_name' => $this->faker->firstName(), - 'last_name' => $this->faker->lastName, - 'email' => $this->faker->email, + 'first_name' => $this->faker->firstName(), + 'last_name' => $this->faker->lastName, + 'email' => $this->faker->email, 'address_type' => CartAddress::ADDRESS_TYPE_BILLING, ]; } diff --git a/packages/Webkul/Checkout/src/Repositories/CartRepository.php b/packages/Webkul/Checkout/src/Repositories/CartRepository.php index 56fdd9b2e..fb61d6347 100755 --- a/packages/Webkul/Checkout/src/Repositories/CartRepository.php +++ b/packages/Webkul/Checkout/src/Repositories/CartRepository.php @@ -11,7 +11,6 @@ class CartRepository extends Repository * * @return Mixed */ - function model() { return 'Webkul\Checkout\Contracts\Cart'; @@ -23,9 +22,8 @@ class CartRepository extends Repository * @param int $cartId * @return bool */ - public function deleteParent($cartId) { - $cart = $this->model->find($cartId); - + public function deleteParent($cartId) + { return $this->model->destroy($cartId); } } \ No newline at end of file