Commit Graph

35 Commits

Author SHA1 Message Date
Ben Thomson a59d3b83eb Code quality clean up (#4449)
Credit to @bennothommo
2019-07-18 08:50:37 -06:00
Rachasak Ragkamnerd 70cd444f8a Added support for 'cache' attribute to addJs() to disable CF RocketLoader (#4092)
Credit to @itpcc 

Due to CloudFlare Rocket Loader, CF will automatically try to optimize page loading speed by changing script type attribute. This breaks the script execution order and makes the user unable to upload the file(s) in the backend using "FileUpload" widget.

However, [CloudFlare allows adding "data-cfasync"](https://support.cloudflare.com/hc/en-us/articles/200169436-How-can-I-have-Rocket-Loader-ignore-specific-JavaScripts-) to prevent this. And it was used in the [commit #3841](https://github.com/octobercms/october/pull/3841/files).
2019-04-16 20:27:13 -06:00
Nicolas Da Mutten aeb7616d06 Automatically use local asset path when attempting to combine injected assets (#3802)
Credit to @cleverer. Fixes #3264.
2018-09-24 14:17:00 -06:00
Luke Towers 5acbdb12fe Compiled assets and whitespace cleanup 2018-04-17 13:43:51 -06:00
Luke Towers 68e874dc97 AssetMaker Improvements (#2847)
* Check if asset file exists before symbolizing path

Adds a check to see if the asset file exists before attempting to symbolize it, this will allow the asset combiner to be passed assets with complete paths instead of only relative paths.

* Implement combiner business logic

* Improve handling of bad inputs
2017-04-27 00:17:05 -06:00
Quezler cc17b679f1 Code dusting (#2826)
Code cleaning according to PSR-2 w/ exemptions (mostly dust).
2017-04-24 21:38:19 +10:00
Samuel Georges e54cf7133b Improve some inline docs in preparation for API docs 2017-03-14 19:36:17 +11:00
Samuel Georges 676196d304 Use starts_with instead of regex 2016-07-16 15:34:20 +10:00
Samuel Georges 74a6a71bcb Parameters -> Parameter
(Models should be singular)
2016-05-31 08:17:48 +10:00
Samuel Georges ba57dd8993 clearAssetDefinitions -> flushAssets 2016-04-12 18:04:15 +10:00
Joshua Wilson 6f3d7a58f2 Phpdoc cleanup for System\Traits
removed in WidgetMaker trait

phpdoc cleanup of backend traits and classes

Minor fix for cases when file is not found
2016-02-13 14:06:50 +11:00
Samuel Georges b65a653176 Add ability to null asset broadcasting from AJAX 2016-01-16 17:12:54 +11:00
Samuel Georges 7145aac457 Prepare for CDN, config rename cms.plugins|themes|uploadsDir -> cms.plugins|themes|uploadsPath
Deprecate data-trigger-type on triggerapi
Fixes ref to Util class
2015-02-17 20:58:38 +11:00
Samuel Georges 610ea932fc Fixes #856 - Implement a linking policy, defaults to relative 2015-02-09 21:52:17 +11:00
Samuel Georges 9dba058fe5 Remove PATH_APP + PATH_BASE constants 2015-02-07 15:43:49 +11:00
Samuel Georges 03eb949e71 Add illuminate/html package, DB -> Db, HTML -> Html 2015-02-04 20:03:44 +11:00
Samuel Georges b1b700368f Radical reorg of some classes 2015-01-28 11:49:54 +11:00
Samuel Georges 69a3aedffb Fixes an issue where duplicate assets are sent across the AJAX wire 2015-01-13 17:46:46 +11:00
Sam Georges c83797231d Subsequent expressions are on a new line (see developer guide > PSR exceptions) 2014-11-01 12:00:45 +11:00
Stefan Talen f85087eac6 Updating modules/system 2014-10-18 11:58:50 +02:00
Sam Georges 746f425d88 Added new containerAttributes property to form fields 2014-09-25 18:05:35 +10:00
Sam Georges 938f9957de Add PathMaker trait, Combiner now supports aliases and dynamic paths 2014-08-29 19:23:57 +10:00
Sam Georges 982b22a676 Fixes #547 - Duplicate assets are pointless 2014-08-16 09:17:09 +10:00
Sam Georges bfc3804a1a If a base classes uses a trait, no need to reuse that trait because Model boots all traits now 2014-08-03 11:57:51 +10:00
Sam Georges 1f64ccf792 Traits use private instead of protected so they can be used/reused in base classes 2014-08-03 10:04:06 +10:00
Sam Georges 6388ecef52 private -> protected 2014-08-01 13:58:59 +10:00
Sam Georges 7802213bcc Fixes #55 - Assets are now referenced correctly as Assets instead of URLs 2014-06-26 17:29:07 +10:00
Sam Georges ab889f0973 Minor improvement 2014-06-06 21:44:35 +10:00
Hariadi Hinta df5fcc1936 AssetMaker now can inject external assets
Calling `addJs()`, `addCss()` and `addRss()` in components starting
with https/http or double slash (//) will now reference to the
appropriate URL.
2014-06-06 10:59:33 +08:00
Sam Georges 82f586c0d1 Asset maker functions (addJs, addCss, addRss) now use an optional build code, either *core* or a plugin code. 2014-05-24 16:35:54 +10:00
Sam Georges 43b3455f75 Fixes #125 2014-05-16 16:10:29 +10:00
Sam Georges f3827e230f Minor clean up 2014-05-16 11:04:46 +10:00
alxy 8cc375939f Minor fixes 2014-05-15 22:32:56 +02:00
alxy ef2ea60061 Add $attributes param to asset function
This commit adds a second parameter $attributes to the following functions:

- AssetMaker::addJs
- AssetMaker::addCss
- AssetMaker::addRss

This is useful when dealing with javascript libraries like require.js, which depend on these HTML attributes to function properly.

It does not break the existing code!
2014-05-15 15:48:14 +02:00
Sam Georges 71a5dd67ab Welcome to the world, October :-) 2014-05-14 23:24:20 +10:00