Commit Graph

2709 Commits

Author SHA1 Message Date
Luke Towers fa002ce3dd Minor cleanup 2019-10-09 09:44:24 -06:00
Luke Towers 96e335aebc
Fix #3415, #4672 (#4674)
Handle child FormWidgets making AJAX requests outside of the repeater's form container. Note that this won't pass on the state of the repeater item as it exists on the webpage because that information won't be sent to the server in an AJAX request sent from outside of the repeater's form container unless the FormWidget sending the orphaned request specifically includes that data in their request, in which case the regular handling will kick in and initialize the widget properly. A discussion should be had whether this fix makes sense to be done in the Repeater FormWidget or if we should force FormWidgets to have the responsibility of initializing their parent repeaters if they're going to be making orphaned AJAX requests.

Should fix #3415, #4672.
Related: octoberrain/test-plugin#78
2019-10-09 08:08:21 -06:00
Alwin Drenth b2dcd3c9fd Update Dutch (NL_nl) translation (#4676)
Credit to @adrenth
2019-10-09 13:08:31 +03:00
Luke Towers 06ba8c712f
Trigger the change.oc.formwidget event on update of records through relationcontroller. (#4673)
Fixes #4625. Credit to @danielbidala for the initial report and proposed fix.
2019-10-08 17:30:02 -06:00
Ben Thomson 970cc4550c
Improve internal docs for DataTable callback handler
- Changes parameters to match their intended data.
- Updates docblock
- Minor code cleanup

Refs: https://github.com/octobercms/october/issues/4664#issuecomment-539028664
2019-10-07 22:19:13 +08:00
Luke Towers d31006ae1a Return 403 response on CSRF fail instead of silently failing
Also moved backend::lang.page.invalid_token.label to system::lang.page.invalid_token.label. Fixes
2019-10-06 23:21:08 -06:00
Luke Towers 17f3c6f74b Added 'email' field type 2019-10-06 16:15:29 -06:00
Tobias Kündig 4f34ac5f4a Prevent flash of unstyled tabs on page load (#4666)
Credit to @tobias-kuendig.
2019-10-06 14:42:40 +08:00
Harmen Janssen 83d14c8503 Add support for order option on relation FormWidget (#4654)
Credit to @harmenjanssen. Documented in https://github.com/octobercms/docs/pull/406
2019-10-06 00:24:31 -06:00
Ben Thomson c3d99b2acf
Remove void return types in PreferenceMaker
Maintains PHP 7.0 compatibility. Will likely be re-added once rebased to Laravel 6.

Fixes #4659.
2019-10-03 22:07:37 +08:00
Saifur Rahman Mohsin f6c789f716 Added getConfig helper method to get config values (#4653)
Credit to @SaifurRahmanMohsin 

Added getConfig to make it easier for developers to fetch the config data from a list column while overriding the list items through extension. This also makes the class more compatible with [FormField](https://github.com/octobercms/october/blob/master/modules/backend/classes/FormField.php) which already has the same helper function.
2019-10-02 16:33:14 -06:00
Samuell 5d6fe72619 Update delete buttons in user controllers (#4640)
Credit to @Samuell1
2019-09-26 14:58:07 -06:00
罗光盛 c19ccb4f60 Update zh-cn backend translations (#4635)
Credit to @everyx.
2019-09-26 12:38:22 +08:00
Tomasz Strojny 815ec1a174 Typo fix for Polish language file (#4634)
Credit to @tomaszstrojny.
2019-09-24 15:42:01 +08:00
Dan Harrin 919835e5de Add method removePermission() for AuthManager (#4522)
Allows programmatic removal of permissions being listed in Permission selection widget.

Credit to @DanHarrin.
2019-09-21 23:42:11 +08:00
Samuel Georges b37641e94d Lazyload top navigation icons - refs #4562 2019-09-21 13:12:49 +10:00
Samuel Georges b60adf2952 This stops tabnabbing apparently
Refs #4550
Refs https://en.wikipedia.org/wiki/Tabnabbing
2019-09-21 12:44:04 +10:00
Samuel Georges 6daea258b9 Tidy up checkbox list - refs #4599
Also had to revert the 100vw improvement on tabs because it causes unnecessary scroll/drag activation. Also reverted change in form.base.less that had no reasoning.
2019-09-21 12:36:31 +10:00
Samuel Georges 202d1f6b04
Update the checkbox list widget (#4599) 2019-09-21 11:57:53 +10:00
Luke Towers 7e6c1aed84 Added ability to specify a LESS file to be used as a default backend brand CSS override with the config item "brand.customLessPath" 2019-09-18 18:27:18 -06:00
Luke Towers fafd05f7c0 Cleaning up spacing 2019-09-14 06:27:24 -06:00
Dan Harrin 7b8fecaa51 Replace use of parseJSON with JSON.parse (#4517)
Credit to @DanHarrin
2019-09-14 06:25:18 -06:00
Samuel Georges 2962f75221 Include the JSON parser natively in framework.js
We've also included it as a separate framework.parser.js file in case its needed by some external lib, such as Storm UI
2019-09-14 17:56:18 +10:00
Samuel Georges ebcb7ee6fd
Add a small JSON Parser to October framework lib (#4527)
* Add a small JSON Parser to October framework lib
2019-09-14 17:29:31 +10:00
pavelmgn 4684312cee Pass path by reference in media.file.upload (#4616)
Credit to @pavelmgn. Refs: https://github.com/octobercms/october/issues/3124#issuecomment-529577947
2019-09-11 22:22:08 -06:00
Samuel Georges 52e2a838eb Fixes typo, recompile assets 2019-09-11 21:42:02 +10:00
Samuel Georges 3291e07191
Update Deprecated code in October into (event.key) (#4489)
Update Deprecated code in October into (event.key)
2019-09-11 21:35:18 +10:00
Samuel Georges 31145a3eb7 Peer review visibility changes
It makes more sense to use a consistent UI for all modes, the CSS is cleaner as a result. The code editor toolbar has been moved to the bottom across all instances. This is favourable to it bleeding outside of its perimeter.

Refs #3947
Refs #3948
2019-09-11 20:54:14 +10:00
Samuel Georges 96537033c8 Recompile assets 2019-09-11 20:02:43 +10:00
Samuel Georges 86ff037221
Merge pull request #4279 from ghost/dropzone
Update Dropzone V4.0.1 to V5.5.1
2019-09-11 20:00:16 +10:00
Ben Thomson 0240c21af6 Fail CSRF token checks if the session expires. (#4598)
Fixes #4595. Credit to @bennothommo
2019-09-04 21:33:10 -06:00
Ayumi Hamasaki 6942e38615 Remove the IE5 - IE7 Holly Hack support (#4594)
Credit to @ayumihamsaki
2019-09-04 09:32:29 -06:00
Ayumi Hamasaki 92e975ffa3 Make the Code editor fullscreen button easier to see (#4546)
Credit to @ayumihamsaki
2019-09-03 11:13:41 -06:00
Luke Towers de3f8142fb Support multiple instances of the PermissionEditor on a single page 2019-08-29 17:51:52 -06:00
Ben Thomson a67ccfe993
Allow decompiled Backend JS assets (#4549)
This change will allow the individual JS assets that are compiled into a full compilation file to be loaded individually instead, allowing the developer to see their changes immediately. It introduces a new configuration variable, `cms.decompileBackendAssets`, that controls this functionality. By default, it is false and not tied to the debug value, requiring it to be explicitly enabled.
2019-08-16 16:19:16 +08:00
Dan Harrin 3365820178 Use selected dropdown item as repeater title (#4544)
Credit to @DanHarrin. Initial implementation by @MattPurland. Finishes https://github.com/octobercms/october/pull/2956
2019-08-16 16:13:35 +08:00
Saifur Rahman Mohsin ecf75e7e46 Mention the lang dependency (#4551)
Credit to @SaifurRahmanMohsin.
2019-08-15 16:55:07 -06:00
Ayumi Hamasaki 7aae3f1ef8 Upload vendor file Spectrum V1.8.0 (#4536)
Credit to @ayumihamsaki
2019-08-15 10:04:59 -06:00
Dan Harrin f7539b2c32 Added getReportWidgets() method (#4525)
Credit to @DanHarrin
2019-08-15 09:36:15 -06:00
Dan Harrin 9521dd795c Minor Formatting Corrections in Usage Comments (#4541)
Credit to @DanHarrin
2019-08-15 09:14:54 -06:00
Ben Thomson f190f7a347
Fix exception on middleware loader
An exception was thrown when loading middleware if a requested controller is from a disabled plugin, as the `getRequestedController` method returns a Response object in this scenario.

Hat tip to @w20k.
2019-08-15 16:52:24 +08:00
Samuell 9b8974b003 Add validator for plugin navigation items (#4497)
This will detect invalid navigation item configuration in installed plugins. In debug mode, this will throw an error, otherwise, it will simply log the error.

Credit to @Samuell1. Fixes #4491.
2019-08-15 11:47:13 +08:00
Samuell 60a235e000 Add warning in status widget when debug mode is enabled (#4500)
Debug mode is now shown as a warning in the Status report widget to indicate that its use is discouraged for production websites.

Credit to @Samuell1.
2019-08-15 11:44:22 +08:00
Dan Harrin 67c9decb20 Standardise use of [] vs array() (#4548)
Credit to @DanHarrin
2019-08-14 20:46:36 -06:00
Luke Towers 36ab42aa24 Ensure the the TagList FormWidget is respecting relationship constraints (conditions & scope) 2019-08-14 19:58:42 -06:00
Luke Towers b75d0af966 Improve support for previewMode in Repeaters & NestedForms
Fixes #4521
2019-08-10 09:28:01 -06:00
Ben Thomson c8ae520a79
Fix code smells in lang files left from last commit 2019-08-09 16:19:44 +08:00
Ben Thomson 199407f1a0
Revert #4401 for build 458.
Reverts commit 22847e7892. Will be redeployed in build 459.
2019-08-09 16:07:32 +08:00
Ben Thomson b5a3c64bf1
Fix "widget not bound to controller" error for nested repeaters (#4434)
Since repeaters have no value by themselves, a repeater that contains only another repeater was throwing a "widget not bound to controller" exception when adding a new item - the repeater item processing was not creating a form widget for the inner repeater on load, or in an AJAX call. This fix specifically checks if a child repeater has called for a new item, and if so and the current repeater has no value for this particular item, it will add a "stub" form widget to correctly bind the widget.

Fixes #4344.
2019-08-07 22:44:31 +08:00
Ben Thomson 8219f19e8d
Style side panel header with brand colors
Remove commented-out code
2019-08-04 15:35:18 +08:00