Commit Graph

558 Commits

Author SHA1 Message Date
Samuel Georges 6593651331 Add file check for image upload form widgets - Fixes #3653 2019-03-29 02:23:20 +11:00
Luke Towers 3954704dda Fix issue with multiple repeaters with the same fieldname embedded in the same controller
There was a conflict between two repeaters that had the same fieldName (data) bound to the same controller. Example:

Controller: Events
Manages a ReportTemplate model with a custom popup Form widget that uses a grouped repeater with the field name data to define the available "fields" within a ReportTemplate
Also manages Report models through a relation controller that uses a Form widget with a regular repeater with the field name data that defines the values of the fields defined by the associated ReportTemplate.

Since both repeaters had the field name of "data", but one of them was grouped and the other wasn't, this would cause an issue in Repeater::processExistingItems() where the grouped repeater would attempt to process the ungrouped repeater's data which would then fail. This issue could easily cause many other vastly more confusing and difficult to detect issues in cases where multiple repeaters with the same field name AND the same mode (grouped vs regular) existed on the same page under different contexts. The simple solution is just to ensure that the indexInputName and groupInputName are both taking the repeater's alias into account when being generated to ensure that everything stays unique like it should.
2019-03-18 12:39:12 -06:00
Ben Thomson 13a7cc915d Use Form getSaveData method when saving form widgets within repeaters (#4160)
Credit to @bennothommo
2019-03-15 22:39:34 -06:00
Luke Towers d5e7419312 Support enableDefaults on repeaters using grouped mode 2019-03-12 01:19:37 -06:00
Panagiotis Koursaris bb0a23f54c fixes enable Defaults on repeater (#4129)
Credit to @panakour
2019-02-11 09:54:55 -06:00
Ben Thomson 10d97d515f Use singular byte for '1 byte' filesize (#4130)
Credit to @bennothommo
2019-02-11 09:48:15 -06:00
fansaien 680c729f90 Set the datetime value with time 00:00:00 when using the date mode (#4111)
Credit to @fansaien
2019-02-06 10:23:50 -06:00
Ben Thomson 4f3997c6de Make the filesize display in file upload widget more consistent (#4110)
Credit to @bennothommo. Fixes #4085.
2019-02-04 12:54:07 -06:00
Ben Thomson 970d5622c0 Allow datatables to work within a repeater (#4102)
Fixes #4063. Credit to @bennothommo.
2019-02-04 12:50:40 -06:00
Antonie Hogewoning 16ca521cd0 Fix setting default values for repeater in update context (#4098)
Credit to @CptMeatball
2019-01-31 13:50:21 -06:00
Luke Towers 920eb15af5 Added support for using the record finder without a model relationship
Added useRelation and modelClass config options
2019-01-18 18:16:16 -06:00
Luke Towers 3ff77120c6 Improved disabled support for balloon-selector and fileupload fields 2019-01-16 13:32:31 -06:00
Luke Towers 2d6b9c76a9 Recompile assets 2019-01-15 13:35:12 -06:00
Luke Towers a9a0544ab0 recompiled stylesheets, retaining newlines for improved diff readability 2019-01-14 11:52:16 -06:00
fansaien d6b1b6e95d Fixed the Delete and Enter not being captured in keydown.oc.richeditor (#4015)
Credit to @fansaien.

The keydown event can not capture the Backspace(Delete) and Enter key event. 

Moved the binding keydown function into froalaEditor.initialized event to solve this issue. Please review this Froala Editor issue: https://github.com/froala/wysiwyg-editor/issues/1879

The editor.events doesn't support off function. So, can not call off function in the unregisterHandlers()
2019-01-03 14:07:29 -06:00
Luke Towers 400ce2391e Fix support for the placeholder property in RichEditor FormWidgets 2018-12-27 15:28:10 -06:00
Luke Towers ed226e0b09 Recompiled hotkey JS 2018-12-20 13:41:32 -06:00
Luke Towers 44ac62abeb Recompiled LESS using new CSS minification 2018-12-20 13:41:09 -06:00
munxar e6f4e13446 Added NestedForm FormWidget (#3977)
Credit to @munxar
2018-12-19 21:54:20 -06:00
fansaien db7610d5c4 Removed the deprecated hotkeyMac (#3995)
Reference: fd264a5fb4 (diff-79eab92a9098980b73745ce9b5ac1895)
2018-12-19 20:21:05 -06:00
Tim caf7cb406f MediaFinder: trigger change event (#3446)
Credit to @scorewinner.
2018-12-04 11:12:26 -06:00
Christos Christou 9f63ad2739 Fix Repeater max & min client side validation when using groups (#3953)
Credit to @c2webstudio.
2018-12-03 13:53:12 -06:00
Ayumi Hamasaki 8e9b3dba54 Improve visibility of code editor buttons in the backend (#3948)
Credit to @ayumihamsaki. Fixes #3947.
2018-11-30 16:59:08 -06:00
Romaldy Minaya cca3c704a3 Fixes #3119 (#3163)
Added readOnly support to RecordFinder, Switch widget and relation widget including dropdown Fixes #3119. Credit to @romaldyminaya
2018-11-23 00:33:01 -06:00
Siarhei Karavai ff8b967b75 Add support for placeholder in TagList widgets (#3453)
Credit to @GinoPane.
2018-11-15 13:32:59 -06:00
Kanstantsin 813721edf1 Change z-index of full-screen markdown editor (#3838)
Fixes #3837. Credit to @iotch. Tested with Octodock provided by @petehalverson.
2018-10-03 10:56:08 -06:00
Samuel Georges 5cc327c45c
Merge pull request #3690 from nathan-van-der-werf/feature/cleanup
Code cleanups
2018-08-30 13:12:42 +10:00
Samuel Georges 6099096e5d Increase visibility of close button
Fixes #3723
2018-08-30 12:40:45 +10:00
Nathan van der Werf 8fd16d4db6
Merge branch 'develop' into feature/cleanup
# Conflicts:
#	modules/backend/formwidgets/FileUpload.php
2018-08-24 19:52:54 +02:00
Nathan van der Werf 0f0d108da0
Remove unused imports 2018-08-24 19:51:59 +02:00
Nathan van der Werf 66fa03f17e
Revert "Remove unused imports"
This reverts commit 742a5f415b.
2018-08-24 19:40:40 +02:00
Szabó Gergő e46eff8a26 Remove hard height constraint from previewing uploaded images (#3718)
Fixes #3698. Credit to @gergo85
2018-08-23 09:32:18 -06:00
Luke Towers fd4ee47065 Improved repeater item collapse button when remove button not present 2018-08-22 21:06:06 -06:00
Luke Towers 29c0c8c33d Improvements to Repeater form widget styling
Improved the styling of the Repeater form widget, made it easier to distinguish between individual repeater items
2018-08-22 20:51:26 -06:00
Samuel Georges bf841b4340 Minor peer review 2018-08-21 13:24:59 +10:00
vanmil 38bf854051 Add ability to use model method to define availableColors (#3704)
Credit to @vanmil. Documented in https://github.com/octobercms/docs/pull/314
2018-08-20 08:45:26 -06:00
Nathan van der Werf a3d7a028b4 Replace is_null with "=== null" comparison 2018-08-15 18:54:46 +02:00
Nathan van der Werf bc17975634 Remove alias functions 2018-08-15 18:51:25 +02:00
Nathan van der Werf 123145fd54 Remove unnecessary parentheses 2018-08-15 18:49:52 +02:00
Nathan van der Werf 3a918ad200 Remove "null" assignments 2018-08-15 18:33:24 +02:00
Nathan van der Werf 742a5f415b Remove unused imports 2018-08-15 18:27:36 +02:00
Luke Towers cbed54a263 Implemented minItems repeater property on client & server
Also implemented maxItems on server (previously only client). Fixes https://github.com/octobercms/october/issues/3668
2018-08-12 01:33:51 -06:00
Luke Towers 6774920003 Finish implementing titleFrom option for Repeaters
Ref: e7609aa5e8
2018-08-11 20:27:53 -06:00
vanmil 4cdbf2a051 Add customization of froala lineBreaker tags (#3687)
Credit to @vanmil
2018-08-11 13:33:34 -06:00
Michał Płodowski 68ee471d39 Add showWeekNumbers option to datepicker (#3637)
Fixes #3634. Credit to @mplodowski
2018-07-12 18:10:24 -04:00
Luke Towers 0086a47b80 Add attachOnUpload option to FileUpload formwidget
Fixes #3501
2018-06-04 16:22:23 -06:00
Viamage 667b82e6ce Replace keyup listener with input listener (#3567)
Fixes #1270. Credit to @viamage
2018-05-30 20:26:38 -06:00
Ayumi Hamasaki 026ae1e15f Fix Scrolling bug (#3547)
Fixes #3542
2018-05-13 16:32:12 -06:00
Joey 541f0a78f1 Fix for missing _group field when saving data from a nested group repeater (#3523)
Fixes #3067. Credit to @Narkoleptika. Thanks to @petehalverson for his docker container work for replicating.
2018-04-26 00:13:28 -06:00
Luke Towers 422a99770c
Attach uploaded files directly to parent if exists
If the parent of the file attachment relationship already exists, then attach the file directly to it in this request instead of going through deferred bindings. Will continue to attach files through deferred binding if the parent relation doesn't exist.
2018-03-09 23:47:16 -06:00