Commit Graph

303 Commits

Author SHA1 Message Date
Luke Towers ad69711634 Merge branch 'develop' into wip/laravel-6 2020-06-11 10:38:29 -06:00
Ben Thomson 8dba43ba0b
Allow plugin autoloaders to load on restricted pages and actions (#5120)
Allow plugin autoloaders to load, even on restricted pages. This allows (enabled) plugins to load their autoloaders on any pages, allowing includes in migration files to run.

Fixes #5110.
2020-06-09 21:46:17 -06:00
Luke Towers 252c9b7f58 Merge branch 'develop' into wip/laravel-6 2020-05-27 12:44:54 -06:00
Nick Khaetsky ce7335f6cb
Add warning with missing dependencies on Updates page (#5077)
Fixes #4843.
2020-05-26 10:05:40 -06:00
Dieter Holvoet 40d8bb453e
Get file and folder metadata for media items using a single network call if possible (#5046)
Co-Authored-By: Ben Thomson <ben@abweb.com.au>. Fixes #5045.
2020-05-26 03:20:41 -06:00
Luke Towers e78d5fe2bf Merge branch 'develop' into wip/laravel-6
# Conflicts:
#	modules/system/classes/UpdateManager.php
#	modules/system/classes/VersionManager.php
2020-04-29 16:58:58 -06:00
Kallef Alexandre b4c65e9feb
Added plugin:rollback command (#4389) 2020-04-11 09:46:22 -06:00
Luke Towers 44cc5d371b Merge branch 'develop' into wip/laravel-6 2020-04-04 02:32:16 -06:00
Luke Towers 8b9c001b9a Allow disabled plugin's translations to load for display translations on system pages 2020-04-02 22:15:30 -06:00
LeMaX10 ea42de9181
Use plugin & theme path helpers in the update manager (#4770) 2020-04-02 10:52:23 -06:00
Luke Towers ccb2c372bb Only force absolute URLs for media items if cms.linkPolicy = force
This fixes #4082 & rainlab/pages-plugin#405. Reverts a previous breaking change from Build 444 (introduced in #3536) by limiting the scope to which it applies.
2020-04-02 10:18:23 -06:00
Marc Jauvin b1d41caf03
Improve PluginManager code (#5023) 2020-04-02 09:30:15 -06:00
Marc Jauvin 600fbd7cfa
Improve code readability for exists method (#5022) 2020-04-02 08:33:58 -06:00
Luke Towers 61b4ef6a47 Minor cleanups to the PluginManager.
Cleans up docblocks and makes most helper methods more permissive of incorrectly cased plugin identifiers. Replaces #4838 & #4837. Credit to @mjuavin for the case insensitivity fixes.
2020-04-01 21:30:54 -06:00
Luke Towers 79f0a9413b Merge branch 'develop' into wip/laravel-6
# Conflicts:
#	composer.json
2020-03-31 04:36:47 -06:00
Luke Towers 243c835c24 Minor performance improvement for PluginManager.
Suggested by @tobias-kuendig in #4337, implemented because normalizeIdentifier() would be called more frequently by merging #4838.
2020-03-31 00:36:33 -06:00
Ben Thomson 8c61985114 Merge branch 'develop' into wip/laravel-6 2020-03-16 17:13:42 +08:00
Alwin Drenth 56b2864ef5
Change PluginBase::boot return type to void (PhpDocBlock) (#4957) 2020-02-28 17:52:01 +08:00
Samuel Georges 73b551cf04 Switch to October Rain assetic 2020-02-27 20:07:42 +11:00
Samuel Georges 7b00768f3a Remove local notes support 2020-02-27 20:07:41 +11:00
Ben Thomson 56785bcd3c
Fix missing output when UpdateManager is run within the Backend 2020-01-19 23:15:02 +08:00
Ben Thomson 852ed1afb8
Remove deprecated `getNotes` method from UpdateManager 2020-01-19 22:56:24 +08:00
Ben Thomson 5d3d4ad0b2
Merge branch 'develop' into wip/laravel-5.9 2020-01-18 21:00:40 +08:00
jacobdekeizer 3a28771c2c Fix registerSchedule typehint in PluginBase (#4871) 2020-01-10 11:55:54 +08:00
Luke Towers 64d7464ed3
Improve cms.combiner.beforePrepare event docs
Related: #4865
2020-01-06 11:40:20 -06:00
Samuel Georges adb303a53c Always sort plugins by key, then dependencies
This has been benchmarked and appears to have minimal impact on performance and solves unnecessary randomness and race conditions during the app's registration and boot cycle

Fixes #4826
2019-12-21 20:50:28 +11:00
Samuel Georges 70e57120d0 ApplicationException -> SystemException
This appears to be a typoe. It doesn't make sense to ever log "user errors", only "system errors"

Fixes #4569
2019-12-10 19:59:49 +11:00
Larry Barker 2b05d01c6c Support additional file name and path characters in media manager (#4564)
* Support additional file name and path characters in media manager

When working with abstract file names that may contain additional characters, such as quotes or ampersands, the media manager would throw an error. This PR adds two additional characters to the character whitelist.

* Add unicode filename to tests
2019-12-05 19:44:04 +11:00
Luke Towers 7e98e199a4 Revert #4567, fixes #4648.
If including the asset extension is important, this can be done by listening to the `system.assets.beforeAddAsset(&$type, &$path, &$attributes)` event introduced in Build 460.
2019-11-28 10:32:34 -06:00
Ben Thomson e9abdf7783
Parenthesise some double ternary conditions in Asset Combiner.
Improve compatibility with PHP 7.4, where "Unparenthesized `a ? b : c ?: d` is deprecated"

Fixes #4790.
2019-11-28 09:21:03 +08:00
Marc Jauvin 992e84e602 Add missing documentation comment blocks for fired events (#4788)
Credit to @mjauvin.
2019-11-24 23:59:00 -06:00
Ben Thomson 7e3136564f
Merge branch 'develop' into wip/laravel-5.9 2019-11-21 23:18:25 +08:00
Samuel Georges 1b22b851f6
Merge pull request #4428 from alxy/patch-27
Fix error when $user is null
2019-09-21 13:36:30 +10:00
alekseyp 5afb1ee04f Include file extension in combiner URLs (#4567)
Credit to @alekseyp.
2019-08-25 19:52:14 -06:00
Dan Harrin 9521dd795c Minor Formatting Corrections in Usage Comments (#4541)
Credit to @DanHarrin
2019-08-15 09:14:54 -06:00
Dan Harrin 67c9decb20 Standardise use of [] vs array() (#4548)
Credit to @DanHarrin
2019-08-14 20:46:36 -06:00
Ben Thomson a59d3b83eb Code quality clean up (#4449)
Credit to @bennothommo
2019-07-18 08:50:37 -06:00
Alexander Guth 7c6631f2d4
Fix error when $user is null
I have no idea why the $user variable can ever be null in the first place, but for me it happens if I remove all main menu items (including the settings). The same check is already in place at the navigation manager: https://github.com/octobercms/october/blob/master/modules/backend/classes/NavigationManager.php#L509-L511
The change shouldn't brake anything.
2019-07-03 22:17:36 +02:00
Tobias Kündig 604f0d060d Make plugin dependency checks case-insensitive (#4337)
Normalize the plugin identifier before lookup in the `hasPlugin` call, which should allow plugin dependencies to resolve if mis-cased in the Plugin `$require` property.

Credit to @tobias-kuendig.
2019-07-02 22:12:29 +08:00
Luke Towers 627c0aa643 Replaced JSMin with JSqueeze 2019-06-12 02:33:53 -06:00
Luke Towers 1aff1e0a1e Changed calls to the Cache to use DateTime instances instead of integers representing minutes as 5.8 changed integers into meaning seconds instead. 2019-06-12 02:33:26 -06:00
Jim Cottrell e2c89fb3a2 If using database, don't call plugin task scheduling until initial system migration runs. (#3712)
Fixes #3208. Replaces #3706. Credit to @jimcottrell
2019-04-19 14:54:48 -06:00
Siarhei Karavai 2e0d2d3888 Allow subdirectories in migration file names (#4225)
Credit to @GinoPane. Fixes #4224.
2019-03-31 08:46:33 -06:00
Samuel Georges c5bc804d73 Remove redundant header_remove() call
The response is returned directly to the route so this is not needed, it was likely added as an artefact of a previous implementation

Refs #3773
Refs #3746
2019-03-29 06:02:06 +11:00
Luke Towers bb872f331c
Merge pull request #4218 from octobercms/fix/4209
Fixes #4209, replaces #4215
2019-03-28 09:43:09 -06:00
Samuel Georges adc74ac02e Add changelog link to updates screen - Fixes #4101 2019-03-29 00:21:51 +11:00
Luke Towers c86bec7f08 Replace deprecated Twig class references, refs: #4209. 2019-03-27 13:15:17 -06:00
Siarhei Karavai 8606db9e77 Add support for file names with multiple dots (#4211)
Fixes #4210. Credit to @GinoPane
2019-03-25 09:57:06 -06:00
alekseyp 8ea36eac9c Return 500 on exception during asset combining (#4142)
Credit to @alekseyp
2019-02-27 14:33:48 -06:00
Luke Towers 7f3fb06945 Support custom 500 page when debug mode disabled and CMS module not present 2019-02-26 14:26:56 -06:00