Commit Graph

190 Commits

Author SHA1 Message Date
Ben Thomson a59d3b83eb Code quality clean up (#4449)
Credit to @bennothommo
2019-07-18 08:50:37 -06:00
Long Wen 07a852ed8a Fix selection issue for similar-named CMS objects (#4433)
CMS objects with the same name as another object (eg. "test.htm" for a page and "test.htm" for a partial) were unable to be selected (selecting the partial selected the page).

Credit to @wenlong-date.
2019-07-05 16:47:30 +08:00
Samuel Georges 5190c8177b Avoid terminating the app using exit() or die()
Refs #3783
Refs #3746
2019-03-29 07:10:07 +11:00
Nathan van der Werf 7232e7a29d Escape output to prevent XSS injection (#4074)
Credit to @nathan-van-der-werf
2019-01-18 10:26:56 -06:00
Luke Towers 4438ddc47e
Merge pull request #3963 from ayumihamsaki2/master
Sets the Folders in Code Editor to Collapsed by default. Fixes #3962. Credit to @ayumihamsaki2
2018-12-05 21:13:00 -06:00
Ayumi Hamasaki 1e0d045c74 Sets Folders in Code Editor to Collapse by Default
This fixes the github Issue found here: https://github.com/octobercms/october/issues/3962
2018-12-06 00:39:31 +00:00
Szabó Gergő ef32d45cd4 Change the delete buttons style to danger (#3852)
Credit to @gergo85
2018-10-10 08:40:03 -06:00
Nathan van der Werf 8fd16d4db6
Merge branch 'develop' into feature/cleanup
# Conflicts:
#	modules/backend/formwidgets/FileUpload.php
2018-08-24 19:52:54 +02:00
Nathan van der Werf 0f0d108da0
Remove unused imports 2018-08-24 19:51:59 +02:00
Nathan van der Werf 66fa03f17e
Revert "Remove unused imports"
This reverts commit 742a5f415b.
2018-08-24 19:40:40 +02:00
Nathan van der Werf 4142c9c9e6 Modify sorting icon from "desc" to "asc" (#3705)
Credit to @nathan-van-der-werf
2018-08-17 15:12:41 -06:00
Nathan van der Werf 62c59a4903 Refactor ternary operators to null coalescing operators 2018-08-15 19:15:13 +02:00
Nathan van der Werf 02bd38cfb1 Merge if constructs 2018-08-15 18:45:37 +02:00
Nathan van der Werf 3a918ad200 Remove "null" assignments 2018-08-15 18:33:24 +02:00
Nathan van der Werf 742a5f415b Remove unused imports 2018-08-15 18:27:36 +02:00
Arthur Kushman bbc33710c1 >= PHP7.0 refactoring (#3343)
* Fix loosly comparison to strict + argument types and return types for >=7.0
* Change hard-coded strings to ::class, 
* Fix unit-tests failures - some relative to 7.0 phpunit env deployment
* Fix exception string + format return types
* Change string representation of new classes in traceLog to ::class
Credit to @arthurkushman
2018-01-12 00:23:20 -06:00
Luke Towers 7830f89fa9 Fixing typos 2017-10-08 12:52:03 -06:00
Luke Towers c2f204008b Moved the MediaManager widget from the CMS module to the System module 2017-09-27 22:23:58 -06:00
Tschallacka b152663ff5 Attribute values for < and > and '' should be written als &lt; &gt; and &quot;(when enclosed with double quotes for attribute delimters) (#3043) 2017-08-29 10:29:48 -06:00
Luke Towers 9745b3ba75 Compiled assets 2017-08-05 18:11:40 -06:00
Luke Towers 0b7170ac26 Add support for sorting direction to the MediaManager (#3007)
* Remove redundant returns

`$this->putSession()` in `Backend\Traits\SessionMaker` doesn't return anything, and the return values of these methods are not used; so returning the value of `putSession()` in these methods is redundant.

* Add support for sort direction to MediaLibrary

Adds support for switching the direction that item lists get sorted by the media library. This necessitates the changing of the default direction of Last Modified and Size to Ascending, previously their sorting direction was Descending while Title was sorted in Ascending order. This shouldn't change anything as the user still has the power to sort by either direction. Fully backwards compatible with any calls to `sortItemList`.

* Support sorting direction in the MediaManager widget

Adds further support for specifying a sorting direction to the MediaManager widget itself

* Display sorting direction options

* Improving styles for sorting direction

* Send sorting information to the MediaManager

* Add translations for sorting feature

* Removing strange ghost whitespace
2017-08-05 12:45:01 -06:00
Samuel Georges a2a7eec4f5 Rename methods in CollapsableWidget
The methods were far too generic. When a trait or behavior is used, it's usually a good include to include the name of the trait in the methods and properties it provides. This reduces the chance of a conflict with the implementing class.
2017-06-10 15:42:24 +10:00
Samuel Georges f020479b91 Move session logic to SessionMaker
This allows controller behaviors to access session utils
2017-06-10 04:58:29 +10:00
Samuel Georges f7d0d394f5 Merge pull request #2881 from gergo85/patch-3
Typo
2017-06-06 20:21:59 +10:00
Samuel Georges bda98e7353 Selectable box and fancy breadcrumb 2017-06-05 17:35:15 +10:00
Samuel Georges e2781c5fdf URL -> Url 2017-06-02 23:34:50 +10:00
Samuel Georges 3be6dafa6b Fixes int folder name showing as 0
Fixes #2902
Code dusting
2017-06-02 20:16:26 +10:00
Samuel Georges f0df1f458b Merge branch 'develop' into l55upgrade
Conflicts:
	modules/system/assets/ui/storm.css
2017-05-27 22:24:57 +10:00
Samuel Georges cefa19af7d Backend UI improvements 2017-05-20 20:00:24 +10:00
Szabó Gergő 04e1f6e62e Typo
It is low priority changes. Yesterday I found them too, when I fixed the array index name issue.
2017-05-20 11:54:55 +02:00
Samuel Georges aa393dc54b Backend style improvements
This should make Windows PCs look a little nicer, albeit inconsistent with others (Sergoe UI is unique). If it's good enough for GitHub, then it's good enough for October.
All text shadows have been stripped, along with some box shading. They were barely noticeable and should speed up the UI.
2017-05-20 17:37:58 +10:00
Szabó Gergő c597563145 Fixed spaces 2017-05-19 11:29:19 +02:00
Samuel Georges 4d1bec860d thumbnailDirectory -> thumbFolder 2017-05-16 08:47:15 +10:00
Luke Towers 21d4f683c3 Support custom thumbnail directory
This enables support for edge cases that require custom thumbnail directories (such as requiring authentication to view generated thumbnails).
2017-05-14 22:41:31 -06:00
Luke Towers 7a820f3c43 Remove reference to hardcoded media path
Replaces the reference to a hardcoded `/media` path when generating a local temp file path to utilize the folder name as set in `cms.storage.media.folder`.
2017-05-14 22:28:08 -06:00
Luke Towers 0f04afbea4 Recompile mediamanager assets to include the fix 2017-05-14 19:34:50 -06:00
Luke Towers 84ee4f2679 Fix for #2765
Actual changes are in `MediaManager.prototype.deleteConfirmation`, apologies for the trailing whitespace removals, my editor auto does that and I didn't feel like removing it since there shouldn't really be trailing whitespace anyways.

Fixes #2675 (and probably other potential oopsies) by skipping over the "return to parent" item in the deletion handling method. The "return to parent" item contains a reference to the folder above the current folder, which could potentially cause the entire media folder to be deleted; and would certainly remove a lot more than actually intended.
2017-05-14 19:32:57 -06:00
Samuel Georges 349851dd11 Partials, pages and content now support drag'n'drop 2017-04-28 23:37:50 +10:00
Quezler cc17b679f1 Code dusting (#2826)
Code cleaning according to PSR-2 w/ exemptions (mostly dust).
2017-04-24 21:38:19 +10:00
Samuel Georges 27062ddfa0 Fixes folder creation and rename in asset list 2017-04-14 08:07:11 +10:00
Samuel Georges 9df40c07b8 Move extension validation to files only 2017-04-13 09:37:49 +10:00
Samuel Georges 433cf1d504 Additional security fixes 2017-04-10 16:02:05 +10:00
Samuel Georges 24c8b4368a Various security and UI fixes
The Media Manager now uses a white list approach to blocking files, we have been advised that the blacklist approach is too fragile and we agree.
Asset List and Media Manager now use $.oc.alert when displaying errors
2017-04-09 08:00:56 +10:00
Samuel Georges b841f9e066 {@inheritDoc} -> @inheritDoc 2017-03-16 06:26:14 +11:00
Samuel Georges d642605f87 Remove old fix and spruce up code 2017-03-04 15:23:12 +11:00
Samuel Georges 09085c5e03 Add explanation - Refs #2674 2017-02-15 05:51:30 +11:00
Luke Towers 4bb0f216f9 Merge pull request #2674 from tschallacka/IIS-getrealpath-fix
Fix for get realPath on IIS.
2017-02-14 12:31:40 -06:00
tschallacka 65247c4ce2 Fix for get realPath on IIS.
Sometimes getRealPath is empty when requested on IIS and needs to be rebuilt manually.
2017-02-14 09:22:34 +01:00
Samuel Georges cc1a67373c Add title to template list
Makes it easier to read longer template descriptions
2017-02-08 05:44:04 +11:00
Samuel Georges 8b71385481 Removed "before" events
There is no use case for them (yet)
Refs #2628
2017-01-30 08:33:32 +11:00