Commit Graph

632 Commits

Author SHA1 Message Date
Philipp Fehr 9dc54baddd Fix race condition when clearing recordfinder value (#4802)
Credit to @TheFehr. Fixes #4800.
2019-12-04 10:14:19 -06:00
Luke Towers 85fadbfef3 Check user permission for the mediafinder formwidget.
Fixes #4216. Replaces #4669. Credit to @gergo85.
2019-11-12 12:32:17 -06:00
Tomasz Strojny 8fb9c59ee1 Removed double checking if file is protected in FileUpload widget (#4753)
Credit to @tomaszstrojny. Cleanup from 4f7c5cc1e7.
2019-11-11 12:34:58 -06:00
Ben Thomson e97057246a
Fix empty Richeditor class lists from breaking widget (#4725) 2019-11-06 17:44:46 +08:00
Luke Towers fa93781645 Added ability to filter down the permissions presented by the PermissionEditor
You can now specify an array of "availablePermissions" to the PermissionEditor FormWidget that it will use to further down the list of permissions that are up for managment by the current user.
2019-10-15 17:37:59 -06:00
Luke Towers a69c76116f Added support for mode: switch to the PermissionEditor formwidget 2019-10-15 16:46:02 -06:00
Luke Towers 5862683a7a
Trigger change event on clearing recordfinder
Fixes #3591.
2019-10-13 06:15:19 -06:00
Luke Towers 9ac292d921
Merge pull request #4690 from pkarecki/master
Credit to @pkarecki
2019-10-11 12:46:01 -06:00
Piotr Karecki 06b7031131
Move prompt to lang
Move default prompt text to i18n file.
2019-10-11 20:12:08 +02:00
Luke Towers e246427463 Provide system.assets.beforeAddAsset event to modify asset attributes
Fixes octobercms/october#4611 (when combined with a PR to https://github.com/heathdutton/cloudflare)
Related: octobercms/october#4092, octobercms/october#3841, octobercms/october#3839
2019-10-09 11:51:06 -06:00
Luke Towers 96e335aebc
Fix #3415, #4672 (#4674)
Handle child FormWidgets making AJAX requests outside of the repeater's form container. Note that this won't pass on the state of the repeater item as it exists on the webpage because that information won't be sent to the server in an AJAX request sent from outside of the repeater's form container unless the FormWidget sending the orphaned request specifically includes that data in their request, in which case the regular handling will kick in and initialize the widget properly. A discussion should be had whether this fix makes sense to be done in the Repeater FormWidget or if we should force FormWidgets to have the responsibility of initializing their parent repeaters if they're going to be making orphaned AJAX requests.

Should fix #3415, #4672.
Related: octoberrain/test-plugin#78
2019-10-09 08:08:21 -06:00
Ben Thomson 970cc4550c
Improve internal docs for DataTable callback handler
- Changes parameters to match their intended data.
- Updates docblock
- Minor code cleanup

Refs: https://github.com/octobercms/october/issues/4664#issuecomment-539028664
2019-10-07 22:19:13 +08:00
Harmen Janssen 83d14c8503 Add support for order option on relation FormWidget (#4654)
Credit to @harmenjanssen. Documented in https://github.com/octobercms/docs/pull/406
2019-10-06 00:24:31 -06:00
Samuel Georges 52e2a838eb Fixes typo, recompile assets 2019-09-11 21:42:02 +10:00
Samuel Georges 3291e07191
Update Deprecated code in October into (event.key) (#4489)
Update Deprecated code in October into (event.key)
2019-09-11 21:35:18 +10:00
Samuel Georges 31145a3eb7 Peer review visibility changes
It makes more sense to use a consistent UI for all modes, the CSS is cleaner as a result. The code editor toolbar has been moved to the bottom across all instances. This is favourable to it bleeding outside of its perimeter.

Refs #3947
Refs #3948
2019-09-11 20:54:14 +10:00
Samuel Georges 96537033c8 Recompile assets 2019-09-11 20:02:43 +10:00
Ayumi Hamasaki 6942e38615 Remove the IE5 - IE7 Holly Hack support (#4594)
Credit to @ayumihamsaki
2019-09-04 09:32:29 -06:00
Ayumi Hamasaki 92e975ffa3 Make the Code editor fullscreen button easier to see (#4546)
Credit to @ayumihamsaki
2019-09-03 11:13:41 -06:00
Luke Towers de3f8142fb Support multiple instances of the PermissionEditor on a single page 2019-08-29 17:51:52 -06:00
Dan Harrin 3365820178 Use selected dropdown item as repeater title (#4544)
Credit to @DanHarrin. Initial implementation by @MattPurland. Finishes https://github.com/octobercms/october/pull/2956
2019-08-16 16:13:35 +08:00
Ayumi Hamasaki 7aae3f1ef8 Upload vendor file Spectrum V1.8.0 (#4536)
Credit to @ayumihamsaki
2019-08-15 10:04:59 -06:00
Luke Towers 36ab42aa24 Ensure the the TagList FormWidget is respecting relationship constraints (conditions & scope) 2019-08-14 19:58:42 -06:00
Luke Towers b75d0af966 Improve support for previewMode in Repeaters & NestedForms
Fixes #4521
2019-08-10 09:28:01 -06:00
Ben Thomson b5a3c64bf1
Fix "widget not bound to controller" error for nested repeaters (#4434)
Since repeaters have no value by themselves, a repeater that contains only another repeater was throwing a "widget not bound to controller" exception when adding a new item - the repeater item processing was not creating a form widget for the inner repeater on load, or in an AJAX call. This fix specifically checks if a child repeater has called for a new item, and if so and the current repeater has no value for this particular item, it will add a "stub" form widget to correctly bind the widget.

Fixes #4344.
2019-08-07 22:44:31 +08:00
Ayumi Hamasaki 5e18655ae9 Fix Rich Editor focus to fill the full height of the container (#4485)
Credit to @ayumihamsaki.
2019-07-30 09:04:38 +08:00
Luke Towers d8cd45163d Fixed the focus outline for no results on the CodeEditor search box. Credit to @ayumihamsaki. Replaces #4483. Fixes #4482. 2019-07-26 15:05:07 -06:00
Ben Thomson a7bc442df5
Pass through enableDefaults config to nested forms
This should allow default values to be used in nested form fields within new repeater items.

Fixes #4380.
2019-07-23 11:20:18 +08:00
Ben Thomson a59d3b83eb Code quality clean up (#4449)
Credit to @bennothommo
2019-07-18 08:50:37 -06:00
webmaxx cc7d595fff Added `maxFilesize` option to the `FileUpload` FormWidget (#4077)
Credit to @webmaxx
2019-07-18 08:48:31 -06:00
Anita e9665ab551 Fix layout of colorpicker for no custom color selected (#4457)
Credit to @anitaeisenhaber
2019-07-17 14:54:02 -06:00
Ayumi Hamasaki 23282bbaa6 Accessibility enhancement for code editor icons (#4395)
Credit to @ayumihamsaki. Fixes #4392
2019-07-08 10:51:25 +03:00
Ben Thomson 3eac21219f
Clean up index functionality in Repeater widget (#4424)
- Remove $indexCount property, as it is no longer needed
- Determine highest key number in data, and increment when adding item
- Remove some old code and dependencies

Fixes #4402.
2019-06-29 13:42:45 +08:00
Rike-cz acf4577255 Add preview mode for taglist widget (#4349)
Credit to @Rike-cz.
2019-06-19 08:22:36 +08:00
Marc Jauvin 30f4d4c5af Fix: Restore FroalaEditor extendability (#4356)
Credit to @mjauvin.
2019-06-03 14:15:47 +03:00
Samuel Georges 1ad43554d4 Compile rich editor with inline style and class
Fixes #3883
2019-06-01 14:43:07 +10:00
Luke Towers 7590dfd30f Respect ignoreTimezone in the datepicker 'date' mode. 2019-05-14 13:09:48 -06:00
Luke Towers bcd5156497
Merge pull request #4336 from octobercms/master
Fix group index mapping in Repeater widget (#4334)
2019-05-14 12:29:09 -06:00
datune a8d9dcf985 Fix group index mapping in Repeater widget (#4334)
Fixes a bug which causes grouped repeaters to lose data when repeater items are re-ordered and saved, due to the data indexes not being correctly mapped to the corresponding form widget.

Credit to @datune.
2019-05-14 23:34:12 +08:00
Marc Jauvin 8448d4b972 Fix media manager access (#4305) 2019-05-10 20:59:57 +03:00
Alexander Guth ee8287e598 Add "onUpload" AJAX handler to FileUpload widget (#4311)
Run an AJAX handler on uploading and processing a file as opposed to using a post() data check in the widget initialization, as the widget may initialize several times in certain circumstances - eg. inside a relation widget.

Credit to @alxy. Refs: https://github.com/octobercms/october/issues/4300
2019-05-07 11:44:25 +08:00
Samuel Georges 3e5449c855 Include CSRF token in uploads to richeditor
Fixes #4302
2019-04-30 16:27:55 +10:00
Samuel Georges 7a4052be60 Recompile assets
build-oc-plugins.js -> build-plugins.js
Refs #4075
2019-04-30 16:24:00 +10:00
Marc Jauvin edf6e135e2 Seperate proprietary and ocms js asset bundles (#4075)
* register a new bundle

* add the new bundle target asset

* remove the non-proprietary source file from the proprietary bundle definition

* create a new build target for the non-proprietary asset files

* remove the non-proprietary code from the compiled proprietary asset

* add compiled and minified build-ocms file

* add missing line at the end

* use better asset file names
2019-04-30 16:19:17 +10:00
Patrik Nemeček b345191b3f Add escaping of values to more backend fields (#4296)
Credit to @patriknemecek
2019-04-26 12:05:08 -06:00
Serge da8073c945 Fixed minor visual glitch in the Insert URL popup of Froala (#3993)
Credit to @Lavrushin.
2019-04-19 16:06:47 -06:00
Tom 04bf359d8c Fix for RichEditor root page links being returned with empty hrefs. (#3085)
Fixes issue found in https://github.com/octobercms/october/issues/3064#issuecomment-326008148, specifically 2nd bullet point. Credit to @joltmode.
2019-04-19 12:46:13 -06:00
Luke Towers ae26f4abe0 Peer review 6c54498e0a 2019-04-18 23:31:02 -06:00
Marc Jauvin ed79877054 Reuse formWidget model (#4273)
Credit to @mjauvin. Related: https://github.com/octobercms/october/pull/4193
2019-04-18 12:44:05 -06:00
Anže Časar 41a634bb2b Fix mediafinder error message (#4269)
Related: 6593651331
2019-04-17 18:54:43 -06:00