Commit Graph

532 Commits

Author SHA1 Message Date
Samuel Georges 5cc327c45c
Merge pull request #3690 from nathan-van-der-werf/feature/cleanup
Code cleanups
2018-08-30 13:12:42 +10:00
Samuel Georges 6099096e5d Increase visibility of close button
Fixes #3723
2018-08-30 12:40:45 +10:00
Nathan van der Werf 8fd16d4db6
Merge branch 'develop' into feature/cleanup
# Conflicts:
#	modules/backend/formwidgets/FileUpload.php
2018-08-24 19:52:54 +02:00
Nathan van der Werf 0f0d108da0
Remove unused imports 2018-08-24 19:51:59 +02:00
Nathan van der Werf 66fa03f17e
Revert "Remove unused imports"
This reverts commit 742a5f415b.
2018-08-24 19:40:40 +02:00
Szabó Gergő e46eff8a26 Remove hard height constraint from previewing uploaded images (#3718)
Fixes #3698. Credit to @gergo85
2018-08-23 09:32:18 -06:00
Luke Towers fd4ee47065 Improved repeater item collapse button when remove button not present 2018-08-22 21:06:06 -06:00
Luke Towers 29c0c8c33d Improvements to Repeater form widget styling
Improved the styling of the Repeater form widget, made it easier to distinguish between individual repeater items
2018-08-22 20:51:26 -06:00
Samuel Georges bf841b4340 Minor peer review 2018-08-21 13:24:59 +10:00
vanmil 38bf854051 Add ability to use model method to define availableColors (#3704)
Credit to @vanmil. Documented in https://github.com/octobercms/docs/pull/314
2018-08-20 08:45:26 -06:00
Nathan van der Werf a3d7a028b4 Replace is_null with "=== null" comparison 2018-08-15 18:54:46 +02:00
Nathan van der Werf bc17975634 Remove alias functions 2018-08-15 18:51:25 +02:00
Nathan van der Werf 123145fd54 Remove unnecessary parentheses 2018-08-15 18:49:52 +02:00
Nathan van der Werf 3a918ad200 Remove "null" assignments 2018-08-15 18:33:24 +02:00
Nathan van der Werf 742a5f415b Remove unused imports 2018-08-15 18:27:36 +02:00
Luke Towers cbed54a263 Implemented minItems repeater property on client & server
Also implemented maxItems on server (previously only client). Fixes https://github.com/octobercms/october/issues/3668
2018-08-12 01:33:51 -06:00
Luke Towers 6774920003 Finish implementing titleFrom option for Repeaters
Ref: e7609aa5e8
2018-08-11 20:27:53 -06:00
vanmil 4cdbf2a051 Add customization of froala lineBreaker tags (#3687)
Credit to @vanmil
2018-08-11 13:33:34 -06:00
Michał Płodowski 68ee471d39 Add showWeekNumbers option to datepicker (#3637)
Fixes #3634. Credit to @mplodowski
2018-07-12 18:10:24 -04:00
Luke Towers 0086a47b80 Add attachOnUpload option to FileUpload formwidget
Fixes #3501
2018-06-04 16:22:23 -06:00
Viamage 667b82e6ce Replace keyup listener with input listener (#3567)
Fixes #1270. Credit to @viamage
2018-05-30 20:26:38 -06:00
Ayumi Hamasaki 026ae1e15f Fix Scrolling bug (#3547)
Fixes #3542
2018-05-13 16:32:12 -06:00
Joey 541f0a78f1 Fix for missing _group field when saving data from a nested group repeater (#3523)
Fixes #3067. Credit to @Narkoleptika. Thanks to @petehalverson for his docker container work for replicating.
2018-04-26 00:13:28 -06:00
Luke Towers 422a99770c
Attach uploaded files directly to parent if exists
If the parent of the file attachment relationship already exists, then attach the file directly to it in this request instead of going through deferred bindings. Will continue to attach files through deferred binding if the parent relation doesn't exist.
2018-03-09 23:47:16 -06:00
Samuel Georges 45f1714a03 Added key mode to taglist form widget
Alternative implementation #2958
Fixes #2958
2018-01-13 20:49:31 +11:00
Alexander Guth 1389f77390 Fix 'illegal string offset' warning (#3331)
Credit to @alxy 
In case a new administrator is created by a non-superuser and no permission is set directly on creation, `permissions` is not initialized correctly. Thus, when the non-superuser tries to acceess `$this->model->permissions` it is not populated with an empty array as expected.

I have actually no clue why it does work for superusers however, as they should certainly experience the same issue, but this is not the case.
2017-12-31 11:03:07 -06:00
Jim Cottrell 0d0be9d0e5 Trigger fileupload form field change on file removal (#3319)
Credit to @jimcottrell
2017-12-22 15:33:21 -06:00
Steve Mortimer 7c20e32c47 Allow non-superusers with manage_users to set permissions back to inherit
Fixes #3274
2017-11-30 15:01:43 -06:00
Luke Towers d164145229
Fixes #2613
This fixes #2613 by reloading the form widgets with the modified data after `model.filterFields`. **NOTE**: `$this->processExistingItems()` isn't simply just moved to `prepareVars()` because that messes up the adding new repeater item functionality by repeating the content from the fields for the last item in that group that already exists on the repeater.
2017-11-01 14:18:41 -06:00
Fl0Cri ec8dd56121 Fix richeditor popup z-index inside modal (#3194)
Fixes #3098. Related: #3111, #3113, #3114
2017-10-24 12:35:31 -06:00
Samuel Georges 669a4cee6e Merge branch 'maintenance-mediamanager' into develop 2017-10-16 17:56:34 +11:00
Samuel Georges 2a1234d21c Update MM lang refs 2017-10-16 17:52:50 +11:00
Floris Koch 161d81a192 Update _repeater_item.htm (#3149)
Allows using language files for group titles.
2017-10-03 10:15:29 -06:00
Luke Towers d14f1fec0f Moved MediaFinder formwidget from the CMS module to the System module 2017-09-27 22:30:53 -06:00
Fl0Cri d7b0e55ceb Fixes broken richeditor z-index inside and outside of a popup (#3113)
Fixes #3098, #3111. Credit to @Fl0Cri
2017-09-14 15:17:31 -06:00
Luke Towers 9565565865 Add ignoreTimezone option to datepicker field and column types.
Adds the ability to specify an `ignoreTimezone: true` option on the config for a datepicker form widget or date column type. This will ignore both October's and the backend user's timezone settings to display the date exactly as it is stored.
2017-09-10 22:39:15 -06:00
TimFoerster ead70c43f3 changing z-index of richeditor (#3099)
Changed z-index of the richeditor to prevent hidden popups.
Fixes #3098
2017-09-07 08:36:50 -06:00
Tschallacka c97d29fe4f Remove unused reference (#3045) 2017-08-17 14:00:43 -06:00
Samuel Georges b732f70c59 Adds support for single file uploads
...when used without a form tag
Refs #2857
2017-07-29 09:21:49 +10:00
Samuel Georges 28c30daa4f Use safe md parsing for mail
Ensure backward compatibility by disabling indented code blocks for mail templates
Tweak mail brand colors to match October
2017-07-22 19:01:20 +10:00
Samuel Georges 8e0279e45e Trigger color picker change event 2017-07-22 17:18:45 +10:00
Samuel Georges cd6a7c75dc Refresh colorpicker form widget
Replace colpick with spectrum plugin
Recompile client lang
2017-07-22 11:40:59 +10:00
Samuel Georges d7117f9cb2 Stetch + size improvements 2017-07-15 19:53:08 +10:00
Samuel Georges 0aa1fa96fb Fixes non-split stretch mode 2017-07-15 19:10:01 +10:00
Samuel Georges 4fd1ca824f Introduce concept of system roles
These are roles defined by a special API code, once a system role code is detected, the role becomes locked and its permissions are sourced from the AuthManager. All permissions are granted to system roles by default, unless otherwise specified. This should make it easier to create client accounts as "Publishers", hiding developer tools like the CMS and Builder plugins by default.
2017-07-13 19:29:50 +10:00
Samuel Georges 358a6337df We probably don't need to call this twice
Refs f8d9667f0e
2017-07-13 19:15:47 +10:00
Samuel Georges 1db67af8e8 Merge remote-tracking branch 'remotes/origin/develop' into l55upgrade
Conflicts:
	modules/system/lang/en/lang.php
2017-07-11 10:48:54 +10:00
Luke Towers 950c341c49 Prevent privilege escalation from crafted requests
Follow up to 2046efb51d.
The previous commit prevented users from visually managing permissions that they themselves didn't have access to, this follow-up commit enforces that limitation serverside to defend against crafted privilege escalation attacks by authenticated users.
2017-07-10 18:36:43 -06:00
Luke Towers 2046efb51d Prevent users from granting permissions they don't have
Prevents users from granting permissions that they themselves do not have. Fixes #1673, and is a partial solution to #2367. However, this still does not address the issue of being able to assign / manage groups that have permissions that the user doing the management does not themselves have. That will have to be addressed separately as a part of #2367.
2017-07-09 20:24:17 -06:00
Luke Towers 056a37fce4 Fix repeater title generation in readOnly mode
Refs: 2a16847724
2017-07-09 13:06:23 -06:00