Commit Graph

38 Commits

Author SHA1 Message Date
Dan Harrin 9521dd795c Minor Formatting Corrections in Usage Comments (#4541)
Credit to @DanHarrin
2019-08-15 09:14:54 -06:00
Ben Thomson a59d3b83eb Code quality clean up (#4449)
Credit to @bennothommo
2019-07-18 08:50:37 -06:00
Nathan van der Werf 8fd16d4db6
Merge branch 'develop' into feature/cleanup
# Conflicts:
#	modules/backend/formwidgets/FileUpload.php
2018-08-24 19:52:54 +02:00
Nathan van der Werf 0f0d108da0
Remove unused imports 2018-08-24 19:51:59 +02:00
Nathan van der Werf 66fa03f17e
Revert "Remove unused imports"
This reverts commit 742a5f415b.
2018-08-24 19:40:40 +02:00
Luke Towers 1032fd0cc1 Added more inline API event docs:
Added docs for:
cms.component.beforeRunAjaxHandler
cms.component.runAjaxHandler

Improved docs for:
cms.ajax.beforeRunHandler
2018-08-18 09:05:38 -06:00
Nathan van der Werf 742a5f415b Remove unused imports 2018-08-15 18:27:36 +02:00
Samuel Georges 2a0a91486c Logic error - fixes #2654 2017-05-16 07:24:07 +10:00
Quezler cc17b679f1 Code dusting (#2826)
Code cleaning according to PSR-2 w/ exemptions (mostly dust).
2017-04-24 21:38:19 +10:00
Samuel Georges 0a2b343047 Simplify system events
This pipes all event calls through a new EventEmitter trait, which substitutes the October Rain event emitter trait. The view event has been moved to this trait also.
Pass some variables by reference to allow multi-extension.
Fixes #2420
2016-12-10 09:02:06 +11:00
Samuel Georges 97daebfa9e Use BadMethodCallException for graceful failure (Twig only)
Fixes #1571
This also fixes method inheritance for behaviors by using parent::__call() to look for any methods provided by extensions, catches the exception, then continues with BAU
2016-02-13 15:23:53 +11:00
Daniel Müller 01c63d6e32 fixed some PHPDocs
removed my prior changes to the code behaviour

removed errorous PHPDocs

fixed some PHPDocs

removed my prior changes to the code behaviour

removed errorous PHPDocs
2015-12-12 11:34:27 +11:00
Vojta Svoboda 16eb704793 Add missing PHPDoc @return tag 2015-10-17 09:17:37 +11:00
Samuel Georges 51c7878e8f Fixes rendering 2 shared component partials nukes context 2015-08-30 11:56:44 +10:00
Samuel Georges 8c6a58981e Roll back the changes from #852 in the name of KISS
The page vars are just that, view variables, if used incorrectly (relaxed) they can leech out
2015-06-17 18:50:51 +10:00
Samuel Georges 8b3ab93786 Component variables set with `$this->page` no longer leech in to other component partials.
Fixes #852
2015-05-16 09:29:27 +10:00
Samuel Georges 7145aac457 Prepare for CDN, config rename cms.plugins|themes|uploadsDir -> cms.plugins|themes|uploadsPath
Deprecate data-trigger-type on triggerapi
Fixes ref to Util class
2015-02-17 20:58:38 +11:00
Samuel Georges 9927568d98 Removed the deprecated propertyOrParam() 2015-02-14 16:31:56 +11:00
Samuel Georges 6a2f64757b *** REMOVED ALL DEPRECATED CODE ** 2015-02-14 14:11:25 +11:00
Samuel Georges fbf46519b4 Implement plugins_path() usage 2015-02-07 15:37:07 +11:00
Samuel Georges df3e66246f Fixes #839 - When rendering partials from component PHP code, be firm about the context 2015-01-03 15:15:57 +11:00
Samuel Georges fa250927d0 New events for components: runAjaxHandler + beforeRunAjaxHandler 2015-01-03 12:51:09 +11:00
Samuel Georges 3170dd61ea Add new methods propertyName() and paramName() to Component base class for accessing names of external properties. 2014-12-16 15:41:50 +11:00
Sam Georges 03e9f48333 Deprecate propertyOrParam 2014-10-31 20:01:17 +11:00
alekseybobkov 9a05a408c9 Added support for components in partials 2014-10-29 22:12:42 -07:00
Stefan Talen 202e8869b1 Updating modules/cms/classes 2014-10-11 01:22:03 +02:00
Sam Georges 37291a0c63 Throw ApplicationException when AJAX handler not found 2014-08-13 07:52:47 +10:00
alekseybobkov 2018215c44 Implemented the view bag. Minor UX fix. 2014-08-06 22:42:09 +11:00
Sam Georges fdac3416e1 Added new layout and page method `onInit()` called after components are initialized and before AJAX requests are processed. 2014-07-07 17:39:22 +10:00
alekseybobkov 5488429fe4 Fixed the unknown component caching problem. Added the unknown component handling to the back-end. AJAX request can now be stopped with preventing default action in the oc.beforeRequest event. Fixes #46. 2014-06-26 17:09:25 +11:00
Sam Georges eccf96222d Components now support a shared /components/partials directory used as a fallback when a partial is not found. 2014-06-24 16:08:02 +10:00
Sam Georges 0f082bd160 Comment out code until determined if it is needed 2014-05-27 13:14:02 +10:00
Sam Georges 9b542efe6f Add complex page link handling to ComponentBase 2014-05-25 00:57:10 +10:00
Sam Georges a89eda62cf Add notes 2014-05-24 22:03:20 +10:00
Sam Georges e2fa45e264 Adds new override for components, onInit() 2014-05-24 21:59:30 +10:00
Sam Georges 4951393986 Fixes bug in propertyOrParam() 2014-05-24 21:26:48 +10:00
Sam Georges 6788a32e8c Components have a new override method `onRender()` called before a component is rendered.
The `{% component %} tag now supports passing parameters that override the component properties when they are rendered.
Calling `addJs()` and `addCss()` in components without a starting slash (/) will now reference the component directory, instead of the theme.
2014-05-22 20:27:44 +10:00
Sam Georges 71a5dd67ab Welcome to the world, October :-) 2014-05-14 23:24:20 +10:00