From ef36399cf758d8866cb31267571a28e9bb52bb57 Mon Sep 17 00:00:00 2001
From: Luke Towers <github@luketowers.ca>
Date: Fri, 19 Jun 2020 23:54:44 -0600
Subject: [PATCH] Improve error handling for invalid counter properties on
 backend menu items

---
 modules/backend/classes/NavigationManager.php | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/modules/backend/classes/NavigationManager.php b/modules/backend/classes/NavigationManager.php
index 4fb31c9aa..ee57c1666 100644
--- a/modules/backend/classes/NavigationManager.php
+++ b/modules/backend/classes/NavigationManager.php
@@ -373,7 +373,7 @@ class NavigationManager
                 }
             }
 
-            if (empty($item->counter)) {
+            if (empty($item->counter) || !is_numeric($item->counter)) {
                 $item->counter = null;
             }
         }
@@ -421,6 +421,9 @@ class NavigationManager
                     $item->counter = null;
                 }
             }
+            if (!is_null($item->counter) && !is_numeric($item->counter)) {
+                throw new SystemException("The menu item {$activeItem->code}.{$item->code}'s counter property is invalid. Check to make sure it's numeric or callable. Value: " . var_export($item->counter, true));
+            }
         }
 
         return $items;