TPS
/
ORIENT
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Get correct model when not using ID for "keyFrom" in Record Finder (#4977) 

getLoadValue() was previously using the find method for getting the selected model on load when not using the Record Finder in relation mode.

This means it was searching by the primary key, regardless of whether the keyFrom setting on the Record Finder widget was changed. This has the effect of the keyFrom setting being correctly used to determine the value of the record finder field when a model is selected, but the widget being unable to find the model when it refreshes or reloads.

This change instead searches for the field's value in the column specified for the keyFrom setting, allowing us to use a different identifying column for loading the selected record.
This commit is contained in:
Ben Thomson 2020-03-13 07:47:01 +08:00 committed by GitHub
parent 6c391b5e82
commit cca8da2af3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/backend/formwidgets/RecordFinder.php
View File

@ -252,7 +252,7 @@ class RecordFinder extends FormWidgetBase
$value = $model->{$attribute};
}
} else {
$value = $this->modelClass::find(parent::getLoadValue());
$value = $this->modelClass::where($this->keyFrom, parent::getLoadValue())->first();
}
return $value;