TPS
/
ORIENT
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removes redundant code 

The form widget label and widgetDetails() method was intended for use by the Builder plugin, since it ended up using its own internal registration system, this is not used anywhere so is removed.

Refs https://github.com/octobercms/docs/issues/200
This commit is contained in:
Samuel Georges 2016-11-01 08:14:25 +11:00
parent 943868e242
commit bc165078de
4 changed files with 17 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
modules/backend/ServiceProvider.php
View File

@ -151,54 +151,18 @@ class ServiceProvider extends ModuleServiceProvider
protected function registerBackendWidgets()
{
WidgetManager::instance()->registerFormWidgets(function ($manager) {
$manager->registerFormWidget('Backend\FormWidgets\CodeEditor', [
'label' => 'Code editor',
'code' => 'codeeditor'
]);
$manager->registerFormWidget('Backend\FormWidgets\RichEditor', [
'label' => 'Rich editor',
'code' => 'richeditor'
]);
$manager->registerFormWidget('Backend\FormWidgets\MarkdownEditor', [
'label' => 'Markdown editor',
'code' => 'markdown'
]);
$manager->registerFormWidget('Backend\FormWidgets\FileUpload', [
'label' => 'File uploader',
'code' => 'fileupload'
]);
$manager->registerFormWidget('Backend\FormWidgets\Relation', [
'label' => 'Relationship',
'code' => 'relation'
]);
$manager->registerFormWidget('Backend\FormWidgets\DatePicker', [
'label' => 'Date picker',
'code' => 'datepicker'
]);
$manager->registerFormWidget('Backend\FormWidgets\TimePicker', [
'label' => 'Time picker',
'code' => 'timepicker'
]);
$manager->registerFormWidget('Backend\FormWidgets\ColorPicker', [
'label' => 'Color picker',
'code' => 'colorpicker'
]);
$manager->registerFormWidget('Backend\FormWidgets\DataTable', [
'label' => 'Data Table',
'code' => 'datatable'
]);
$manager->registerFormWidget('Backend\FormWidgets\RecordFinder', [
'label' => 'Record Finder',
'code' => 'recordfinder'
]);
$manager->registerFormWidget('Backend\FormWidgets\Repeater', [
'label' => 'Repeater',
'code' => 'repeater'
]);
$manager->registerFormWidget('Backend\FormWidgets\TagList', [
'label' => 'Tag List',
'code' => 'taglist'
]);
$manager->registerFormWidget('Backend\FormWidgets\CodeEditor', 'codeeditor');
$manager->registerFormWidget('Backend\FormWidgets\RichEditor', 'richeditor');
$manager->registerFormWidget('Backend\FormWidgets\MarkdownEditor', 'markdown');
$manager->registerFormWidget('Backend\FormWidgets\FileUpload', 'fileupload');
$manager->registerFormWidget('Backend\FormWidgets\Relation', 'relation');
$manager->registerFormWidget('Backend\FormWidgets\DatePicker', 'datepicker');
$manager->registerFormWidget('Backend\FormWidgets\TimePicker', 'timepicker');
$manager->registerFormWidget('Backend\FormWidgets\ColorPicker', 'colorpicker');
$manager->registerFormWidget('Backend\FormWidgets\DataTable', 'datatable');
$manager->registerFormWidget('Backend\FormWidgets\RecordFinder', 'recordfinder');
$manager->registerFormWidget('Backend\FormWidgets\Repeater', 'repeater');
$manager->registerFormWidget('Backend\FormWidgets\TagList', 'taglist');
});
}

4
modules/backend/classes/WidgetManager.php
View File

@ -98,6 +98,10 @@ class WidgetManager
*/
public function registerFormWidget($className, $widgetInfo = null)
{
if (!is_array($widgetInfo)) {
$widgetInfo = ['code' => $widgetInfo];
}
$widgetCode = isset($widgetInfo['code']) ? $widgetInfo['code'] : null;
if (!$widgetCode) {

5
modules/cms/ServiceProvider.php
View File

@ -245,10 +245,7 @@ class ServiceProvider extends ModuleServiceProvider
{
WidgetManager::instance()->registerFormWidgets(function ($manager) {
$manager->registerFormWidget('Cms\FormWidgets\Components');
$manager->registerFormWidget('Cms\FormWidgets\MediaFinder', [
'label' => 'cms::lang.mediafinder.label',
'code' => 'mediafinder'
]);
$manager->registerFormWidget('Cms\FormWidgets\MediaFinder', 'mediafinder');
});
}

7
modules/cms/widgets/ComponentList.php
View File

@ -41,13 +41,6 @@ class ComponentList extends WidgetBase
]);
}
/**
* Returns information about this widget, including name and description.
*/
public function widgetDetails()
{
}
/*
* Event handlers
*/