From bc016adad74f55623306ff9915bdf21545967860 Mon Sep 17 00:00:00 2001 From: Samuel Georges Date: Sun, 28 Dec 2014 13:03:52 +1100 Subject: [PATCH] Rollback performance change to framework.js because it's broken (Submitting an invalid form in the backend will result in a page refresh, flash messaegs are suppressed) K.I.S.S > Performance + premature optimization is the root of all evil --- modules/system/assets/js/framework.js | 32 ++++----------------------- 1 file changed, 4 insertions(+), 28 deletions(-) diff --git a/modules/system/assets/js/framework.js b/modules/system/assets/js/framework.js index 593fc0729..7dfd3db97 100644 --- a/modules/system/assets/js/framework.js +++ b/modules/system/assets/js/framework.js @@ -366,34 +366,10 @@ if (window.jQuery === undefined) $(this).request() }) - document.addEventListener('click', function nativeClickListener(ev){ - // Faster native click listener. This implementation doesn't use - // jQuery until it's really necessary. - var target = ev.target ? ev.target : ev.srcElement - - if (target.getAttribute('data-request') == null) - return - - var tagName = target.tagName - if (tagName == 'A' || tagName == 'BUTTON') { - $(target).request() - return false; - } - - if (tagName == 'INPUT') { - var type = target.getAttribute('type').toLowerCase() - - if (type == 'button' || type == 'submit') { - $(target).request() - return false; - } - } - }); - - // $(document).on('click', 'a[data-request], button[data-request], input[type=button][data-request], input[type=submit][data-request]', function(){ - // $(this).request() - // return false - // }) + $(document).on('click', 'a[data-request], button[data-request], input[type=button][data-request], input[type=submit][data-request]', function(){ + $(this).request() + return false + }) $(document).on('keydown', 'input[type=text][data-request], input[type=submit][data-request], input[type=password][data-request]', function(e){ if (e.keyCode == 13) {