From b564e3178dee2449fddd0f5ca11dc0b91be53ca8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Szab=C3=B3=20Gerg=C5=91?= Date: Thu, 9 Aug 2018 15:39:37 +0200 Subject: [PATCH] Only add missing dependencies once (#3682) Only add missing dependencies to the list of missing dependencies once per dependency. Credit to @gergo85 --- modules/system/classes/PluginManager.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/modules/system/classes/PluginManager.php b/modules/system/classes/PluginManager.php index 926293ec0..4d7d6bc25 100644 --- a/modules/system/classes/PluginManager.php +++ b/modules/system/classes/PluginManager.php @@ -419,6 +419,7 @@ class PluginManager $parts = explode('\\', $namespace); $slice = array_slice($parts, 1, 2); $namespace = implode('.', $slice); + return $namespace; } @@ -596,7 +597,9 @@ class PluginManager continue; } - $missing[] = $require; + if (!in_array($require, $missing)) { + $missing[] = $require; + } } }