From ac98f70a2519a67f993e0b9a04fac4eea7877ab0 Mon Sep 17 00:00:00 2001
From: Ben Thomson <bennothommo@users.noreply.github.com>
Date: Thu, 11 Apr 2019 10:37:39 +0800
Subject: [PATCH] Revert reordering handler changes

---
 modules/backend/formwidgets/Repeater.php      |  5 ----
 .../repeater/assets/js/repeater.js            | 29 +------------------
 .../repeater/partials/_repeater.htm           |  1 -
 3 files changed, 1 insertion(+), 34 deletions(-)

diff --git a/modules/backend/formwidgets/Repeater.php b/modules/backend/formwidgets/Repeater.php
index fa69e371d..a8b7d7e21 100644
--- a/modules/backend/formwidgets/Repeater.php
+++ b/modules/backend/formwidgets/Repeater.php
@@ -316,11 +316,6 @@ class Repeater extends FormWidgetBase
         return $widget->onRefresh();
     }
 
-    public function onReorder()
-    {
-        // Handle reordering of repeater items
-    }
-
     //
     // Group mode
     //
diff --git a/modules/backend/formwidgets/repeater/assets/js/repeater.js b/modules/backend/formwidgets/repeater/assets/js/repeater.js
index f5b48ae46..32d2fdd5e 100644
--- a/modules/backend/formwidgets/repeater/assets/js/repeater.js
+++ b/modules/backend/formwidgets/repeater/assets/js/repeater.js
@@ -22,9 +22,6 @@
         this.$el       = $(element)
         this.$sortable = $(options.sortableContainer, this.$el)
 
-        // Sortable tracking
-        this.sortingStartIndex = null
-
         $.oc.foundation.controlUtils.markDisposable(element)
         Base.call(this)
         this.init()
@@ -35,7 +32,6 @@
 
     Repeater.DEFAULTS = {
         sortableHandle: '.repeater-item-handle',
-        sortableHandler: null,
         sortableContainer: 'ul.field-repeater-items',
         titleFrom: null,
         minItems: null,
@@ -81,9 +77,7 @@
     Repeater.prototype.bindSorting = function() {
         var sortableOptions = {
             handle: this.options.sortableHandle,
-            nested: false,
-            onDragStart: this.proxy(this.onSortStart),
-            onDrop: this.proxy(this.onSortStop)
+            nested: false
         }
 
         this.$sortable.sortable(sortableOptions)
@@ -230,27 +224,6 @@
         return defaultText
     }
 
-    Repeater.prototype.onSortStart = function($item, container, callback, event) {
-        this.sortingStartIndex = $item.index()
-
-        callback($item, container, callback, event)
-    }
-
-    Repeater.prototype.onSortStop = function($item, container, callback, event) {
-        var endIndex = $item.index()
-
-        if (this.options.sortableHandler) {
-            this.$el.request(this.options.sortableHandler, {
-                data: {
-                    _repeater_index: this.sortingStartIndex,
-                    _repeater_new_index: endIndex
-                }
-            })
-        }
-
-        callback($item, container, callback, event)
-    }
-
     // FIELD REPEATER PLUGIN DEFINITION
     // ============================
 
diff --git a/modules/backend/formwidgets/repeater/partials/_repeater.htm b/modules/backend/formwidgets/repeater/partials/_repeater.htm
index 2647b6ae5..995c42cd8 100644
--- a/modules/backend/formwidgets/repeater/partials/_repeater.htm
+++ b/modules/backend/formwidgets/repeater/partials/_repeater.htm
@@ -3,7 +3,6 @@
      <?= $titleFrom ? 'data-title-from="'.$titleFrom.'"' : '' ?>
      <?= $minItems ? 'data-min-items="'.$minItems.'"' : '' ?>
      <?= $maxItems ? 'data-max-items="'.$maxItems.'"' : '' ?>
-     data-sortable-handler="<?= $this->getEventHandler('onReorder') ?>"
      data-sortable-container="#<?= $this->getId('items') ?>"
      data-sortable-handle=".<?= $this->getId('items') ?>-handle">