TPS
/
ORIENT
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactoring tests (#3291)

This commit is contained in:
Gabriel Caruso 2018-01-07 23:55:53 -02:00 committed by Luke Towers
parent 55ff460895
commit aa14d77516
4 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/unit/backend/traits/WidgetMakerTest.php
View File

@ -41,7 +41,7 @@ class WidgetMakerTest extends TestCase
$maker = $this->traitObject;
$widget = $maker->makeWidget('Backend\Widgets\Search');
$this->assertTrue($widget instanceof \Backend\Widgets\Search);
$this->assertInstanceOf('Backend\Widgets\Search', $widget);
}
public function testMakeWidget()

10
tests/unit/cms/classes/RouterTest.php
View File

@ -103,7 +103,7 @@ class RouterTest extends TestCase
$parameters = $router->getParameters();
$this->assertNotEmpty($page);
$this->assertEquals('blog-post.htm', $page->getFileName());
$this->assertEquals(1, count($parameters));
$this->assertCount(1, $parameters);
$this->assertArrayHasKey('url_title', $parameters);
$this->assertEquals('my-post-title', $parameters['url_title']);
@ -112,7 +112,7 @@ class RouterTest extends TestCase
$parameters = $router->getParameters();
$this->assertNotEmpty($page);
$this->assertEquals('blog-post.htm', $page->getFileName());
$this->assertEquals(1, count($parameters));
$this->assertCount(1, $parameters);
$this->assertArrayHasKey('url_title', $parameters);
$this->assertEquals('my-post-title', $parameters['url_title']);
@ -120,7 +120,7 @@ class RouterTest extends TestCase
$parameters = $router->getParameters();
$this->assertNotEmpty($page);
$this->assertEquals('authors.htm', $page->getFileName());
$this->assertEquals(1, count($parameters));
$this->assertCount(1, $parameters);
$this->assertArrayHasKey('author_id', $parameters);
$this->assertEquals('no-author', $parameters['author_id']);
@ -134,7 +134,7 @@ class RouterTest extends TestCase
$parameters = $router->getParameters();
$this->assertNotEmpty($page);
$this->assertEquals('authors.htm', $page->getFileName());
$this->assertEquals(1, count($parameters));
$this->assertCount(1, $parameters);
$this->assertArrayHasKey('author_id', $parameters);
$this->assertEquals('44', $parameters['author_id']);
@ -142,7 +142,7 @@ class RouterTest extends TestCase
$parameters = $router->getParameters();
$this->assertNotEmpty($page);
$this->assertEquals('blog-archive.htm', $page->getFileName());
$this->assertEquals(1, count($parameters));
$this->assertCount(1, $parameters);
}
public function testFindPageFromSubdirectory()

2
tests/unit/cms/classes/ThemeTest.php
View File

@ -46,7 +46,7 @@ class ThemeTest extends TestCase
$this->assertInternalType('array', $pages);
$expectedPageNum = $this->countThemePages(base_path().'/tests/fixtures/themes/test/pages');
$this->assertEquals($expectedPageNum, count($pages));
$this->assertCount($expectedPageNum, $pages);
$this->assertInstanceOf('\Cms\Classes\Page', $pages[0]);
$this->assertNotEmpty($pages[0]->url);

12
tests/unit/system/classes/MarkupManagerTest.php
View File

@ -84,8 +84,8 @@ class MarkupManagerTest extends TestCase
$this->assertTrue($result);
$result = self::callProtectedMethod($manager, 'isWildCallable', [$callable, 'bar']);
$this->assertTrue(isset($result[0]));
$this->assertTrue(isset($result[1]));
$this->assertArrayHasKey(0, $result);
$this->assertArrayHasKey(1, $result);
$this->assertEquals('Class', $result[0]);
$this->assertEquals('foo_bar', $result[1]);
@ -94,8 +94,8 @@ class MarkupManagerTest extends TestCase
$this->assertTrue($result);
$result = self::callProtectedMethod($manager, 'isWildCallable', [$callable, 'Class']);
$this->assertTrue(isset($result[0]));
$this->assertTrue(isset($result[1]));
$this->assertArrayHasKey(0, $result);
$this->assertArrayHasKey(1, $result);
$this->assertEquals('MyClass', $result[0]);
$this->assertEquals('method', $result[1]);
@ -104,8 +104,8 @@ class MarkupManagerTest extends TestCase
$this->assertTrue($result);
$result = self::callProtectedMethod($manager, 'isWildCallable', [$callable, 'Food']);
$this->assertTrue(isset($result[0]));
$this->assertTrue(isset($result[1]));
$this->assertArrayHasKey(0, $result);
$this->assertArrayHasKey(1, $result);
$this->assertEquals('MyFood', $result[0]);
$this->assertEquals('myFood', $result[1]);
}