From 953061797d44c78f6d0d976bb86a595503b6b14e Mon Sep 17 00:00:00 2001
From: Samuel Georges <sam@daftspunk.com>
Date: Sun, 22 Dec 2019 16:36:04 +1100
Subject: [PATCH] Remove hard coded widget name for lazy tabs (#4839)

- The widget alias may not always be form, so pass the handler name
- No need to spam non-lazy tabs with useless data tags
---
 .../widgets/form/assets/js/october.form.js       |  6 ++++--
 .../backend/widgets/form/partials/_form_tabs.htm | 16 +++++++++++-----
 2 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/modules/backend/widgets/form/assets/js/october.form.js b/modules/backend/widgets/form/assets/js/october.form.js
index 9ad3801b6..932b8bebf 100644
--- a/modules/backend/widgets/form/assets/js/october.form.js
+++ b/modules/backend/widgets/form/assets/js/october.form.js
@@ -167,8 +167,10 @@
      */
     FormWidget.prototype.bindLazyTabs = function() {
         this.$el.on('click', '.tab-lazy [data-toggle="tab"]', function() {
-            var $el = $(this)
-            $.request('form::onLazyLoadTab', {
+            var $el = $(this),
+                handlerName = $el.data('tab-lazy-handler')
+
+            $.request(handlerName, {
                 data: {
                     target: $el.data('target'),
                     name: $el.data('tab-name'),
diff --git a/modules/backend/widgets/form/partials/_form_tabs.htm b/modules/backend/widgets/form/partials/_form_tabs.htm
index 6f1adbe66..e63f78358 100644
--- a/modules/backend/widgets/form/partials/_form_tabs.htm
+++ b/modules/backend/widgets/form/partials/_form_tabs.htm
@@ -13,12 +13,18 @@
 ?>
 <div class="<?= $navCss ?>">
     <ul class="nav nav-tabs">
-        <?php $index = 0; foreach ($tabs as $name => $fields): ?>
-            <?php
-                $lazy = in_array($name, $tabs->lazy);
-            ?>
+        <?php $index = 0; foreach ($tabs as $name => $fields):
+            $lazy = in_array($name, $tabs->lazy);
+        ?>
             <li class="<?= ($index++ === 0) ? 'active' : '' ?> <?= $lazy ? 'tab-lazy' : '' ?>">
-                <a href="#<?= $type . 'tab-' . $index ?>" data-tab-name="<?= e($name) ?>" data-tab-section="<?= $type ?>">
+                <a
+                    href="#<?= $type . 'tab-' . $index ?>"
+                    <?php if ($lazy): ?>
+                        data-tab-name="<?= e($name) ?>"
+                        data-tab-section="<?= $type ?>"
+                        data-tab-lazy-handler="<?= $this->getEventHandler('onLazyLoadTab') ?>"
+                    <?php endif ?>
+                >
                     <span class="title">
                         <span>
                             <?php if ($tabs->getIcon($name)): ?><span class="<?= $tabs->getIcon($name) ?>"></span><?php endif; ?>