From 6fb08f3e1a38a9050f6c6cb7fa6aab72e47c59d5 Mon Sep 17 00:00:00 2001 From: Teranode Date: Mon, 29 Oct 2018 18:35:13 -0400 Subject: [PATCH] Fix resize event after element removal (#3897) This prevents an error from popping up after the popover is hidden/removed `this.$container.remove()` is no longer available after removal so we need to check for the presence of `this.$container`. Credit to @Teranode --- modules/system/assets/ui/js/popover.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/system/assets/ui/js/popover.js b/modules/system/assets/ui/js/popover.js index fa9edfa7d..e001e140e 100644 --- a/modules/system/assets/ui/js/popover.js +++ b/modules/system/assets/ui/js/popover.js @@ -115,8 +115,10 @@ */ this.reposition() - $(window).on('resize', function(e) { - self.reposition() + $(window).on('resize', function() { + if (self.$container) { + self.reposition() + } }) /*