diff --git a/UPGRADE.md b/UPGRADE.md index f8540cfd5..4bc3a6aef 100644 --- a/UPGRADE.md +++ b/UPGRADE.md @@ -92,6 +92,7 @@ The following methods have changed: ### Things to do -- Remove "Cron" package, drop + create relevant tables -- Implement registerSchedule() in PluginBase +- Remove "Cron" package, test new "jobs" table +- Test scheduler +- Remove deprecated code - Fix unit tests \ No newline at end of file diff --git a/modules/backend/classes/BackendHelper.php b/modules/backend/classes/BackendHelper.php index f07637c81..d904f47c6 100644 --- a/modules/backend/classes/BackendHelper.php +++ b/modules/backend/classes/BackendHelper.php @@ -1,6 +1,6 @@ getPath($path, true); - return URL::asset($skinPath); + return Url::asset($skinPath); } /** diff --git a/modules/cms/classes/Controller.php b/modules/cms/classes/Controller.php index ab6befb55..eba3407c3 100644 --- a/modules/cms/classes/Controller.php +++ b/modules/cms/classes/Controller.php @@ -1046,14 +1046,14 @@ class Controller $themePath = Config::get('cms.themesDir').'/'.$this->getTheme()->getDirName(); if (is_array($url)) { - $_url = Request::getBaseUrl(); - $_url .= CombineAssets::combine($url, $themePath); + $_url = URL::to(CombineAssets::combine($url, $themePath)); } else { - $_url = Request::getBasePath().$themePath; + $_url = $themePath; if ($url !== null) { $_url .= '/'.$url; } + $_url = URL::asset($_url); } return $_url; @@ -1085,8 +1085,9 @@ class Controller } foreach ($this->partialComponentStack as $componentInfo) { - if ($componentInfo['name'] == $name) + if ($componentInfo['name'] == $name) { return $componentInfo['obj']; + } } return null; diff --git a/modules/system/classes/CombineAssets.php b/modules/system/classes/CombineAssets.php index ad50e8c75..4114464dd 100644 --- a/modules/system/classes/CombineAssets.php +++ b/modules/system/classes/CombineAssets.php @@ -348,7 +348,7 @@ class CombineAssets return URL::action($combineAction, [$outputFilename], false); } else { - return Request::getBasePath().'/combine/'.$outputFilename; + return '/combine/'.$outputFilename; } } diff --git a/modules/system/providers.php b/modules/system/providers.php index b0ef99b5d..98634fd2f 100644 --- a/modules/system/providers.php +++ b/modules/system/providers.php @@ -32,6 +32,7 @@ return [ 'October\Rain\Database\DatabaseServiceProvider', 'October\Rain\Filesystem\FilesystemServiceProvider', 'October\Rain\Html\HtmlServiceProvider', + 'October\Rain\Html\UrlServiceProvider', 'October\Rain\Network\NetworkServiceProvider', 'October\Rain\Scaffold\ScaffoldServiceProvider', 'October\Rain\Flash\FlashServiceProvider', diff --git a/modules/system/traits/AssetMaker.php b/modules/system/traits/AssetMaker.php index 9187935a6..e3aea95de 100644 --- a/modules/system/traits/AssetMaker.php +++ b/modules/system/traits/AssetMaker.php @@ -1,8 +1,8 @@ traitObject = $this->getObjectForTrait($traitName); }