From 479fa0960693a7c375f4d73ea2bf4e01121a9312 Mon Sep 17 00:00:00 2001
From: Luke Towers <github@luketowers.ca>
Date: Thu, 3 Oct 2019 09:23:43 -0600
Subject: [PATCH] Fix bulk actions on plugins (#4660)

Fixes #4647
---
 .../updates/_list_manage_toolbar.htm          | 68 ++++++++++++-------
 1 file changed, 43 insertions(+), 25 deletions(-)

diff --git a/modules/system/controllers/updates/_list_manage_toolbar.htm b/modules/system/controllers/updates/_list_manage_toolbar.htm
index 6c86ece01..566cfe306 100644
--- a/modules/system/controllers/updates/_list_manage_toolbar.htm
+++ b/modules/system/controllers/updates/_list_manage_toolbar.htm
@@ -20,42 +20,54 @@
         <ul class="dropdown-menu" data-dropdown-title="<?= e(trans('system::lang.plugins.bulk_actions_label')) ?>">
             <li>
                 <a href="javascript:;" class="oc-icon-pause"
-                   data-request="onBulkAction"
-                   data-request-data="action: 'freeze', checked: $('.control-list').listWidget('getChecked')"
-                   data-request-update="list_manage_toolbar: '#plugin-toolbar'"
-                   data-request-confirm="<?= e(trans('system::lang.plugins.action_confirm', ['action' => e(trans('system::lang.plugins.freeze'))])) ?>"
-                   data-stripe-load-indicator>
+                    data-request="onBulkAction"
+                    onclick="$(this).data('request-data', {
+                        action: 'freeze',
+                        checked: $('.control-list').listWidget('getChecked')
+                    })"
+                    data-request-update="list_manage_toolbar: '#plugin-toolbar'"
+                    data-request-confirm="<?= e(trans('system::lang.plugins.action_confirm', ['action' => e(trans('system::lang.plugins.freeze'))])) ?>"
+                    data-stripe-load-indicator>
                     <?= e(trans('system::lang.plugins.freeze_label')) ?>
                 </a>
             </li>
             <li>
                 <a href="javascript:;" class="oc-icon-play"
-                   data-request="onBulkAction"
-                   data-request-data="action: 'unfreeze', checked: $('.control-list').listWidget('getChecked')"
-                   data-request-update="list_manage_toolbar: '#plugin-toolbar'"
-                   data-request-confirm="<?= e(trans('system::lang.plugins.action_confirm', ['action' => e(trans('system::lang.plugins.unfreeze'))])) ?>"
-                   data-stripe-load-indicator>
+                    data-request="onBulkAction"
+                    onclick="$(this).data('request-data', {
+                        action: 'unfreeze',
+                        checked: $('.control-list').listWidget('getChecked')
+                    })"
+                    data-request-update="list_manage_toolbar: '#plugin-toolbar'"
+                    data-request-confirm="<?= e(trans('system::lang.plugins.action_confirm', ['action' => e(trans('system::lang.plugins.unfreeze'))])) ?>"
+                    data-stripe-load-indicator>
                     <?= e(trans('system::lang.plugins.unfreeze_label')) ?>
                 </a>
             </li>
             <li role="separator" class="divider"></li>
             <li>
                 <a href="javascript:;" class="oc-icon-ban"
-                   data-request="onBulkAction"
-                   data-request-data="action: 'disable', checked: $('.control-list').listWidget('getChecked')"
-                   data-request-update="list_manage_toolbar: '#plugin-toolbar'"
-                   data-request-confirm="<?= e(trans('system::lang.plugins.action_confirm', ['action' => e(trans('system::lang.plugins.disable'))])) ?>"
+                    data-request="onBulkAction"
+                    onclick="$(this).data('request-data', {
+                        action: 'disable',
+                        checked: $('.control-list').listWidget('getChecked')
+                    })"
+                    data-request-update="list_manage_toolbar: '#plugin-toolbar'"
+                    data-request-confirm="<?= e(trans('system::lang.plugins.action_confirm', ['action' => e(trans('system::lang.plugins.disable'))])) ?>"
                    data-stripe-load-indicator>
                     <?= e(trans('system::lang.plugins.disable_label')) ?>
                 </a>
             </li>
             <li>
                 <a href="javascript:;" class="oc-icon-check"
-                   data-request="onBulkAction"
-                   data-request-data="action: 'enable', checked: $('.control-list').listWidget('getChecked')"
-                   data-request-update="list_manage_toolbar: '#plugin-toolbar'"
-                   data-request-confirm="<?= e(trans('system::lang.plugins.action_confirm', ['action' => e(trans('system::lang.plugins.enable'))])) ?>"
-                   data-stripe-load-indicator>
+                    data-request="onBulkAction"
+                    onclick="$(this).data('request-data', {
+                        action: 'enable',
+                        checked: $('.control-list').listWidget('getChecked')
+                    })"
+                    data-request-update="list_manage_toolbar: '#plugin-toolbar'"
+                    data-request-confirm="<?= e(trans('system::lang.plugins.action_confirm', ['action' => e(trans('system::lang.plugins.enable'))])) ?>"
+                    data-stripe-load-indicator>
                     <?= e(trans('system::lang.plugins.enable_label')) ?>
                 </a>
             </li>
@@ -63,11 +75,14 @@
                 <li role="separator" class="divider"></li>
                 <li>
                     <a href="javascript:;" class="oc-icon-bomb"
-                       data-request="onBulkAction"
-                       data-request-data="action: 'refresh', checked: $('.control-list').listWidget('getChecked')"
-                       data-request-update="list_manage_toolbar: '#plugin-toolbar'"
-                       data-request-confirm="<?= e(trans('system::lang.plugins.refresh_confirm')) ?>"
-                       data-stripe-load-indicator>
+                        data-request="onBulkAction"
+                        onclick="$(this).data('request-data', {
+                            action: 'refresh',
+                            checked: $('.control-list').listWidget('getChecked')
+                        })"
+                        data-request-update="list_manage_toolbar: '#plugin-toolbar'"
+                        data-request-confirm="<?= e(trans('system::lang.plugins.refresh_confirm')) ?>"
+                        data-stripe-load-indicator>
                         <?= e(trans('system::lang.plugins.refresh_label')) ?>
                     </a>
                 </li>
@@ -79,7 +94,10 @@
             class="btn btn-danger oc-icon-trash-o"
             disabled="disabled"
             data-request="onBulkAction"
-            data-request-data="action: 'remove', checked: $('.control-list').listWidget('getChecked')"
+            onclick="$(this).data('request-data', {
+                action: 'remove',
+                checked: $('.control-list').listWidget('getChecked')
+            })"
             data-request-update="list_manage_toolbar: '#plugin-toolbar'"
             data-request-confirm="<?= e(trans('system::lang.plugins.remove_confirm')) ?>"
             data-trigger-action="enable"