From 6f5e3c7682aaf14379b7878ea8a4cab4fde5faa4 Mon Sep 17 00:00:00 2001 From: Samuel Georges Date: Thu, 15 Jan 2015 17:25:52 +1100 Subject: [PATCH] Minor bug fix where first column is not sortable --- modules/backend/widgets/Lists.php | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/modules/backend/widgets/Lists.php b/modules/backend/widgets/Lists.php index 2aece64c6..36a33d0db 100644 --- a/modules/backend/widgets/Lists.php +++ b/modules/backend/widgets/Lists.php @@ -1005,6 +1005,7 @@ class Lists extends WidgetBase */ if ($this->sortColumn === null || !$this->isSortable($this->sortColumn)) { $columns = $this->visibleColumns ?: $this->getVisibleListColumns(); + $columns = array_filter($columns, function($column){ return $column->sortable; }); $this->sortColumn = key($columns); $this->sortDirection = 'desc'; } @@ -1035,15 +1036,9 @@ class Lists extends WidgetBase } $columns = $this->getColumns(); - $sortable = []; - - foreach ($columns as $column) { - if (!$column->sortable) { - continue; - } - - $sortable[$column->columnName] = $column; - } + $sortable = array_filter($columns, function($column){ + return $column->sortable; + }); return $this->sortableColumns = $sortable; }