From 210fe89fcd7e2886b560eaea1e1b22bfb74c27f3 Mon Sep 17 00:00:00 2001 From: Ben Thomson Date: Tue, 17 Mar 2020 13:05:12 +0800 Subject: [PATCH 1/2] Add GitHub Action for comment commands (#4987) --- .github/workflows/commander.yml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 .github/workflows/commander.yml diff --git a/.github/workflows/commander.yml b/.github/workflows/commander.yml new file mode 100644 index 000000000..5bb113e2c --- /dev/null +++ b/.github/workflows/commander.yml @@ -0,0 +1,16 @@ +name: Commander +on: + issue_comment: + types: [created] + +jobs: + runComment: + runs-on: ubuntu-18.04 + steps: + - name: Checkout code + uses: actions/checkout@v2 + - name: Run comment + uses: nwtgck/actions-comment-run@v1.0 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + allowed-associations: '["OWNER", "MEMBER"]' From 09b7e1b2fd75b46284c9517fe2503f4574b17638 Mon Sep 17 00:00:00 2001 From: Larry Barker Date: Thu, 19 Mar 2020 10:55:18 -0500 Subject: [PATCH 2/2] Add adaptive size options (#4992) Popups can be "adaptive" meaning they fill the width and/or height of the screen. This PR adds this information to the docs to make it better known. --- modules/system/assets/ui/docs/popup.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/system/assets/ui/docs/popup.md b/modules/system/assets/ui/docs/popup.md index 7bdd4c24e..c1ce47b03 100644 --- a/modules/system/assets/ui/docs/popup.md +++ b/modules/system/assets/ui/docs/popup.md @@ -140,7 +140,8 @@ The partial for your rendered popup should follow this structure: - data-handler="onLoadContent" - October ajax request name - data-keyboard="false" - Allow popup to be closed with the keyboard - data-extra-data="file_id: 1" - October ajax request data -- data-size="large" - Popup size, available sizes: giant, huge, large, small, tiny +- data-size="large" - Popup size, available sizes: giant, huge, large, small, tiny, adaptive (will scale to fit the window) +- data-adaptive-height="false" - Allow the popup to fill the height of the screen ### JavaScript API