From 04bf359d8c921d72c3e111f751d4c18112a534f6 Mon Sep 17 00:00:00 2001 From: Tom Date: Fri, 19 Apr 2019 21:46:13 +0300 Subject: [PATCH] Fix for RichEditor root page links being returned with empty hrefs. (#3085) Fixes issue found in https://github.com/octobercms/october/issues/3064#issuecomment-326008148, specifically 2nd bullet point. Credit to @joltmode. --- modules/backend/formwidgets/RichEditor.php | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/modules/backend/formwidgets/RichEditor.php b/modules/backend/formwidgets/RichEditor.php index b9532d54c..91b25c041 100644 --- a/modules/backend/formwidgets/RichEditor.php +++ b/modules/backend/formwidgets/RichEditor.php @@ -224,6 +224,13 @@ class RichEditor extends FormWidgetBase $linkUrl = substr($linkUrl, strlen($baseUrl)); } + /* + * Root page fallback. + */ + if (strlen($linkUrl) === 0) { + $linkUrl = '/'; + } + $linkName = str_repeat(' ', $level * 4); $linkName .= is_array($link) ? array_get($link, 'title', '') : $link; $result[] = ['name' => $linkName, 'url' => $linkUrl];